Completed
Pull Request — master (#3650)
by Olle
17:51 queued 17:51
created
src/Psalm/Internal/Type/SimpleAssertionReconciler.php 1 patch
Doc Comments   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -48,6 +48,7 @@  discard block
 block discarded – undo
48 48
     /**
49 49
      * @param   string[]  $suppressed_issues
50 50
      * @param   0|1|2    $failed_reconciliation
51
+     * @param CodeLocation $code_location
51 52
      */
52 53
     public static function reconcile(
53 54
         string $assertion,
@@ -368,6 +369,7 @@  discard block
 block discarded – undo
368 369
     /**
369 370
      * @param   string[]  $suppressed_issues
370 371
      * @param   0|1|2    $failed_reconciliation
372
+     * @param null|integer $min_count
371 373
      */
372 374
     private static function reconcileNonEmptyCountable(
373 375
         Union $existing_var_type,
@@ -1227,8 +1229,6 @@  discard block
 block discarded – undo
1227 1229
     }
1228 1230
 
1229 1231
     /**
1230
-     * @param   string[]  $suppressed_issues
1231
-     * @param   0|1|2    $failed_reconciliation
1232 1232
      */
1233 1233
     private static function reconcileInArray(
1234 1234
         Codebase $codebase,
@@ -1271,8 +1271,6 @@  discard block
 block discarded – undo
1271 1271
     }
1272 1272
 
1273 1273
     /**
1274
-     * @param   string[]  $suppressed_issues
1275
-     * @param   0|1|2    $failed_reconciliation
1276 1274
      */
1277 1275
     private static function reconcileHasArrayKey(
1278 1276
         Union $existing_var_type,
Please login to merge, or discard this patch.
src/Psalm/DocComment.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -178,7 +178,6 @@
 block discarded – undo
178 178
      * Parse a docblock comment into its parts.
179 179
      *
180 180
      * @param  \PhpParser\Comment\Doc  $docblock
181
-     * @param  bool    $preserve_format
182 181
      */
183 182
     public static function parsePreservingLength(\PhpParser\Comment\Doc $docblock) : ParsedDocblock
184 183
     {
Please login to merge, or discard this patch.
src/Psalm/Internal/Analyzer/CommentAnalyzer.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Psalm\Exception\TypeParseTreeException;
10 10
 use Psalm\FileSource;
11 11
 use Psalm\Internal\Scanner\ClassLikeDocblockComment;
12
-use Psalm\Internal\Scanner\DocblockParser;
13 12
 use Psalm\Internal\Scanner\FunctionDocblockComment;
14 13
 use Psalm\Internal\Scanner\VarDocblockComment;
15 14
 use Psalm\Internal\Scanner\ParsedDocblock;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -256,6 +256,7 @@  discard block
 block discarded – undo
256 256
     /**
257 257
      * @param  Aliases          $aliases
258 258
      * @param  array<string, TypeAlias> $type_aliases
259
+     * @param string|null $self_fqcln
259 260
      *
260 261
      * @throws DocblockParseException if there was a problem parsing the docblock
261 262
      *
@@ -361,7 +362,6 @@  discard block
 block discarded – undo
361 362
     }
362 363
 
363 364
     /**
364
-     * @param  int     $line_number
365 365
      *
366 366
      * @throws DocblockParseException if there was a problem parsing the docblock
367 367
      *
Please login to merge, or discard this patch.
src/Psalm/Internal/Stubs/Generator/ClassLikeStubGenerator.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Psalm\Internal\Stubs\Generator;
4 4
 
5 5
 use PhpParser;
6
-use Psalm\Storage\MethodStorage;
7 6
 use Psalm\Storage\ClassLikeStorage;
8 7
 use Psalm\Internal\Scanner\ParsedDocblock;
9 8
 use Psalm\Type;
Please login to merge, or discard this patch.
src/Psalm/Internal/Stubs/Generator/StubsGenerator.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use PhpParser;
6 6
 use Psalm\Internal\Provider;
7 7
 use Psalm\Internal\Scanner\ParsedDocblock;
8
-use Psalm\Storage\MethodStorage;
9 8
 use Psalm\Type;
10 9
 
11 10
 class StubsGenerator
Please login to merge, or discard this patch.
src/psalter.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 require_once('command_functions.php');
3 3
 
4
-use Psalm\DocComment;
5 4
 use Psalm\Internal\Analyzer\ProjectAnalyzer;
6 5
 use Psalm\Config;
7 6
 use Psalm\IssueBuffer;
Please login to merge, or discard this patch.
src/Psalm/Internal/TypeVisitor/TypeChecker.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 namespace Psalm\Internal\TypeVisitor;
3 3
 
4 4
 use Psalm\CodeLocation;
5
-use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
6 5
 use Psalm\Internal\Analyzer\ClassLikeAnalyzer;
7 6
 use Psalm\Internal\Analyzer\TypeAnalyzer;
8 7
 use Psalm\Internal\Type\TypeExpander;
Please login to merge, or discard this patch.
src/Psalm/Internal/Analyzer/Statements/Block/TryAnalyzer.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -290,9 +290,9 @@
 block discarded – undo
290 290
                 $catch_context->vars_in_scope[$catch_var_id] = new Union(
291 291
                     array_map(
292 292
                         /**
293
-                         * @param string $fq_catch_class
293
+                         * @param StatementsAnalyzer $fq_catch_class
294 294
                          *
295
-                         * @return Type\Atomic
295
+                         * @return false|null
296 296
                          */
297 297
                         function ($fq_catch_class) use ($codebase) {
298 298
                             $catch_class_type = new TNamedObject($fq_catch_class);
Please login to merge, or discard this patch.
src/Psalm/Internal/Stubs/ext-ds.php 1 patch
Doc Comments   +16 added lines, -7 removed lines patch added patch discarded remove patch
@@ -466,6 +466,7 @@  discard block
 block discarded – undo
466 466
 
467 467
     /**
468 468
      * @param TValue ...$values
469
+     * @param TValue[] $values
469 470
      */
470 471
     public function contains(...$values): bool;
471 472
 
@@ -482,19 +483,20 @@  discard block
 block discarded – undo
482 483
     public function find($value);
483 484
 
484 485
     /**
485
-     * @return TValue
486
+     * @return TValue|null
486 487
      * @throws \UnderflowException
487 488
      */
488 489
     public function first();
489 490
 
490 491
     /**
491
-     * @return TValue
492
+     * @return TValue|null
492 493
      * @throws \OutOfRangeException
493 494
      */
494 495
     public function get(int $index);
495 496
 
496 497
     /**
497 498
      * @param TValue ...$values
499
+     * @param TValue[] $values
498 500
      * @throws \OutOfRangeException
499 501
      */
500 502
     public function insert(int $index, ...$values);
@@ -506,7 +508,7 @@  discard block
 block discarded – undo
506 508
     public function join(string $glue = null): string;
507 509
 
508 510
     /**
509
-     * @return TValue
511
+     * @return TValue|null
510 512
      * @throws \UnderflowException
511 513
      */
512 514
     public function last();
@@ -526,13 +528,14 @@  discard block
 block discarded – undo
526 528
     public function merge(iterable $values): Sequence;
527 529
 
528 530
     /**
529
-     * @return TValue
531
+     * @return TValue|null
530 532
      * @throws \UnderflowException
531 533
      */
532 534
     public function pop();
533 535
 
534 536
     /**
535 537
      * @param TValue ...$values
538
+     * @param TValue[] $values
536 539
      */
537 540
     public function push(...$values);
538 541
 
@@ -540,12 +543,12 @@  discard block
 block discarded – undo
540 543
      * @template TCarry
541 544
      * @param callable(TCarry, TValue): TCarry $callback
542 545
      * @param TCarry $initial
543
-     * @return TCarry
546
+     * @return TCarry|null
544 547
      */
545 548
     public function reduce(callable $callback, $initial = null);
546 549
 
547 550
     /**
548
-     * @return TValue
551
+     * @return TValue|null
549 552
      * @throws \OutOfRangeException
550 553
      */
551 554
     public function remove(int $index);
@@ -562,7 +565,7 @@  discard block
 block discarded – undo
562 565
     public function set(int $index, $value);
563 566
 
564 567
     /**
565
-     * @return TValue
568
+     * @return TValue|null
566 569
      * @throws \UnderflowException
567 570
      */
568 571
     public function shift();
@@ -585,6 +588,7 @@  discard block
 block discarded – undo
585 588
 
586 589
     /**
587 590
      * @param TValue ...$values
591
+     * @param TValue[] $values
588 592
      */
589 593
     public function unshift(...$values);
590 594
 }
@@ -739,6 +743,7 @@  discard block
 block discarded – undo
739 743
 
740 744
     /**
741 745
      * @param TValue ...$values
746
+     * @param TValue[] $values
742 747
      */
743 748
     public function add(...$values): void
744 749
     {
@@ -746,6 +751,7 @@  discard block
 block discarded – undo
746 751
 
747 752
     /**
748 753
      * @param TValue ...$values
754
+     * @param TValue[] $values
749 755
      */
750 756
     public function contains(...$values): bool
751 757
     {
@@ -819,6 +825,7 @@  discard block
 block discarded – undo
819 825
 
820 826
     /**
821 827
      * @param TValue ...$values
828
+     * @param TValue[] $values
822 829
      */
823 830
     public function remove(...$values): void
824 831
     {
@@ -917,6 +924,7 @@  discard block
 block discarded – undo
917 924
 
918 925
     /**
919 926
      * @param TValue ...$values
927
+     * @param TValue[] $values
920 928
      */
921 929
     public function push(...$values): void
922 930
     {
@@ -968,6 +976,7 @@  discard block
 block discarded – undo
968 976
 
969 977
     /**
970 978
      * @param TValue ...$values
979
+     * @param TValue[] $values
971 980
      */
972 981
     public function push(...$values): void
973 982
     {
Please login to merge, or discard this patch.