vimeo / psalm

src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php

Doc Comments +9 added lines

@@ -305,6 +305,9 @@ 
         return true;
     }
 
+    /**
+     * @param string|null $keyed_array_var_id
+     */
     private static function taintArrayFetch(
         StatementsAnalyzer $statements_analyzer,
         PhpParser\Node\Expr\ArrayDimFetch $stmt,
@@ -1468,6 +1471,9 @@ 
         return $array_access_type;
     }
 
+    /**
+     * @param null|string $array_var_id
+     */
     private static function checkLiteralIntArrayOffset(
         Type\Union $offset_type,
         Type\Union $expected_offset_type,
@@ -1517,6 +1523,9 @@ 
         }
     }
 
+    /**
+     * @param null|string $array_var_id
+     */
     private static function checkLiteralStringArrayOffset(
         Type\Union $offset_type,
         Type\Union $expected_offset_type,

src/Psalm/Internal/Analyzer/Statements/Expression/Assignment/StaticPropertyAssignmentAnalyzer.php

Unused Use Statements -24 removed lines

@@ -2,50 +2,26 @@
 namespace Psalm\Internal\Analyzer\Statements\Expression\Assignment;
 
 use PhpParser;
-use PhpParser\Node\Expr\PropertyFetch;
-use PhpParser\Node\Stmt\PropertyProperty;
 use Psalm\Internal\Analyzer\ClassLikeAnalyzer;
-use Psalm\Internal\Analyzer\NamespaceAnalyzer;
 use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
 use Psalm\Internal\Analyzer\Statements\Expression\ExpressionIdentifier;
-use Psalm\Internal\Analyzer\Statements\Expression\Fetch\InstancePropertyFetchAnalyzer;
 use Psalm\Internal\Analyzer\StatementsAnalyzer;
 use Psalm\Internal\Analyzer\TypeAnalyzer;
 use Psalm\Internal\FileManipulation\FileManipulationBuffer;
 use Psalm\CodeLocation;
 use Psalm\Context;
-use Psalm\Issue\DeprecatedProperty;
 use Psalm\Issue\ImplicitToStringCast;
-use Psalm\Issue\InaccessibleProperty;
-use Psalm\Issue\InternalProperty;
-use Psalm\Issue\InvalidPropertyAssignment;
 use Psalm\Issue\InvalidPropertyAssignmentValue;
-use Psalm\Issue\LoopInvalidation;
-use Psalm\Issue\MixedAssignment;
-use Psalm\Issue\MixedPropertyAssignment;
 use Psalm\Issue\MixedPropertyTypeCoercion;
-use Psalm\Issue\NoInterfaceProperties;
-use Psalm\Issue\NullPropertyAssignment;
-use Psalm\Issue\PossiblyFalsePropertyAssignmentValue;
-use Psalm\Issue\PossiblyInvalidPropertyAssignment;
 use Psalm\Issue\PossiblyInvalidPropertyAssignmentValue;
-use Psalm\Issue\PossiblyNullPropertyAssignment;
-use Psalm\Issue\PossiblyNullPropertyAssignmentValue;
 use Psalm\Issue\PropertyTypeCoercion;
-use Psalm\Issue\UndefinedClass;
 use Psalm\Issue\UndefinedPropertyAssignment;
-use Psalm\Issue\UndefinedMagicPropertyAssignment;
-use Psalm\Issue\UndefinedThisPropertyAssignment;
 use Psalm\IssueBuffer;
 use Psalm\Type;
-use Psalm\Type\Atomic\TNamedObject;
-use Psalm\Type\Atomic\TNull;
-use Psalm\Type\Atomic\TObject;
 use function count;
 use function in_array;
 use function strtolower;
 use function explode;
-use Psalm\Internal\Taint\TaintNode;
 
 /**
  * @internal

src/Psalm/Internal/Analyzer/Statements/Expression/Call/FunctionCallAnalyzer.php

Doc Comments +4 added lines

@@ -884,6 +884,7 @@ 
 
     /**
      * @param non-empty-string $function_id
+     * @param \Psalm\Storage\FunctionStorage|null $function_storage
      */
     private static function getFunctionCallReturnType(
         StatementsAnalyzer $statements_analyzer,
@@ -1189,6 +1190,9 @@ 
         return true;
     }
 
+    /**
+     * @param \Psalm\Storage\FunctionStorage|null $function_storage
+     */
     private static function checkFunctionCallPurity(
         StatementsAnalyzer $statements_analyzer,
         \Psalm\Codebase $codebase,

src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php

Doc Comments +4 added lines, -1 removed lines

@@ -588,7 +588,7 @@ 
 
                         $array_values = array_map(
                             /**
-                             * @return PhpParser\Node\Expr\ArrayItem
+                             * @return boolean
                              */
                             function (PhpParser\Node\Arg $arg) {
                                 return new PhpParser\Node\Expr\ArrayItem($arg->value);
@@ -1346,6 +1346,9 @@ 
         return true;
     }
 
+    /**
+     * @param \Psalm\Storage\MethodStorage|null $method_storage
+     */
     private static function taintReturnType(
         StatementsAnalyzer $statements_analyzer,
         PhpParser\Node\Expr\StaticCall $stmt,

src/Psalm/Internal/Codebase/Taint.php

Unused Use Statements -6 removed lines

@@ -2,11 +2,6 @@ 
 
 namespace Psalm\Internal\Codebase;
 
-use Psalm\CodeLocation;
-use Psalm\Internal\Analyzer\StatementsAnalyzer;
-use Psalm\Internal\Provider\ClassLikeStorageProvider;
-use Psalm\Internal\Provider\FileReferenceProvider;
-use Psalm\Internal\Provider\FileStorageProvider;
 use Psalm\Internal\Taint\Path;
 use Psalm\Internal\Taint\Sink;
 use Psalm\Internal\Taint\Source;
@@ -17,7 +12,6 @@ 
 use function array_merge;
 use function array_merge_recursive;
 use function strtolower;
-use UnexpectedValueException;
 use function count;
 use function implode;
 use function substr;