vimeo / psalm

src/Psalm/Internal/Type/SimpleAssertionReconciler.php

Doc Comments +2 added lines, -4 removed lines

@@ -48,6 +48,7 @@ 
     /**
      * @param   string[]  $suppressed_issues
      * @param   0|1|2    $failed_reconciliation
+     * @param CodeLocation $code_location
      */
     public static function reconcile(
         string $assertion,
@@ -368,6 +369,7 @@ 
     /**
      * @param   string[]  $suppressed_issues
      * @param   0|1|2    $failed_reconciliation
+     * @param null|integer $min_count
      */
     private static function reconcileNonEmptyCountable(
         Union $existing_var_type,
@@ -1227,8 +1229,6 @@ 
     }
 
     /**
-     * @param   string[]  $suppressed_issues
-     * @param   0|1|2    $failed_reconciliation
      */
     private static function reconcileInArray(
         Codebase $codebase,
@@ -1271,8 +1271,6 @@ 
     }
 
     /**
-     * @param   string[]  $suppressed_issues
-     * @param   0|1|2    $failed_reconciliation
      */
     private static function reconcileHasArrayKey(
         Union $existing_var_type,

src/Psalm/DocComment.php

Doc Comments -1 removed lines

@@ -178,7 +178,6 @@
      * Parse a docblock comment into its parts.
      *
      * @param  \PhpParser\Comment\Doc  $docblock
-     * @param  bool    $preserve_format
      */
     public static function parsePreservingLength(\PhpParser\Comment\Doc $docblock) : ParsedDocblock
     {

src/Psalm/Internal/Analyzer/Statements/Block/TryAnalyzer.php

Doc Comments +2 added lines, -2 removed lines

@@ -290,9 +290,9 @@
                 $catch_context->vars_in_scope[$catch_var_id] = new Union(
                     array_map(
                         /**
-                         * @param string $fq_catch_class
+                         * @param StatementsAnalyzer $fq_catch_class
                          *
-                         * @return Type\Atomic
+                         * @return false|null
                          */
                         function ($fq_catch_class) use ($codebase) {
                             $catch_class_type = new TNamedObject($fq_catch_class);

src/Psalm/Internal/Analyzer/CommentAnalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -256,6 +256,7 @@ 
     /**
      * @param  Aliases          $aliases
      * @param  array<string, TypeAlias> $type_aliases
+     * @param string|null $self_fqcln
      *
      * @throws DocblockParseException if there was a problem parsing the docblock
      *
@@ -361,7 +362,6 @@ 
     }
 
     /**
-     * @param  int     $line_number
      *
      * @throws DocblockParseException if there was a problem parsing the docblock
      *

src/Psalm/Internal/Stubs/ext-ds.php

Doc Comments +16 added lines, -7 removed lines

@@ -466,6 +466,7 @@ 
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      */
     public function contains(...$values): bool;
 
@@ -482,19 +483,20 @@ 
     public function find($value);
 
     /**
-     * @return TValue
+     * @return TValue|null
      * @throws \UnderflowException
      */
     public function first();
 
     /**
-     * @return TValue
+     * @return TValue|null
      * @throws \OutOfRangeException
      */
     public function get(int $index);
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      * @throws \OutOfRangeException
      */
     public function insert(int $index, ...$values);
@@ -506,7 +508,7 @@ 
     public function join(string $glue = null): string;
 
     /**
-     * @return TValue
+     * @return TValue|null
      * @throws \UnderflowException
      */
     public function last();
@@ -526,13 +528,14 @@ 
     public function merge(iterable $values): Sequence;
 
     /**
-     * @return TValue
+     * @return TValue|null
      * @throws \UnderflowException
      */
     public function pop();
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      */
     public function push(...$values);
 
@@ -540,12 +543,12 @@ 
      * @template TCarry
      * @param callable(TCarry, TValue): TCarry $callback
      * @param TCarry $initial
-     * @return TCarry
+     * @return TCarry|null
      */
     public function reduce(callable $callback, $initial = null);
 
     /**
-     * @return TValue
+     * @return TValue|null
      * @throws \OutOfRangeException
      */
     public function remove(int $index);
@@ -562,7 +565,7 @@ 
     public function set(int $index, $value);
 
     /**
-     * @return TValue
+     * @return TValue|null
      * @throws \UnderflowException
      */
     public function shift();
@@ -585,6 +588,7 @@ 
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      */
     public function unshift(...$values);
 }
@@ -739,6 +743,7 @@ 
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      */
     public function add(...$values): void
     {
@@ -746,6 +751,7 @@ 
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      */
     public function contains(...$values): bool
     {
@@ -819,6 +825,7 @@ 
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      */
     public function remove(...$values): void
     {
@@ -917,6 +924,7 @@ 
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      */
     public function push(...$values): void
     {
@@ -968,6 +976,7 @@ 
 
     /**
      * @param TValue ...$values
+     * @param TValue[] $values
      */
     public function push(...$values): void
     {

src/Psalm/Internal/Analyzer/Statements/Expression/Assignment/ArrayAssignmentAnalyzer.php

Doc Comments +2 added lines

@@ -69,6 +69,7 @@ 
 
     /**
      *
+     * @param PhpParser\Node\Expr|null $assign_value
      * @return false|null
      */
     public static function updateArrayType(
@@ -745,6 +746,7 @@ 
 
     /**
      * @param int|string|null $item_key_value
+     * @param string|null $array_var_id
      */
     private static function taintArrayAssignment(
         StatementsAnalyzer $statements_analyzer,

src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php

Doc Comments +9 added lines

@@ -305,6 +305,9 @@ 
         return true;
     }
 
+    /**
+     * @param string|null $keyed_array_var_id
+     */
     private static function taintArrayFetch(
         StatementsAnalyzer $statements_analyzer,
         PhpParser\Node\Expr\ArrayDimFetch $stmt,
@@ -1468,6 +1471,9 @@ 
         return $array_access_type;
     }
 
+    /**
+     * @param null|string $array_var_id
+     */
     private static function checkLiteralIntArrayOffset(
         Type\Union $offset_type,
         Type\Union $expected_offset_type,
@@ -1517,6 +1523,9 @@ 
         }
     }
 
+    /**
+     * @param null|string $array_var_id
+     */
     private static function checkLiteralStringArrayOffset(
         Type\Union $offset_type,
         Type\Union $expected_offset_type,

src/Psalm/Internal/Analyzer/Statements/Expression/Call/FunctionCallAnalyzer.php

Doc Comments +4 added lines

@@ -884,6 +884,7 @@ 
 
     /**
      * @param non-empty-string $function_id
+     * @param \Psalm\Storage\FunctionStorage|null $function_storage
      */
     private static function getFunctionCallReturnType(
         StatementsAnalyzer $statements_analyzer,
@@ -1189,6 +1190,9 @@ 
         return true;
     }
 
+    /**
+     * @param \Psalm\Storage\FunctionStorage|null $function_storage
+     */
     private static function checkFunctionCallPurity(
         StatementsAnalyzer $statements_analyzer,
         \Psalm\Codebase $codebase,

src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php

Doc Comments +4 added lines, -1 removed lines

@@ -588,7 +588,7 @@ 
 
                         $array_values = array_map(
                             /**
-                             * @return PhpParser\Node\Expr\ArrayItem
+                             * @return boolean
                              */
                             function (PhpParser\Node\Arg $arg) {
                                 return new PhpParser\Node\Expr\ArrayItem($arg->value);
@@ -1346,6 +1346,9 @@ 
         return true;
     }
 
+    /**
+     * @param \Psalm\Storage\MethodStorage|null $method_storage
+     */
     private static function taintReturnType(
         StatementsAnalyzer $statements_analyzer,
         PhpParser\Node\Expr\StaticCall $stmt,