vimeo / psalm

src/Psalm/Internal/Analyzer/Statements/Expression/Call/FunctionCallAnalyzer.php

Doc Comments +4 added lines

@@ -884,6 +884,7 @@ 
 
     /**
      * @param non-empty-string $function_id
+     * @param \Psalm\Storage\FunctionStorage|null $function_storage
      */
     private static function getFunctionCallReturnType(
         StatementsAnalyzer $statements_analyzer,
@@ -1189,6 +1190,9 @@ 
         return true;
     }
 
+    /**
+     * @param \Psalm\Storage\FunctionStorage|null $function_storage
+     */
     private static function checkFunctionCallPurity(
         StatementsAnalyzer $statements_analyzer,
         \Psalm\Codebase $codebase,

src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php

Doc Comments +4 added lines, -1 removed lines

@@ -588,7 +588,7 @@ 
 
                         $array_values = array_map(
                             /**
-                             * @return PhpParser\Node\Expr\ArrayItem
+                             * @return boolean
                              */
                             function (PhpParser\Node\Arg $arg) {
                                 return new PhpParser\Node\Expr\ArrayItem($arg->value);
@@ -1346,6 +1346,9 @@ 
         return true;
     }
 
+    /**
+     * @param \Psalm\Storage\MethodStorage|null $method_storage
+     */
     private static function taintReturnType(
         StatementsAnalyzer $statements_analyzer,
         PhpParser\Node\Expr\StaticCall $stmt,

src/Psalm/Internal/Codebase/Taint.php

Unused Use Statements -6 removed lines

@@ -2,11 +2,6 @@ 
 
 namespace Psalm\Internal\Codebase;
 
-use Psalm\CodeLocation;
-use Psalm\Internal\Analyzer\StatementsAnalyzer;
-use Psalm\Internal\Provider\ClassLikeStorageProvider;
-use Psalm\Internal\Provider\FileReferenceProvider;
-use Psalm\Internal\Provider\FileStorageProvider;
 use Psalm\Internal\Taint\Path;
 use Psalm\Internal\Taint\Sink;
 use Psalm\Internal\Taint\Source;
@@ -17,7 +12,6 @@ 
 use function array_merge;
 use function array_merge_recursive;
 use function strtolower;
-use UnexpectedValueException;
 use function count;
 use function implode;
 use function substr;

src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php

Doc Comments +7 added lines, -4 removed lines

@@ -404,7 +404,7 @@ 
         if ($storage instanceof MethodStorage) {
             $non_null_param_types = array_filter(
                 $storage->params,
-                /** @return bool */
+                /** @return null|false */
                 function (FunctionLikeParameter $p) {
                     return $p->type !== null && $p->has_docblock_type;
                 }
@@ -412,7 +412,7 @@ 
         } else {
             $non_null_param_types = array_filter(
                 $storage->params,
-                /** @return bool */
+                /** @return null|false */
                 function (FunctionLikeParameter $p) {
                     return $p->type !== null;
                 }
@@ -425,7 +425,7 @@ 
         ) {
             $types_without_docblocks = array_filter(
                 $storage->params,
-                /** @return bool */
+                /** @return null|false */
                 function (FunctionLikeParameter $p) {
                     return !$p->type || !$p->has_docblock_type;
                 }
@@ -839,6 +839,9 @@ 
         return null;
     }
 
+    /**
+     * @param \Psalm\Storage\ClassLikeStorage|null $class_storage
+     */
     private function checkParamReferences(
         StatementsAnalyzer $statements_analyzer,
         FunctionLikeStorage $storage,
@@ -962,6 +965,7 @@ 
     /**
      * @param array<int, \Psalm\Storage\FunctionLikeParameter> $params
      * @param array<int, Type\Union> $implemented_docblock_param_types
+     * @param string|null $cased_method_id
      */
     private function processParams(
         StatementsAnalyzer $statements_analyzer,
@@ -1471,7 +1475,6 @@ 
     /**
      * Adds return types for the given function
      *
-     * @param   string  $return_type
      * @param   Context $context
      *
      * @return  void

src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php

Doc Comments +1 added lines

@@ -691,6 +691,7 @@
      * @param  string|null $cased_method_id
      * @param  FunctionLikeParameter|null $last_param
      * @param  array<int, FunctionLikeParameter> $function_params
+     * @param FunctionLikeParameter[] $function_params
      * @return false|null
      */
     private static function handlePossiblyMatchingByRefParam(