vimeo / psalm

src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/AtomicMethodCallAnalyzer.php

Doc Comments +4 added lines, -1 removed lines

@@ -48,7 +48,7 @@ 
      * @param  Codebase                       $codebase
      * @param  Context                        $context
      * @param  Type\Atomic\TNamedObject|Type\Atomic\TTemplateParam  $static_type
-     * @param  ?string                        $lhs_var_id
+     * @param  string|null                        $lhs_var_id
      */
     public static function analyze(
         StatementsAnalyzer $statements_analyzer,
@@ -831,6 +831,9 @@ 
         );
     }
 
+    /**
+     * @param Type\Union|null $all_intersection_return_type
+     */
     private static function updateResultReturnType(
         AtomicMethodCallAnalysisResult $result,
         ?Type\Union $return_type_candidate,

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Psalm\Internal\Analyzer\Statements\Expression\Call\ArgumentMapPopulator;
 use Psalm\Internal\Analyzer\Statements\Expression\Call\ClassTemplateParamCollector;
 use Psalm\Internal\Analyzer\Statements\Expression\Call\ArgumentsAnalyzer;
-use Psalm\Internal\Analyzer\Statements\Expression\Fetch\PropertyFetchAnalyzer;
 use Psalm\Internal\Analyzer\Statements\Expression\ExpressionIdentifier;
 use Psalm\Internal\Analyzer\StatementsAnalyzer;
 use Psalm\Internal\Analyzer\TypeAnalyzer;

src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -500,7 +500,7 @@
 
                         $array_values = array_map(
                             /**
-                             * @return PhpParser\Node\Expr\ArrayItem
+                             * @return boolean
                              */
                             function (PhpParser\Node\Arg $arg) {
                                 return new PhpParser\Node\Expr\ArrayItem($arg->value);

src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php

Doc Comments +1 added lines

@@ -224,6 +224,7 @@
      * @param  Context                          $context
      * @param  CodeLocation                     $code_location
      * @param  StatementsAnalyzer               $statements_analyzer
+     * @param TemplateResult|null $class_template_result
      */
     protected static function checkMethodArgs(
         ?\Psalm\Internal\MethodIdentifier $method_id,

src/Psalm/Internal/Analyzer/Statements/Expression/ExpressionIdentifier.php

Doc Comments +1 added lines

@@ -18,6 +18,7 @@
      * @param  string|null              $this_class_name
      * @param  FileSource|null    $source
      * @param  int|null                 &$nesting
+     * @param integer $nesting
      *
      * @return string|null
      */

src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php

Doc Comments +6 added lines

@@ -1432,6 +1432,9 @@ 
         return $array_access_type;
     }
 
+    /**
+     * @param null|string $array_var_id
+     */
     private static function checkLiteralIntArrayOffset(
         Type\Union $offset_type,
         Type\Union $expected_offset_type,
@@ -1481,6 +1484,9 @@ 
         }
     }
 
+    /**
+     * @param null|string $array_var_id
+     */
     private static function checkLiteralStringArrayOffset(
         Type\Union $offset_type,
         Type\Union $expected_offset_type,

Unused Use Statements -1 removed lines

@@ -57,7 +57,6 @@
 use function in_array;
 use function is_int;
 use function preg_match;
-use Psalm\Internal\Taint\TaintNode;
 use Psalm\Internal\Taint\Source;
 use Psalm\Internal\Type\TemplateResult;
 

src/Psalm/Internal/Analyzer/Statements/Expression/IncDecExpressionAnalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 class IncDecExpressionAnalyzer
 {
     /**
-     * @param PostInc|PostDec|PreInc|PreDec $stmt
+     * @param PhpParser\Node\Expr $stmt
      */
     public static function analyze(
         StatementsAnalyzer $statements_analyzer,

src/Psalm/Internal/Analyzer/Statements/ExpressionAnalyzer.php

Doc Comments +3 added lines

@@ -99,6 +99,9 @@
         return true;
     }
 
+    /**
+     * @param null|Context $global_context
+     */
     private static function handleExpression(
         StatementsAnalyzer $statements_analyzer,
         PhpParser\Node\Expr $stmt,

src/Psalm/Internal/Analyzer/StatementsAnalyzer.php

Doc Comments +3 added lines, -2 removed lines

@@ -271,6 +271,7 @@ 
 
     /**
      * @psalm-return false|null
+     * @param null|Context $global_context
      */
     private static function analyzeStatement(
         StatementsAnalyzer $statements_analyzer,
@@ -344,9 +345,9 @@ 
                 $suppressed = array_filter(
                     array_map(
                         /**
-                         * @param string $line
+                         * @param StatementsAnalyzer $line
                          *
-                         * @return string
+                         * @return false|null
                          */
                         function ($line) {
                             return preg_split('/[\s]+/', $line)[0];

src/Psalm/Internal/Analyzer/TypeAnalyzer.php

Doc Comments +6 added lines, -4 removed lines

@@ -304,7 +304,7 @@ 
     /**
      * Used for comparing signature typehints, uses PHP's light contravariance rules
      *
-     * @param  ?Type\Union  $input_type
+     * @param  Type\Union|null  $input_type
      * @param  Type\Union   $container_type
      *
      * @return bool
@@ -501,8 +501,8 @@ 
 
     /**
      * @param  Codebase       $codebase
-     * @param  TNamedObject|TTemplateParam|TIterable  $input_type_part
-     * @param  TNamedObject|TTemplateParam|TIterable  $container_type_part
+     * @param  Type\Atomic  $input_type_part
+     * @param  Type\Atomic  $container_type_part
      * @param  bool           $allow_interface_equality
      *
      * @return bool
@@ -765,6 +765,7 @@ 
 
     /**
      * Does the input param atomic type match the given param atomic type
+     * @param TypeComparisonResult $atomic_comparison_result
      */
     public static function isAtomicContainedBy(
         Codebase $codebase,
@@ -1913,6 +1914,7 @@ 
     }
 
     /**
+     * @param TCallable $container_type_part
      * @return ?TCallable
      */
     public static function getCallableFromAtomic(
@@ -2388,7 +2390,7 @@ 
                 $container_params_can_be_undefined = (bool) array_reduce(
                     $container_type_part->properties,
                     /**
-                     * @param bool $carry
+                     * @param Codebase $carry
                      *
                      * @return bool
                      */