Issues in ModelsTest.php (master) - Issues in master - vikkio88/dsManager-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (80)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

api/tests/ModelsTest.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


/**
 * Class ModelsTest
 */
class ModelsTest extends \PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{


    /**
     * @group Player
     */
    public function testGetRandomPlayer()
    {
        $rndF = new \App\Lib\DsManager\Helpers\RandomFiller();
        $player = $rndF->getPlayer(null, $rndF->getLocale());
        $array = $player->toArray();
        $this->assertNotEmpty($array);

        $newPlayer = \App\Lib\DsManager\Models\Player::fromArray($array);
        $this->assertNotEmpty($newPlayer->toArray());
    }

    /**
     * @group Coach
     */
    public function testGetRandomCoach()
    {
        $rndF = new \App\Lib\DsManager\Helpers\RandomFiller();
        $coach = $rndF->getCoach();
        $this->assertNotEmpty($coach->toArray());
    }

    /**
     * @group Coaches
     */
    public function testGetRandomCoaches()

    {
        foreach (\App\Lib\Helpers\Config::get('generic.localesSmall') as $nat) {

            $rndF = new \App\Lib\DsManager\Helpers\RandomFiller($nat);
            $coach = $rndF->getCoach();
            $this->assertNotEmpty($coach->toArray());
        }
    }

    /**
     * @group Players
     */
    public function testGetRandomPlayers()

    {
        foreach (\App\Lib\Helpers\Config::get('generic.localesSmall') as $nat) {

            $rndF = new \App\Lib\DsManager\Helpers\RandomFiller($nat);
            $player = $rndF->getPlayer();
            $this->assertNotEmpty($player->toArray());
        }
    }

    /**
     * @group Team
     */
    public function testGetRandomTeam()
    {
        $rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
        $team = $rndF->getTeam();
        $this->assertNotEmpty($team);
        $this->assertNotEmpty($team->name);
        $this->assertNotEmpty($team->getAvgSkill());

        //After Adding a player
        $player = $rndF->getPlayer();
        $this->assertNotEmpty($player->toArray());
        $team->roster[] = $player;
        $this->assertNotEmpty($team->getAvgSkill());
        $this->assertNotEmpty($team->getAvgAge());

        $this->assertNotEmpty($team->coach->toArray());

        $teamArray = $team->toArray();
        $this->assertNotEmpty($teamArray);

        $newTeam = \App\Lib\DsManager\Models\Team::fromArray($teamArray);
        $this->assertNotEmpty($newTeam->toArray());

    }

    /**
     * @group Teams
     */
    public function testGetRandomTeams()
    {
        $rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");

        for ($i = 1; $i <= 20; $i++) {
            $team = $rndF->getTeam();
            $this->assertGreaterThanOrEqual(
                \App\Lib\Helpers\Config::get('generic.rosters')['min'],
                count($team->roster)
            );
            $this->assertNotEmpty($team->name);
            $this->assertNotEmpty($team->nationality);
            $this->assertNotEmpty($team->getAvgSkill());
            $this->assertNotEmpty($team->getAvgAge());
        }
    }

    /**
     * @group Match
     */
    public function testGetRandomMatch()
    {
        for ($i = 1; $i <= 30; $i++) {
            $rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
            $spanish = $rndF->getTeam();
            $rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
            $italian = $rndF->getTeam();
            $this->assertNotEmpty($spanish);
            $this->assertNotEmpty($italian);
            $this->assertNotEmpty($italian->name);
            $this->assertNotEmpty($spanish);
            $this->assertNotEmpty($spanish->name);

            $this->assertNotEmpty($italian->getAvgSkill());
            $this->assertNotEmpty($spanish->getAvgSkill());
            $result = (new \App\Lib\DsManager\Models\Match($italian, $spanish))->simulate()->toArray();
            $this->assertNotEmpty($result);
            $this->assertGreaterThanOrEqual(0, $result['goal_home']);
            $this->assertGreaterThanOrEqual(0, $result['goal_away']);

        }
    }

    /**
     * @group Match
     * @group MatchResult
     * @group matchresultoutput
     */
    public function testMatchFromExistingTeams()
    {
        $teamHome = 1;
        $teamAway = 2;
        $homeOrm = \App\Lib\DsManager\Models\Orm\Team::with('roster', 'coach')->where(['id' => $teamHome])->first();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $awayOrm = \App\Lib\DsManager\Models\Orm\Team::with('roster', 'coach')->where(['id' => $teamAway])->first();
        $home = \App\Lib\DsManager\Models\Team::fromArray($homeOrm->toArray());
        $away = \App\Lib\DsManager\Models\Team::fromArray($awayOrm->toArray());

        $match = new \App\Lib\DsManager\Models\Match($home, $away);
        $result = $match->simulate()->toArray();
        $this->assertNotEmpty($result);
        $this->assertGreaterThanOrEqual(0, $result['goal_away']);
        $this->assertGreaterThanOrEqual(0, $result['goal_home']);
        if ($result['goal_home'] > 0) {
            $this->assertNotEmpty($result['info']['scorers']['home']);
            foreach ($result['info']['scorers']['home'] as $scorerHome) {
                $this->assertEquals($scorerHome->team_id, $teamHome);
            }
        } else {
            $this->assertEmpty($result['info']['scorers']['home']);
        }
        if ($result['goal_away'] > 0) {
            $this->assertNotEmpty($result['info']['scorers']['away']);
            foreach ($result['info']['scorers']['away'] as $scorerAway) {
                $this->assertEquals($scorerAway->team_id, $teamAway);
            }
        } else {
            $this->assertEmpty($result['info']['scorers']['away']);
        }
        if ($result['goal_home'] == $result['goal_away']) {
            $this->assertTrue($result['info']['is_draw']);
        } else {
            $this->assertFalse($result['info']['is_draw']);
        }
    }

    /**
     * @group Matches
     */
    public function testGetRandomMatchesOneTeam()
    {
        $rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
        $myTeam = $rndF->getTeam();
        $myTeam->id = 1000;
        $win = 0;
        $lost = 0;
        $draw = 0;

        for ($i = 1; $i <= 2; $i++) {

            $randomLocale = \App\Lib\Helpers\Config::get('generic.localesSmall');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            shuffle($randomLocale);
            $randomLocale = $randomLocale[0];
            $rndF = new \App\Lib\DsManager\Helpers\RandomFiller($randomLocale);
            $opponent = $rndF->getTeam();
            $opponent->id = 6000;
            $result = (new \App\Lib\DsManager\Models\Match($opponent, $myTeam))->simulate()->toArray();
            $this->assertNotEmpty($result);
            $result = $result['info'];
            if (!$result['is_draw']) {
                if ($result['winner_id'] == $myTeam->id) {
                    $win++;
                } else {
                    $lost++;
                }
            } else {
                $draw++;
            }
        }
        $this->assertGreaterThanOrEqual(0, $win);
        $this->assertGreaterThanOrEqual(0, $lost);
        $this->assertGreaterThanOrEqual(0, $draw);
    }

    /**
     * @group Module
     */
    public function testModule()
    {
        $rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
        $team = $rndF->getTeam();

        $modules = \App\Lib\Helpers\Config::get("modules.modules");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $modules = array_keys($modules);
        foreach ($modules as $mod) {
            $module = new \App\Lib\DsManager\Models\Module($mod);
            $this->assertNotEmpty($module);
            $this->assertNotNull($module->isDefensive());
            $this->assertNotNull($module->isBalanced());
            $this->assertNotNull($module->isOffensive());
            $this->assertTrue(is_array($module->getRoleNeeded()));
        }
        $this->assertGreaterThan(0, $team->playersPerRoleArray());
    }

}


Issues (80)

Security Analysis no request data

api/tests/ModelsTest.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1		<?php
2
3
4		/**
5		* Class ModelsTest
6		*/
7		class ModelsTest extends \PHPUnit_Framework_TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2016-08-25 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8		{
9
10
11		/**
12		* @group Player
13		*/
14		public function testGetRandomPlayer()
15		{
16		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller();
17		$player = $rndF->getPlayer(null, $rndF->getLocale());
18		$array = $player->toArray();
19		$this->assertNotEmpty($array);
20
21		$newPlayer = \App\Lib\DsManager\Models\Player::fromArray($array);
22		$this->assertNotEmpty($newPlayer->toArray());
23		}
24
25		/**
26		* @group Coach
27		*/
28		public function testGetRandomCoach()
29		{
30		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller();
31		$coach = $rndF->getCoach();
32		$this->assertNotEmpty($coach->toArray());
33		}
34
35		/**
36		* @group Coaches
37		*/
38	View Code Duplication	public function testGetRandomCoaches()
		0 ignored issues – show Duplication introduced 2016-08-25 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		foreach (\App\Lib\Helpers\Config::get('generic.localesSmall') as $nat) {
		0 ignored issues – show Bug introduced 2016-08-25 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `\App\Lib\Helpers\Config:...'generic.localesSmall')` of type `null` is not traversable. Loading history...
41		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller($nat);
42		$coach = $rndF->getCoach();
43		$this->assertNotEmpty($coach->toArray());
44		}
45		}
46
47		/**
48		* @group Players
49		*/
50	View Code Duplication	public function testGetRandomPlayers()
		0 ignored issues – show Duplication introduced 2016-08-25 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		foreach (\App\Lib\Helpers\Config::get('generic.localesSmall') as $nat) {
		0 ignored issues – show Bug introduced 2016-08-25 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `\App\Lib\Helpers\Config:...'generic.localesSmall')` of type `null` is not traversable. Loading history...
53		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller($nat);
54		$player = $rndF->getPlayer();
55		$this->assertNotEmpty($player->toArray());
56		}
57		}
58
59		/**
60		* @group Team
61		*/
62		public function testGetRandomTeam()
63		{
64		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
65		$team = $rndF->getTeam();
66		$this->assertNotEmpty($team);
67		$this->assertNotEmpty($team->name);
68		$this->assertNotEmpty($team->getAvgSkill());
69
70		//After Adding a player
71		$player = $rndF->getPlayer();
72		$this->assertNotEmpty($player->toArray());
73		$team->roster[] = $player;
74		$this->assertNotEmpty($team->getAvgSkill());
75		$this->assertNotEmpty($team->getAvgAge());
76
77		$this->assertNotEmpty($team->coach->toArray());
78
79		$teamArray = $team->toArray();
80		$this->assertNotEmpty($teamArray);
81
82		$newTeam = \App\Lib\DsManager\Models\Team::fromArray($teamArray);
83		$this->assertNotEmpty($newTeam->toArray());
84
85		}
86
87		/**
88		* @group Teams
89		*/
90		public function testGetRandomTeams()
91		{
92		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
93
94		for ($i = 1; $i <= 20; $i++) {
95		$team = $rndF->getTeam();
96		$this->assertGreaterThanOrEqual(
97		\App\Lib\Helpers\Config::get('generic.rosters')['min'],
98		count($team->roster)
99		);
100		$this->assertNotEmpty($team->name);
101		$this->assertNotEmpty($team->nationality);
102		$this->assertNotEmpty($team->getAvgSkill());
103		$this->assertNotEmpty($team->getAvgAge());
104		}
105		}
106
107		/**
108		* @group Match
109		*/
110		public function testGetRandomMatch()
111		{
112		for ($i = 1; $i <= 30; $i++) {
113		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
114		$spanish = $rndF->getTeam();
115		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
116		$italian = $rndF->getTeam();
117		$this->assertNotEmpty($spanish);
118		$this->assertNotEmpty($italian);
119		$this->assertNotEmpty($italian->name);
120		$this->assertNotEmpty($spanish);
121		$this->assertNotEmpty($spanish->name);
122
123		$this->assertNotEmpty($italian->getAvgSkill());
124		$this->assertNotEmpty($spanish->getAvgSkill());
125		$result = (new \App\Lib\DsManager\Models\Match($italian, $spanish))->simulate()->toArray();
126		$this->assertNotEmpty($result);
127		$this->assertGreaterThanOrEqual(0, $result['goal_home']);
128		$this->assertGreaterThanOrEqual(0, $result['goal_away']);
129
130		}
131		}
132
133		/**
134		* @group Match
135		* @group MatchResult
136		* @group matchresultoutput
137		*/
138		public function testMatchFromExistingTeams()
139		{
140		$teamHome = 1;
141		$teamAway = 2;
142		$homeOrm = \App\Lib\DsManager\Models\Orm\Team::with('roster', 'coach')->where(['id' => $teamHome])->first();
		0 ignored issues – show Bug introduced 2016-08-27 23:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `where` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
143		$awayOrm = \App\Lib\DsManager\Models\Orm\Team::with('roster', 'coach')->where(['id' => $teamAway])->first();
144		$home = \App\Lib\DsManager\Models\Team::fromArray($homeOrm->toArray());
145		$away = \App\Lib\DsManager\Models\Team::fromArray($awayOrm->toArray());
146
147		$match = new \App\Lib\DsManager\Models\Match($home, $away);
148		$result = $match->simulate()->toArray();
149		$this->assertNotEmpty($result);
150		$this->assertGreaterThanOrEqual(0, $result['goal_away']);
151		$this->assertGreaterThanOrEqual(0, $result['goal_home']);
152	View Code Duplication	if ($result['goal_home'] > 0) {
153		$this->assertNotEmpty($result['info']['scorers']['home']);
154		foreach ($result['info']['scorers']['home'] as $scorerHome) {
155		$this->assertEquals($scorerHome->team_id, $teamHome);
156		}
157		} else {
158		$this->assertEmpty($result['info']['scorers']['home']);
159		}
160	View Code Duplication	if ($result['goal_away'] > 0) {
161		$this->assertNotEmpty($result['info']['scorers']['away']);
162		foreach ($result['info']['scorers']['away'] as $scorerAway) {
163		$this->assertEquals($scorerAway->team_id, $teamAway);
164		}
165		} else {
166		$this->assertEmpty($result['info']['scorers']['away']);
167		}
168		if ($result['goal_home'] == $result['goal_away']) {
169		$this->assertTrue($result['info']['is_draw']);
170		} else {
171		$this->assertFalse($result['info']['is_draw']);
172		}
173		}
174
175		/**
176		* @group Matches
177		*/
178		public function testGetRandomMatchesOneTeam()
179		{
180		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
181		$myTeam = $rndF->getTeam();
182		$myTeam->id = 1000;
183		$win = 0;
184		$lost = 0;
185		$draw = 0;
186
187		for ($i = 1; $i <= 2; $i++) {
188
189		$randomLocale = \App\Lib\Helpers\Config::get('generic.localesSmall');
		0 ignored issues – show Bug introduced 2016-08-25 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$randomLocale` is correct as `\App\Lib\Helpers\Config:...'generic.localesSmall')` (which targets `App\Lib\Helpers\Config::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
190		shuffle($randomLocale);
191		$randomLocale = $randomLocale[0];
192		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller($randomLocale);
193		$opponent = $rndF->getTeam();
194		$opponent->id = 6000;
195		$result = (new \App\Lib\DsManager\Models\Match($opponent, $myTeam))->simulate()->toArray();
196		$this->assertNotEmpty($result);
197		$result = $result['info'];
198		if (!$result['is_draw']) {
199		if ($result['winner_id'] == $myTeam->id) {
200		$win++;
201		} else {
202		$lost++;
203		}
204		} else {
205		$draw++;
206		}
207		}
208		$this->assertGreaterThanOrEqual(0, $win);
209		$this->assertGreaterThanOrEqual(0, $lost);
210		$this->assertGreaterThanOrEqual(0, $draw);
211		}
212
213		/**
214		* @group Module
215		*/
216		public function testModule()
217		{
218		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller("it_IT");
219		$team = $rndF->getTeam();
220
221		$modules = \App\Lib\Helpers\Config::get("modules.modules");
		0 ignored issues – show Bug introduced 2016-08-25 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$modules` is correct as `\App\Lib\Helpers\Config::get('modules.modules')` (which targets `App\Lib\Helpers\Config::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
222		$modules = array_keys($modules);
223		foreach ($modules as $mod) {
224		$module = new \App\Lib\DsManager\Models\Module($mod);
225		$this->assertNotEmpty($module);
226		$this->assertNotNull($module->isDefensive());
227		$this->assertNotNull($module->isBalanced());
228		$this->assertNotNull($module->isOffensive());
229		$this->assertTrue(is_array($module->getRoleNeeded()));
230		}
231		$this->assertGreaterThan(0, $team->playersPerRoleArray());
232		}
233
234		}
235

vikkio88 / dsManager-php

Issues (80)

Security Analysis no request data

api/tests/ModelsTest.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like