Issues in RandomFiller.php (master) - Issues in master - vikkio88/dsManager-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (80)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

api/Lib/DsManager/Helpers/RandomFiller.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


namespace App\Lib\DsManager\Helpers;


use App\Lib\DsManager\Models\Coach;
use App\Lib\DsManager\Models\Player;
use App\Lib\DsManager\Models\Team;
use App\Lib\Helpers\Config;

/**
 * Class RandomFiller
 * @package App\Lib\DsManager\Helpers
 */
class RandomFiller
{
    /**
     * @var \Faker\Generator
     */
    protected $faker;

    /**
     * @var string
     */
    protected $locale;


    /**
     * RandomFiller constructor.
     * @param string $locale
     */
    public function __construct($locale = "it_IT")
    {
        $this->locale = $locale;
        $this->faker = \Faker\Factory::create($locale);
    }

    /**
     * @return string
     */
    public function getTeamName()
    {
        return $this->faker->city;
    }


    /**
     * @param null $forcedRole
     * @param null $locale
     * @return Player
     */
    public function getPlayer($forcedRole = null, $locale = null)
    {
        $this->setFaker($locale);
        $player = new Player;
        $player->name = $this->faker->firstNameMale;
        $player->surname = $this->faker->lastName;
        $player->role = $forcedRole == null ? $this->getRole() : $forcedRole;
        $player->nationality = $this->nationalityFromLocale($this->locale);
        $player->age = rand(16, 38);
        $player->skillAvg = rand(40, 100);

        return $player;
    }


    /**
     * @param null $locale
     * @return Coach
     */
    public function getCoach($locale = null)
    {
        $this->setFaker($locale);
        $coach = new Coach;
        $coach->name = $this->faker->firstNameMale;
        $coach->surname = $this->faker->lastName;
        $coach->favouriteModule = $this->getModule();
        $coach->nationality = $this->nationalityFromLocale($this->locale);
        $coach->age = rand(33, 68);
        $coach->skillAvg = rand(40, 100);

        return $coach;
    }

    /**
     * @return mixed
     */
    public function getRole()
    {
        $roles = array_keys(Config::get('modules.roles'));
        shuffle($roles);
        return $roles[0];
    }

    /**
     * @return mixed
     */
    public function getModule()
    {
        $modules = array_keys(Config::get('modules.modules'));
        shuffle($modules);
        return $modules[0];
    }


    /**
     * @param null $locale
     * @return Team
     */
    public function getTeam($locale = null)
    {
        $rosterConf = Config::get('generic.rosters');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $numberOfPlayers = rand($rosterConf['min'], $rosterConf['max']);
        $this->setFaker($locale);
        $team = new Team;
        $team->name = $this->getTeamName();
        $team->nationality = $this->nationalityFromLocale($this->locale);
        $players = [];
        for ($i = 0; $i < $numberOfPlayers; $i++) {
            $players[] = $this->getPlayer();
        }
        //Adding some forced role
        $players[] = $this->getPlayer("GK", $this->getLocale());
        $players[] = $this->getPlayer("CD", $this->getLocale());
        $players[] = $this->getPlayer("CD", $this->getLocale());
        $players[] = $this->getPlayer("CM", $this->getLocale());
        $players[] = $this->getPlayer("CM", $this->getLocale());
        $players[] = $this->getPlayer("CS", $this->getLocale());
        //

        $team->roster = $players;
        //setting random Nationality Coach (20%)
        $coachNationality = Randomizer::boolOnPercentage(20) ? $this->getLocale() : null;
        $team->coach = $this->getCoach($coachNationality);

        return $team;
    }


    /**
     * @return mixed
     */
    public function getLocale()
    {
        $locales = (Config::get('generic.localesSmall'));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        shuffle($locales);
        return $locales[0];
    }

    /**
     * @param $locale
     * @return mixed
     */
    private function nationalityFromLocale($locale)
    {
        return preg_replace("/.._/", '', $locale);
    }

    /**
     * @param $locale
     */
    private function setFaker($locale)
    {
        if ($locale !== null) {
            $this->faker = \Faker\Factory::create($locale);
            $this->locale = $locale;
        }
    }

}

1			<?php
2
3
4			namespace App\Lib\DsManager\Helpers;
5
6
7			use App\Lib\DsManager\Models\Coach;
8			use App\Lib\DsManager\Models\Player;
9			use App\Lib\DsManager\Models\Team;
10			use App\Lib\Helpers\Config;
11
12			/**
13			* Class RandomFiller
14			* @package App\Lib\DsManager\Helpers
15			*/
16			class RandomFiller
17			{
18			/**
19			* @var \Faker\Generator
20			*/
21			protected $faker;
22
23			/**
24			* @var string
25			*/
26			protected $locale;
27
28
29			/**
30			* RandomFiller constructor.
31			* @param string $locale
32			*/
33			public function __construct($locale = "it_IT")
34			{
35			$this->locale = $locale;
36			$this->faker = \Faker\Factory::create($locale);
37			}
38
39			/**
40			* @return string
41			*/
42			public function getTeamName()
43			{
44			return $this->faker->city;
45			}
46
47
48			/**
49			* @param null $forcedRole
50			* @param null $locale
51			* @return Player
52			*/
53			public function getPlayer($forcedRole = null, $locale = null)
54			{
55			$this->setFaker($locale);
56			$player = new Player;
57			$player->name = $this->faker->firstNameMale;
58			$player->surname = $this->faker->lastName;
59			$player->role = $forcedRole == null ? $this->getRole() : $forcedRole;
60			$player->nationality = $this->nationalityFromLocale($this->locale);
61			$player->age = rand(16, 38);
62			$player->skillAvg = rand(40, 100);
63
64			return $player;
65			}
66
67
68			/**
69			* @param null $locale
70			* @return Coach
71			*/
72			public function getCoach($locale = null)
73			{
74			$this->setFaker($locale);
75			$coach = new Coach;
76			$coach->name = $this->faker->firstNameMale;
77			$coach->surname = $this->faker->lastName;
78			$coach->favouriteModule = $this->getModule();
79			$coach->nationality = $this->nationalityFromLocale($this->locale);
80			$coach->age = rand(33, 68);
81			$coach->skillAvg = rand(40, 100);
82
83			return $coach;
84			}
85
86			/**
87			* @return mixed
88			*/
89			public function getRole()
90			{
91			$roles = array_keys(Config::get('modules.roles'));
92			shuffle($roles);
93			return $roles[0];
94			}
95
96			/**
97			* @return mixed
98			*/
99			public function getModule()
100			{
101			$modules = array_keys(Config::get('modules.modules'));
102			shuffle($modules);
103			return $modules[0];
104			}
105
106
107			/**
108			* @param null $locale
109			* @return Team
110			*/
111			public function getTeam($locale = null)
112			{
113			$rosterConf = Config::get('generic.rosters');
			0 ignored issues – show Bug introduced 2016-08-31 20:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$rosterConf` is correct as `\App\Lib\Helpers\Config::get('generic.rosters')` (which targets `App\Lib\Helpers\Config::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
114			$numberOfPlayers = rand($rosterConf['min'], $rosterConf['max']);
115			$this->setFaker($locale);
116			$team = new Team;
117			$team->name = $this->getTeamName();
118			$team->nationality = $this->nationalityFromLocale($this->locale);
119			$players = [];
120			for ($i = 0; $i < $numberOfPlayers; $i++) {
121			$players[] = $this->getPlayer();
122			}
123			//Adding some forced role
124			$players[] = $this->getPlayer("GK", $this->getLocale());
125			$players[] = $this->getPlayer("CD", $this->getLocale());
126			$players[] = $this->getPlayer("CD", $this->getLocale());
127			$players[] = $this->getPlayer("CM", $this->getLocale());
128			$players[] = $this->getPlayer("CM", $this->getLocale());
129			$players[] = $this->getPlayer("CS", $this->getLocale());
130			//
131
132			$team->roster = $players;
133			//setting random Nationality Coach (20%)
134			$coachNationality = Randomizer::boolOnPercentage(20) ? $this->getLocale() : null;
135			$team->coach = $this->getCoach($coachNationality);
136
137			return $team;
138			}
139
140
141			/**
142			* @return mixed
143			*/
144			public function getLocale()
145			{
146			$locales = (Config::get('generic.localesSmall'));
			0 ignored issues – show Bug introduced 2016-08-25 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$locales` is correct as `\App\Lib\Helpers\Config:...'generic.localesSmall')` (which targets `App\Lib\Helpers\Config::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
147			shuffle($locales);
148			return $locales[0];
149			}
150
151			/**
152			* @param $locale
153			* @return mixed
154			*/
155			private function nationalityFromLocale($locale)
156			{
157			return preg_replace("/.._/", '', $locale);
158			}
159
160			/**
161			* @param $locale
162			*/
163			private function setFaker($locale)
164			{
165			if ($locale !== null) {
166			$this->faker = \Faker\Factory::create($locale);
167			$this->locale = $locale;
168			}
169			}
170
171			}

vikkio88 / dsManager-php

Issues (80)

Security Analysis no request data

api/Lib/DsManager/Helpers/RandomFiller.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like