Inspection of "implemented Scorer fetch on MatchResult" - vikkio88/dsManager-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 01ad84...898da4 )

by Vincenzo

created 2016-08-27 23:14 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -6,9 +6,9 @@
 block discarded – undo
 
 abstract class DsManagerOrm extends Eloquent{
 
-    protected $hidden = [
-        'created_at',
-        'updated_at'
-    ];
+	protected $hidden = [
+		'created_at',
+		'updated_at'
+	];
 
 } 
\ No newline at end of file

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@
 block discarded – undo
 use Illuminate\Database\Eloquent\Model as Eloquent;
 
 
-abstract class DsManagerOrm extends Eloquent{
+abstract class DsManagerOrm extends Eloquent {
 
     protected $hidden = [
         'created_at',

Please login to merge, or discard this patch.

api/Lib/DsManager/Models/Coach.php 1 patch

Braces +24 added lines, -8 removed lines patch added patch discarded remove patch

@@ -35,7 +35,9 @@  discard block
 block discarded – undo
 		if ($this->wageReq == null) {
 			$wage = $this->wageOnSkill();
 			$wage += $this->spareChange();
-			if ($wage < 0) $wage = $wage * (-1);
+			if ($wage < 0) {
+				$wage = $wage * (-1);
+			}
 			$this->wageReq = round($wage, 2);
 		}
 		return $this->wageReq;
@@ -46,13 +48,27 @@  discard block
 block discarded – undo
 	 */
 	private function wageOnSkill()
 	{
-		if ($this->skillAvg > 98) return 5.0;
-		if ($this->skillAvg > 90) return 3.5;
-		if ($this->skillAvg > 80) return 2.0;
-		if ($this->skillAvg > 76) return 1.5;
-		if ($this->skillAvg > 70) return 1.0;
-		if ($this->skillAvg > 60) return .76;
-		if ($this->skillAvg > 50) return .20;
+		if ($this->skillAvg > 98) {
+			return 5.0;
+		}
+		if ($this->skillAvg > 90) {
+			return 3.5;
+		}
+		if ($this->skillAvg > 80) {
+			return 2.0;
+		}
+		if ($this->skillAvg > 76) {
+			return 1.5;
+		}
+		if ($this->skillAvg > 70) {
+			return 1.0;
+		}
+		if ($this->skillAvg > 60) {
+			return .76;
+		}
+		if ($this->skillAvg > 50) {
+			return .20;
+		}
 		return 0.5;
 
 	}

Please login to merge, or discard this patch.

api/Lib/DsManager/Models/Common/DsManagerModel.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -12,15 +12,15 @@
 block discarded – undo
  */
 abstract class DsManagerModel implements ActiveModel
 {
-    /**
-     * @var
-     */
-    public $id;
+	/**
+	 * @var
+	 */
+	public $id;
 
-    /**
-     * @return mixed
-     */
-    abstract function toArray();
+	/**
+	 * @return mixed
+	 */
+	abstract function toArray();
 	/**
 	 * @param array $array
 	 * @return mixed

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@
 block discarded – undo
 	 * @param array $array
 	 * @return mixed
 	 */
-	public static function fromArray($array =[])
+	public static function fromArray($array = [])
 	{
 		$class = get_called_class();
 		$class = new $class();

Please login to merge, or discard this patch.

api/Lib/DsManager/Models/Module.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@
 block discarded – undo
 	 */
 	function __toString()
 	{
-		return "" . $this->moduleCode;
+		return "".$this->moduleCode;
 	}
 
 

Please login to merge, or discard this patch.

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,9 @@  discard block
 block discarded – undo
 	{
 		$this->moduleCode = $module;
 		$this->configuration = Config::get("modules.modules", "api/")[$module];
-		if ($this->configuration == null) throw new \InvalidArgumentException("Not a valid Module supplied");
+		if ($this->configuration == null) {
+			throw new \InvalidArgumentException("Not a valid Module supplied");
+		}
 	}
 
 	/**
@@ -98,8 +100,9 @@  discard block
 block discarded – undo
 		$roles = \App\Lib\Helpers\Config::get('modules.roles', "api/");
 		$rolesKeys = array_keys($roles);
 		foreach ($this->configuration["roles"] as $index => $playNum) {
-			if ($playNum != 0 || $complete)
-				$rolesNeeded[$rolesKeys[$index]] = $playNum;
+			if ($playNum != 0 || $complete) {
+							$rolesNeeded[$rolesKeys[$index]] = $playNum;
+			}
 		}
 
 		return $rolesNeeded;

Please login to merge, or discard this patch.

api/Lib/Helpers/Responder.php 1 patch

Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

@@ -9,44 +9,44 @@
 block discarded – undo
  */
 class Responder
 {
-    /**
-     * @param $content
-     * @param $response
-     * @param array $headers
-     * @return mixed
-     */
-    public static function getJsonResponse($content, $response, $headers = [])
-    {
-        $headers['Content-Type'] = 'application/json';
-        return self::getResponse($headers, $content, $response);
-    }
+	/**
+	 * @param $content
+	 * @param $response
+	 * @param array $headers
+	 * @return mixed
+	 */
+	public static function getJsonResponse($content, $response, $headers = [])
+	{
+		$headers['Content-Type'] = 'application/json';
+		return self::getResponse($headers, $content, $response);
+	}
 
-    /**
-     * @param array $headers
-     * @param $content
-     * @param $response
-     * @return mixed
-     */
-    public static function getResponse($headers = [], $content, $response)
-    {
-        $body = $response->getBody();
-        $body->write($content);
-        $i = 0;
-        foreach ($headers as $header => $value) {
-            if ($i === 0) {
-                $response = $response->withHeader(
-                    $header,
-                    $value
-                );
-            } else {
-                $response = $response->withAddedHeader(
-                    $header,
-                    $value
-                );
-            }
-            $i++;
-        }
-        return $response->withBody($body);
-    }
+	/**
+	 * @param array $headers
+	 * @param $content
+	 * @param $response
+	 * @return mixed
+	 */
+	public static function getResponse($headers = [], $content, $response)
+	{
+		$body = $response->getBody();
+		$body->write($content);
+		$i = 0;
+		foreach ($headers as $header => $value) {
+			if ($i === 0) {
+				$response = $response->withHeader(
+					$header,
+					$value
+				);
+			} else {
+				$response = $response->withAddedHeader(
+					$header,
+					$value
+				);
+			}
+			$i++;
+		}
+		return $response->withBody($body);
+	}
 
 }
\ No newline at end of file

Please login to merge, or discard this patch.

api/index.php 2 patches

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 $c = new \Slim\Container($configuration);
 $api = new \Slim\App($c);
 
-$api->get('/ping', function ($request, $response, $args) {
+$api->get('/ping', function($request, $response, $args) {
     $jsonResp = json_encode(
         [
             "status" => "service up",
@@ -28,34 +28,34 @@  discard block
 block discarded – undo
     return \App\Lib\Helpers\Responder::getJsonResponse($jsonResp, $response);
 });
 
-$api->get('/players', function ($request, $response, $args) {
+$api->get('/players', function($request, $response, $args) {
     $json = json_encode(Player::all());
     return \App\Lib\Helpers\Responder::getJsonResponse($json, $response);
 });
 
 
-$api->get('/players/{id}', function ($request, $response, $args) {
+$api->get('/players/{id}', function($request, $response, $args) {
     return \App\Lib\Helpers\Responder::getJsonResponse(
         Player::findOrFail($args['id']),
         $response
     );
 });
 
-$api->get('/coaches', function ($request, $response, $args) {
+$api->get('/coaches', function($request, $response, $args) {
     return \App\Lib\Helpers\Responder::getJsonResponse(
         Coach::all(),
         $response
     );
 });
 
-$api->get('/teams', function ($request, $response, $args) {
+$api->get('/teams', function($request, $response, $args) {
     return \App\Lib\Helpers\Responder::getJsonResponse(
         Team::all(),
         $response
     );
 });
 
-$api->get('/teams/{id}', function ($request, $response, $args) {
+$api->get('/teams/{id}', function($request, $response, $args) {
     return \App\Lib\Helpers\Responder::getJsonResponse(
         Team::with(
             'roster',
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
     );
 });
 
-$api->get('/teams/{id}/players', function ($request, $response, $args) {
+$api->get('/teams/{id}/players', function($request, $response, $args) {
     return \App\Lib\Helpers\Responder::getJsonResponse(
         Team::with(
             'roster'
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
     );
 });
 
-$api->get('/teams/{id}/players/{playerId}', function ($request, $response, $args) {
+$api->get('/teams/{id}/players/{playerId}', function($request, $response, $args) {
     return \App\Lib\Helpers\Responder::getJsonResponse(
         Player::where(
             [
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
     );
 });
 
-$api->get('/teams/{id}/coach', function ($request, $response, $args) {
+$api->get('/teams/{id}/coach', function($request, $response, $args) {
     return \App\Lib\Helpers\Responder::getJsonResponse(
         Team::with(
             'coach'

Please login to merge, or discard this patch.

Indentation +65 added lines, -65 removed lines patch added patch discarded remove patch

@@ -10,101 +10,101 @@
 block discarded – undo
 use \App\Lib\DsManager\Models\Orm\Coach;
 
 $configuration = [
-    'settings' => [
-        'displayErrorDetails' => true,
-    ],
+	'settings' => [
+		'displayErrorDetails' => true,
+	],
 ];
 $c = new \Slim\Container($configuration);
 $api = new \Slim\App($c);
 
 $api->get('/ping', function ($request, $response, $args) {
-    $jsonResp = json_encode(
-        [
-            "status" => "service up",
-            "message" => "in a bottle",
-            "config" => \App\Lib\Helpers\Config::get("config1.stuff")
-        ]
-    );
-    return Responder::getJsonResponse($jsonResp, $response);
+	$jsonResp = json_encode(
+		[
+			"status" => "service up",
+			"message" => "in a bottle",
+			"config" => \App\Lib\Helpers\Config::get("config1.stuff")
+		]
+	);
+	return Responder::getJsonResponse($jsonResp, $response);
 });
 
 $api->get('/players', function ($request, $response, $args) {
-    $json = json_encode(Player::all());
-    return Responder::getJsonResponse($json, $response);
+	$json = json_encode(Player::all());
+	return Responder::getJsonResponse($json, $response);
 });
 
 
 $api->get('/players/{id}', function ($request, $response, $args) {
-    return Responder::getJsonResponse(
-        Player::findOrFail($args['id']),
-        $response
-    );
+	return Responder::getJsonResponse(
+		Player::findOrFail($args['id']),
+		$response
+	);
 });
 
 $api->get('/coaches', function ($request, $response, $args) {
-    return Responder::getJsonResponse(
-        Coach::all(),
-        $response
-    );
+	return Responder::getJsonResponse(
+		Coach::all(),
+		$response
+	);
 });
 
 $api->get('/teams', function ($request, $response, $args) {
-    return Responder::getJsonResponse(
-        Team::all(),
-        $response
-    );
+	return Responder::getJsonResponse(
+		Team::all(),
+		$response
+	);
 });
 
 $api->get('/teams/{id}', function ($request, $response, $args) {
-    return Responder::getJsonResponse(
-        Team::with(
-            'roster',
-            'coach'
-        )->where(
-            [
-                'id' => $args['id']
-            ]
-        )->get(),
-        $response
-    );
+	return Responder::getJsonResponse(
+		Team::with(
+			'roster',
+			'coach'
+		)->where(
+			[
+				'id' => $args['id']
+			]
+		)->get(),
+		$response
+	);
 });
 
 $api->get('/teams/{id}/players', function ($request, $response, $args) {
-    return Responder::getJsonResponse(
-        Team::with(
-            'roster'
-        )->where(
-            [
-                'id' => $args['id']
-            ]
-        )->get(),
-        $response
-    );
+	return Responder::getJsonResponse(
+		Team::with(
+			'roster'
+		)->where(
+			[
+				'id' => $args['id']
+			]
+		)->get(),
+		$response
+	);
 });
 
 $api->get('/teams/{id}/players/{playerId}', function ($request, $response, $args) {
-    return Responder::getJsonResponse(
-        Player::where(
-            [
-                'id' => $args['playerId'],
-                'team_id' => $args['id']
-            ]
-        )->get(),
-        $response
-    );
+	return Responder::getJsonResponse(
+		Player::where(
+			[
+				'id' => $args['playerId'],
+				'team_id' => $args['id']
+			]
+		)->get(),
+		$response
+	);
 });
 
 $api->get('/teams/{id}/coach', function ($request, $response, $args) {
-    return Responder::getJsonResponse(
-        Team::with(
-            'coach'
-        )->where(
-            [
-                'id' => $args['id']
-            ]
-        )->get(),
-        $response
-    );
+	return Responder::getJsonResponse(
+		Team::with(
+			'coach'
+		)->where(
+			[
+				'id' => $args['id']
+			]
+		)->get(),
+		$response
+	);
 });
 
 $api->run();
\ No newline at end of file

Please login to merge, or discard this patch.

api/tests/OrmModelsTest.php 1 patch

Indentation +61 added lines, -61 removed lines patch added patch discarded remove patch

@@ -8,70 +8,70 @@
 block discarded – undo
 {
 
 
-    /**
-     * @group OrmModels
-     * @group PlayerOrm
-     */
-    public function testPlayerOrmGetSet()
-    {
-        $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
-        $playerM = $rndFiller->getPlayer();
-        $arrayPl = $playerM->toArray();
-        $playerO = \App\Lib\DsManager\Models\Orm\Player::create($arrayPl);
-        $this->assertNotEmpty($playerO);
+	/**
+	 * @group OrmModels
+	 * @group PlayerOrm
+	 */
+	public function testPlayerOrmGetSet()
+	{
+		$rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
+		$playerM = $rndFiller->getPlayer();
+		$arrayPl = $playerM->toArray();
+		$playerO = \App\Lib\DsManager\Models\Orm\Player::create($arrayPl);
+		$this->assertNotEmpty($playerO);
 
-        $newPlayer = \App\Lib\DsManager\Models\Player::fromArray($playerO->toArray());
-        $this->assertNotEmpty($newPlayer);
-    }
+		$newPlayer = \App\Lib\DsManager\Models\Player::fromArray($playerO->toArray());
+		$this->assertNotEmpty($newPlayer);
+	}
 
-    /**
-     * @group OrmModels
-     * @group CoachOrm
-     */
-    public function testCoachOrmGetSet()
-    {
-        $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
-        $coach = $rndFiller->getCoach();
-        $arrayPl = $coach->toArray();
-        $coachO = \App\Lib\DsManager\Models\Orm\Coach::create($arrayPl);
-        $this->assertNotEmpty($coachO);
+	/**
+	 * @group OrmModels
+	 * @group CoachOrm
+	 */
+	public function testCoachOrmGetSet()
+	{
+		$rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
+		$coach = $rndFiller->getCoach();
+		$arrayPl = $coach->toArray();
+		$coachO = \App\Lib\DsManager\Models\Orm\Coach::create($arrayPl);
+		$this->assertNotEmpty($coachO);
 
-        $newCoach = \App\Lib\DsManager\Models\Coach::fromArray($coachO->toArray());
-        $this->assertNotEmpty($newCoach);
-    }
+		$newCoach = \App\Lib\DsManager\Models\Coach::fromArray($coachO->toArray());
+		$this->assertNotEmpty($newCoach);
+	}
 
-    /**
-     * @group OrmModels
-     * @group TeamOrm
-     */
-    public function testTeamOrm()
-    {
-        $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
-        $team = $rndFiller->getTeam($rndFiller->getLocale());
-        $teamArray = $team->toArray();
-        $this->assertNotEmpty($team);
-        $teamO = \App\Lib\DsManager\Models\Orm\Team::create($teamArray);
-        $this->assertNotEmpty($teamArray);
-        $this->assertNotEmpty($teamArray['roster']);
-        foreach ($teamArray['roster'] as $player) {
-            $player['team_id'] = $teamO->id;
-            $playerO = \App\Lib\DsManager\Models\Orm\Player::create($player);
-            $this->assertNotEmpty($playerO);
-        }
-        $teamArray['coach']['team_id'] = $teamO->id;
-        $coachO = \App\Lib\DsManager\Models\Orm\Coach::create($teamArray['coach']);
-        $this->assertNotEmpty($coachO);
+	/**
+	 * @group OrmModels
+	 * @group TeamOrm
+	 */
+	public function testTeamOrm()
+	{
+		$rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
+		$team = $rndFiller->getTeam($rndFiller->getLocale());
+		$teamArray = $team->toArray();
+		$this->assertNotEmpty($team);
+		$teamO = \App\Lib\DsManager\Models\Orm\Team::create($teamArray);
+		$this->assertNotEmpty($teamArray);
+		$this->assertNotEmpty($teamArray['roster']);
+		foreach ($teamArray['roster'] as $player) {
+			$player['team_id'] = $teamO->id;
+			$playerO = \App\Lib\DsManager\Models\Orm\Player::create($player);
+			$this->assertNotEmpty($playerO);
+		}
+		$teamArray['coach']['team_id'] = $teamO->id;
+		$coachO = \App\Lib\DsManager\Models\Orm\Coach::create($teamArray['coach']);
+		$this->assertNotEmpty($coachO);
 
-        $this->assertNotEmpty(
-            \App\Lib\DsManager\Models\Orm\Team::with(
-                'roster'
-            )->with(
-                'coach'
-            )->where(
-                [
-                    'id' => $teamO->id
-                ]
-            )->get()->toArray()
-        );
-    }
+		$this->assertNotEmpty(
+			\App\Lib\DsManager\Models\Orm\Team::with(
+				'roster'
+			)->with(
+				'coach'
+			)->where(
+				[
+					'id' => $teamO->id
+				]
+			)->get()->toArray()
+		);
+	}
 }

Please login to merge, or discard this patch.

api/tests/ModuleConfigurationTest.php 1 patch

Indentation +67 added lines, -67 removed lines patch added patch discarded remove patch

@@ -8,76 +8,76 @@
 block discarded – undo
 {
 
 
-    /**
-     * @group Modules
-     * @group config
-     */
-    public function testAllTheModulesGot11Players()
-    {
-        $modules = \App\Lib\Helpers\Config::get('modules.modules');
-        $this->assertNotEmpty($modules);
-        foreach ($modules as $key => $module) {
-            $this->assertNotEmpty($module["roles"]);
-            $count = 0;
-            foreach ($module["roles"] as $roleNum) {
-                $count += $roleNum;
-            }
-            $this->assertTrue(11 === $count, "Not correct Players for $key");
-        }
-    }
+	/**
+	 * @group Modules
+	 * @group config
+	 */
+	public function testAllTheModulesGot11Players()
+	{
+		$modules = \App\Lib\Helpers\Config::get('modules.modules');
+		$this->assertNotEmpty($modules);
+		foreach ($modules as $key => $module) {
+			$this->assertNotEmpty($module["roles"]);
+			$count = 0;
+			foreach ($module["roles"] as $roleNum) {
+				$count += $roleNum;
+			}
+			$this->assertTrue(11 === $count, "Not correct Players for $key");
+		}
+	}
 
-    /**
-     * @group Roles
-     * @group config
-     */
-    public function testCorrectDisplayModuleDescriptionRole()
-    {
-        $modules = \App\Lib\Helpers\Config::get('modules.modules');
-        $this->assertNotEmpty($modules);
-        $roles = \App\Lib\Helpers\Config::get('modules.roles');
-        $rolesKeys = array_keys($roles);
+	/**
+	 * @group Roles
+	 * @group config
+	 */
+	public function testCorrectDisplayModuleDescriptionRole()
+	{
+		$modules = \App\Lib\Helpers\Config::get('modules.modules');
+		$this->assertNotEmpty($modules);
+		$roles = \App\Lib\Helpers\Config::get('modules.roles');
+		$rolesKeys = array_keys($roles);
 
-        foreach ($modules as $key => $module) {
-            $this->assertNotEmpty($module["roles"]);
-            foreach ($module["roles"] as $index => $playNum) {
-                if ($playNum != 0) {
-                    $this->assertGreaterThan(0, $playNum);
-                    $this->assertNotNull($roles[$rolesKeys[$index]]["description"]);
-                }
-            }
-        }
-    }
+		foreach ($modules as $key => $module) {
+			$this->assertNotEmpty($module["roles"]);
+			foreach ($module["roles"] as $index => $playNum) {
+				if ($playNum != 0) {
+					$this->assertGreaterThan(0, $playNum);
+					$this->assertNotNull($roles[$rolesKeys[$index]]["description"]);
+				}
+			}
+		}
+	}
 
-    /**
-     * @group rand
-     *
-     */
-    public function testRandomizer()
-    {
-        $yes = 0;
-        $no = 0;
-        for ($i = 1; $i <= 100; $i++) {
-            if (\App\Lib\DsManager\Helpers\Randomizer::boolOnPercentage(20)) {
-                $yes++;
-            } else {
-                $no++;
-            }
-        }
-        $this->assertNotEmpty($yes);
-        $this->assertNotEmpty($no);
-        $this->assertGreaterThan($yes, $no);
-    }
+	/**
+	 * @group rand
+	 *
+	 */
+	public function testRandomizer()
+	{
+		$yes = 0;
+		$no = 0;
+		for ($i = 1; $i <= 100; $i++) {
+			if (\App\Lib\DsManager\Helpers\Randomizer::boolOnPercentage(20)) {
+				$yes++;
+			} else {
+				$no++;
+			}
+		}
+		$this->assertNotEmpty($yes);
+		$this->assertNotEmpty($no);
+		$this->assertGreaterThan($yes, $no);
+	}
 
-    /**
-     * @group randFiller
-     *
-     */
-    public function testRandomFiller()
-    {
-        $rndF = new \App\Lib\DsManager\Helpers\RandomFiller();
-        for ($i = 1; $i <= 10; $i++) {
-            $this->assertNotEmpty($rndF->getLocale());
-        }
-    }
+	/**
+	 * @group randFiller
+	 *
+	 */
+	public function testRandomFiller()
+	{
+		$rndF = new \App\Lib\DsManager\Helpers\RandomFiller();
+		for ($i = 1; $i <= 10; $i++) {
+			$this->assertNotEmpty($rndF->getLocale());
+		}
+	}
 
 }

Please login to merge, or discard this patch.

api/database/seeds/ATeamsSeeder.php 1 patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -3,20 +3,20 @@
 block discarded – undo
 
 class ATeamsSeeder
 {
-    function run()
-    {
-        $teamNumber = 10;
-        $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
-        for ($i = 1; $i <= $teamNumber; $i++) {
-            $team = $rndFiller->getTeam($rndFiller->getLocale());
-            $teamArray = $team->toArray();
-            $teamO = \App\Lib\DsManager\Models\Orm\Team::create($teamArray);
-            foreach ($teamArray['roster'] as $player) {
-                $player['team_id'] = $teamO->id;
-                \App\Lib\DsManager\Models\Orm\Player::create($player);
-            }
-            $teamArray['coach']['team_id'] = $teamO->id;
-            \App\Lib\DsManager\Models\Orm\Coach::create($teamArray['coach']);
-        }
-    }
+	function run()
+	{
+		$teamNumber = 10;
+		$rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
+		for ($i = 1; $i <= $teamNumber; $i++) {
+			$team = $rndFiller->getTeam($rndFiller->getLocale());
+			$teamArray = $team->toArray();
+			$teamO = \App\Lib\DsManager\Models\Orm\Team::create($teamArray);
+			foreach ($teamArray['roster'] as $player) {
+				$player['team_id'] = $teamO->id;
+				\App\Lib\DsManager\Models\Orm\Player::create($player);
+			}
+			$teamArray['coach']['team_id'] = $teamO->id;
+			\App\Lib\DsManager\Models\Orm\Coach::create($teamArray['coach']);
+		}
+	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -6,9 +6,9 @@
		block discarded – undo
6	6
7	7	abstract class DsManagerOrm extends Eloquent{
8	8
9		- protected $hidden = [
10		- 'created_at',
11		- 'updated_at'
12		- ];
	9	+ protected $hidden = [
	10	+ 'created_at',
	11	+ 'updated_at'
	12	+ ];
13	13
14	14	}
15	15	\ No newline at end of file

		@@ -4,7 +4,7 @@
		block discarded – undo
4	4	use Illuminate\Database\Eloquent\Model as Eloquent;
5	5
6	6
7		-abstract class DsManagerOrm extends Eloquent{
	7	+abstract class DsManagerOrm extends Eloquent {
8	8
9	9	protected $hidden = [
10	10	'created_at',

		@@ -35,7 +35,9 @@ discard block
		block discarded – undo
35	35	if ($this->wageReq == null) {
36	36	$wage = $this->wageOnSkill();
37	37	$wage += $this->spareChange();
38		- if ($wage < 0) $wage = $wage * (-1);
	38	+ if ($wage < 0) {
	39	+ $wage = $wage * (-1);
	40	+ }
39	41	$this->wageReq = round($wage, 2);
40	42	}
41	43	return $this->wageReq;
		@@ -46,13 +48,27 @@ discard block
		block discarded – undo
46	48	*/
47	49	private function wageOnSkill()
48	50	{
49		- if ($this->skillAvg > 98) return 5.0;
50		- if ($this->skillAvg > 90) return 3.5;
51		- if ($this->skillAvg > 80) return 2.0;
52		- if ($this->skillAvg > 76) return 1.5;
53		- if ($this->skillAvg > 70) return 1.0;
54		- if ($this->skillAvg > 60) return .76;
55		- if ($this->skillAvg > 50) return .20;
	51	+ if ($this->skillAvg > 98) {
	52	+ return 5.0;
	53	+ }
	54	+ if ($this->skillAvg > 90) {
	55	+ return 3.5;
	56	+ }
	57	+ if ($this->skillAvg > 80) {
	58	+ return 2.0;
	59	+ }
	60	+ if ($this->skillAvg > 76) {
	61	+ return 1.5;
	62	+ }
	63	+ if ($this->skillAvg > 70) {
	64	+ return 1.0;
	65	+ }
	66	+ if ($this->skillAvg > 60) {
	67	+ return .76;
	68	+ }
	69	+ if ($this->skillAvg > 50) {
	70	+ return .20;
	71	+ }
56	72	return 0.5;
57	73
58	74	}

		@@ -12,15 +12,15 @@
		block discarded – undo
12	12	*/
13	13	abstract class DsManagerModel implements ActiveModel
14	14	{
15		- /**
16		- * @var
17		- */
18		- public $id;
	15	+ /**
	16	+ * @var
	17	+ */
	18	+ public $id;
19	19
20		- /**
21		- * @return mixed
22		- */
23		- abstract function toArray();
	20	+ /**
	21	+ * @return mixed
	22	+ */
	23	+ abstract function toArray();
24	24	/**
25	25	* @param array $array
26	26	* @return mixed

		@@ -25,7 +25,7 @@
		block discarded – undo
25	25	* @param array $array
26	26	* @return mixed
27	27	*/
28		- public static function fromArray($array =[])
	28	+ public static function fromArray($array = [])
29	29	{
30	30	$class = get_called_class();
31	31	$class = new $class();

		@@ -63,7 +63,7 @@
		block discarded – undo
63	63	*/
64	64	function __toString()
65	65	{
66		- return "" . $this->moduleCode;
	66	+ return "".$this->moduleCode;
67	67	}
68	68
69	69

		@@ -31,7 +31,9 @@ discard block
		block discarded – undo
31	31	{
32	32	$this->moduleCode = $module;
33	33	$this->configuration = Config::get("modules.modules", "api/")[$module];
34		- if ($this->configuration == null) throw new \InvalidArgumentException("Not a valid Module supplied");
	34	+ if ($this->configuration == null) {
	35	+ throw new \InvalidArgumentException("Not a valid Module supplied");
	36	+ }
35	37	}
36	38
37	39	/**
		@@ -98,8 +100,9 @@ discard block
		block discarded – undo
98	100	$roles = \App\Lib\Helpers\Config::get('modules.roles', "api/");
99	101	$rolesKeys = array_keys($roles);
100	102	foreach ($this->configuration["roles"] as $index => $playNum) {
101		- if ($playNum != 0 \|\| $complete)
102		- $rolesNeeded[$rolesKeys[$index]] = $playNum;
	103	+ if ($playNum != 0 \|\| $complete) {
	104	+ $rolesNeeded[$rolesKeys[$index]] = $playNum;
	105	+ }
103	106	}
104	107
105	108	return $rolesNeeded;

		@@ -9,44 +9,44 @@
		block discarded – undo
9	9	*/
10	10	class Responder
11	11	{
12		- /**
13		- * @param $content
14		- * @param $response
15		- * @param array $headers
16		- * @return mixed
17		- */
18		- public static function getJsonResponse($content, $response, $headers = [])
19		- {
20		- $headers['Content-Type'] = 'application/json';
21		- return self::getResponse($headers, $content, $response);
22		- }
	12	+ /**
	13	+ * @param $content
	14	+ * @param $response
	15	+ * @param array $headers
	16	+ * @return mixed
	17	+ */
	18	+ public static function getJsonResponse($content, $response, $headers = [])
	19	+ {
	20	+ $headers['Content-Type'] = 'application/json';
	21	+ return self::getResponse($headers, $content, $response);
	22	+ }
23	23
24		- /**
25		- * @param array $headers
26		- * @param $content
27		- * @param $response
28		- * @return mixed
29		- */
30		- public static function getResponse($headers = [], $content, $response)
31		- {
32		- $body = $response->getBody();
33		- $body->write($content);
34		- $i = 0;
35		- foreach ($headers as $header => $value) {
36		- if ($i === 0) {
37		- $response = $response->withHeader(
38		- $header,
39		- $value
40		- );
41		- } else {
42		- $response = $response->withAddedHeader(
43		- $header,
44		- $value
45		- );
46		- }
47		- $i++;
48		- }
49		- return $response->withBody($body);
50		- }
	24	+ /**
	25	+ * @param array $headers
	26	+ * @param $content
	27	+ * @param $response
	28	+ * @return mixed
	29	+ */
	30	+ public static function getResponse($headers = [], $content, $response)
	31	+ {
	32	+ $body = $response->getBody();
	33	+ $body->write($content);
	34	+ $i = 0;
	35	+ foreach ($headers as $header => $value) {
	36	+ if ($i === 0) {
	37	+ $response = $response->withHeader(
	38	+ $header,
	39	+ $value
	40	+ );
	41	+ } else {
	42	+ $response = $response->withAddedHeader(
	43	+ $header,
	44	+ $value
	45	+ );
	46	+ }
	47	+ $i++;
	48	+ }
	49	+ return $response->withBody($body);
	50	+ }
51	51
52	52	}
53	53	\ No newline at end of file

		@@ -17,7 +17,7 @@ discard block
		block discarded – undo
17	17	$c = new \Slim\Container($configuration);
18	18	$api = new \Slim\App($c);
19	19
20		-$api->get('/ping', function ($request, $response, $args) {
	20	+$api->get('/ping', function($request, $response, $args) {
21	21	$jsonResp = json_encode(
22	22	[
23	23	"status" => "service up",
		@@ -28,34 +28,34 @@ discard block
		block discarded – undo
28	28	return \App\Lib\Helpers\Responder::getJsonResponse($jsonResp, $response);
29	29	});
30	30
31		-$api->get('/players', function ($request, $response, $args) {
	31	+$api->get('/players', function($request, $response, $args) {
32	32	$json = json_encode(Player::all());
33	33	return \App\Lib\Helpers\Responder::getJsonResponse($json, $response);
34	34	});
35	35
36	36
37		-$api->get('/players/{id}', function ($request, $response, $args) {
	37	+$api->get('/players/{id}', function($request, $response, $args) {
38	38	return \App\Lib\Helpers\Responder::getJsonResponse(
39	39	Player::findOrFail($args['id']),
40	40	$response
41	41	);
42	42	});
43	43
44		-$api->get('/coaches', function ($request, $response, $args) {
	44	+$api->get('/coaches', function($request, $response, $args) {
45	45	return \App\Lib\Helpers\Responder::getJsonResponse(
46	46	Coach::all(),
47	47	$response
48	48	);
49	49	});
50	50
51		-$api->get('/teams', function ($request, $response, $args) {
	51	+$api->get('/teams', function($request, $response, $args) {
52	52	return \App\Lib\Helpers\Responder::getJsonResponse(
53	53	Team::all(),
54	54	$response
55	55	);
56	56	});
57	57
58		-$api->get('/teams/{id}', function ($request, $response, $args) {
	58	+$api->get('/teams/{id}', function($request, $response, $args) {
59	59	return \App\Lib\Helpers\Responder::getJsonResponse(
60	60	Team::with(
61	61	'roster',
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	);
70	70	});
71	71
72		-$api->get('/teams/{id}/players', function ($request, $response, $args) {
	72	+$api->get('/teams/{id}/players', function($request, $response, $args) {
73	73	return \App\Lib\Helpers\Responder::getJsonResponse(
74	74	Team::with(
75	75	'roster'
		@@ -82,7 +82,7 @@ discard block
		block discarded – undo
82	82	);
83	83	});
84	84
85		-$api->get('/teams/{id}/players/{playerId}', function ($request, $response, $args) {
	85	+$api->get('/teams/{id}/players/{playerId}', function($request, $response, $args) {
86	86	return \App\Lib\Helpers\Responder::getJsonResponse(
87	87	Player::where(
88	88	[
		@@ -94,7 +94,7 @@ discard block
		block discarded – undo
94	94	);
95	95	});
96	96
97		-$api->get('/teams/{id}/coach', function ($request, $response, $args) {
	97	+$api->get('/teams/{id}/coach', function($request, $response, $args) {
98	98	return \App\Lib\Helpers\Responder::getJsonResponse(
99	99	Team::with(
100	100	'coach'

		@@ -10,101 +10,101 @@
		block discarded – undo
10	10	use \App\Lib\DsManager\Models\Orm\Coach;
11	11
12	12	$configuration = [
13		- 'settings' => [
14		- 'displayErrorDetails' => true,
15		- ],
	13	+ 'settings' => [
	14	+ 'displayErrorDetails' => true,
	15	+ ],
16	16	];
17	17	$c = new \Slim\Container($configuration);
18	18	$api = new \Slim\App($c);
19	19
20	20	$api->get('/ping', function ($request, $response, $args) {
21		- $jsonResp = json_encode(
22		- [
23		- "status" => "service up",
24		- "message" => "in a bottle",
25		- "config" => \App\Lib\Helpers\Config::get("config1.stuff")
26		- ]
27		- );
28		- return Responder::getJsonResponse($jsonResp, $response);
	21	+ $jsonResp = json_encode(
	22	+ [
	23	+ "status" => "service up",
	24	+ "message" => "in a bottle",
	25	+ "config" => \App\Lib\Helpers\Config::get("config1.stuff")
	26	+ ]
	27	+ );
	28	+ return Responder::getJsonResponse($jsonResp, $response);
29	29	});
30	30
31	31	$api->get('/players', function ($request, $response, $args) {
32		- $json = json_encode(Player::all());
33		- return Responder::getJsonResponse($json, $response);
	32	+ $json = json_encode(Player::all());
	33	+ return Responder::getJsonResponse($json, $response);
34	34	});
35	35
36	36
37	37	$api->get('/players/{id}', function ($request, $response, $args) {
38		- return Responder::getJsonResponse(
39		- Player::findOrFail($args['id']),
40		- $response
41		- );
	38	+ return Responder::getJsonResponse(
	39	+ Player::findOrFail($args['id']),
	40	+ $response
	41	+ );
42	42	});
43	43
44	44	$api->get('/coaches', function ($request, $response, $args) {
45		- return Responder::getJsonResponse(
46		- Coach::all(),
47		- $response
48		- );
	45	+ return Responder::getJsonResponse(
	46	+ Coach::all(),
	47	+ $response
	48	+ );
49	49	});
50	50
51	51	$api->get('/teams', function ($request, $response, $args) {
52		- return Responder::getJsonResponse(
53		- Team::all(),
54		- $response
55		- );
	52	+ return Responder::getJsonResponse(
	53	+ Team::all(),
	54	+ $response
	55	+ );
56	56	});
57	57
58	58	$api->get('/teams/{id}', function ($request, $response, $args) {
59		- return Responder::getJsonResponse(
60		- Team::with(
61		- 'roster',
62		- 'coach'
63		- )->where(
64		- [
65		- 'id' => $args['id']
66		- ]
67		- )->get(),
68		- $response
69		- );
	59	+ return Responder::getJsonResponse(
	60	+ Team::with(
	61	+ 'roster',
	62	+ 'coach'
	63	+ )->where(
	64	+ [
	65	+ 'id' => $args['id']
	66	+ ]
	67	+ )->get(),
	68	+ $response
	69	+ );
70	70	});
71	71
72	72	$api->get('/teams/{id}/players', function ($request, $response, $args) {
73		- return Responder::getJsonResponse(
74		- Team::with(
75		- 'roster'
76		- )->where(
77		- [
78		- 'id' => $args['id']
79		- ]
80		- )->get(),
81		- $response
82		- );
	73	+ return Responder::getJsonResponse(
	74	+ Team::with(
	75	+ 'roster'
	76	+ )->where(
	77	+ [
	78	+ 'id' => $args['id']
	79	+ ]
	80	+ )->get(),
	81	+ $response
	82	+ );
83	83	});
84	84
85	85	$api->get('/teams/{id}/players/{playerId}', function ($request, $response, $args) {
86		- return Responder::getJsonResponse(
87		- Player::where(
88		- [
89		- 'id' => $args['playerId'],
90		- 'team_id' => $args['id']
91		- ]
92		- )->get(),
93		- $response
94		- );
	86	+ return Responder::getJsonResponse(
	87	+ Player::where(
	88	+ [
	89	+ 'id' => $args['playerId'],
	90	+ 'team_id' => $args['id']
	91	+ ]
	92	+ )->get(),
	93	+ $response
	94	+ );
95	95	});
96	96
97	97	$api->get('/teams/{id}/coach', function ($request, $response, $args) {
98		- return Responder::getJsonResponse(
99		- Team::with(
100		- 'coach'
101		- )->where(
102		- [
103		- 'id' => $args['id']
104		- ]
105		- )->get(),
106		- $response
107		- );
	98	+ return Responder::getJsonResponse(
	99	+ Team::with(
	100	+ 'coach'
	101	+ )->where(
	102	+ [
	103	+ 'id' => $args['id']
	104	+ ]
	105	+ )->get(),
	106	+ $response
	107	+ );
108	108	});
109	109
110	110	$api->run();
111	111	\ No newline at end of file

		@@ -8,70 +8,70 @@
		block discarded – undo
8	8	{
9	9
10	10
11		- /**
12		- * @group OrmModels
13		- * @group PlayerOrm
14		- */
15		- public function testPlayerOrmGetSet()
16		- {
17		- $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
18		- $playerM = $rndFiller->getPlayer();
19		- $arrayPl = $playerM->toArray();
20		- $playerO = \App\Lib\DsManager\Models\Orm\Player::create($arrayPl);
21		- $this->assertNotEmpty($playerO);
	11	+ /**
	12	+ * @group OrmModels
	13	+ * @group PlayerOrm
	14	+ */
	15	+ public function testPlayerOrmGetSet()
	16	+ {
	17	+ $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
	18	+ $playerM = $rndFiller->getPlayer();
	19	+ $arrayPl = $playerM->toArray();
	20	+ $playerO = \App\Lib\DsManager\Models\Orm\Player::create($arrayPl);
	21	+ $this->assertNotEmpty($playerO);
22	22
23		- $newPlayer = \App\Lib\DsManager\Models\Player::fromArray($playerO->toArray());
24		- $this->assertNotEmpty($newPlayer);
25		- }
	23	+ $newPlayer = \App\Lib\DsManager\Models\Player::fromArray($playerO->toArray());
	24	+ $this->assertNotEmpty($newPlayer);
	25	+ }
26	26
27		- /**
28		- * @group OrmModels
29		- * @group CoachOrm
30		- */
31		- public function testCoachOrmGetSet()
32		- {
33		- $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
34		- $coach = $rndFiller->getCoach();
35		- $arrayPl = $coach->toArray();
36		- $coachO = \App\Lib\DsManager\Models\Orm\Coach::create($arrayPl);
37		- $this->assertNotEmpty($coachO);
	27	+ /**
	28	+ * @group OrmModels
	29	+ * @group CoachOrm
	30	+ */
	31	+ public function testCoachOrmGetSet()
	32	+ {
	33	+ $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
	34	+ $coach = $rndFiller->getCoach();
	35	+ $arrayPl = $coach->toArray();
	36	+ $coachO = \App\Lib\DsManager\Models\Orm\Coach::create($arrayPl);
	37	+ $this->assertNotEmpty($coachO);
38	38
39		- $newCoach = \App\Lib\DsManager\Models\Coach::fromArray($coachO->toArray());
40		- $this->assertNotEmpty($newCoach);
41		- }
	39	+ $newCoach = \App\Lib\DsManager\Models\Coach::fromArray($coachO->toArray());
	40	+ $this->assertNotEmpty($newCoach);
	41	+ }
42	42
43		- /**
44		- * @group OrmModels
45		- * @group TeamOrm
46		- */
47		- public function testTeamOrm()
48		- {
49		- $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
50		- $team = $rndFiller->getTeam($rndFiller->getLocale());
51		- $teamArray = $team->toArray();
52		- $this->assertNotEmpty($team);
53		- $teamO = \App\Lib\DsManager\Models\Orm\Team::create($teamArray);
54		- $this->assertNotEmpty($teamArray);
55		- $this->assertNotEmpty($teamArray['roster']);
56		- foreach ($teamArray['roster'] as $player) {
57		- $player['team_id'] = $teamO->id;
58		- $playerO = \App\Lib\DsManager\Models\Orm\Player::create($player);
59		- $this->assertNotEmpty($playerO);
60		- }
61		- $teamArray['coach']['team_id'] = $teamO->id;
62		- $coachO = \App\Lib\DsManager\Models\Orm\Coach::create($teamArray['coach']);
63		- $this->assertNotEmpty($coachO);
	43	+ /**
	44	+ * @group OrmModels
	45	+ * @group TeamOrm
	46	+ */
	47	+ public function testTeamOrm()
	48	+ {
	49	+ $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
	50	+ $team = $rndFiller->getTeam($rndFiller->getLocale());
	51	+ $teamArray = $team->toArray();
	52	+ $this->assertNotEmpty($team);
	53	+ $teamO = \App\Lib\DsManager\Models\Orm\Team::create($teamArray);
	54	+ $this->assertNotEmpty($teamArray);
	55	+ $this->assertNotEmpty($teamArray['roster']);
	56	+ foreach ($teamArray['roster'] as $player) {
	57	+ $player['team_id'] = $teamO->id;
	58	+ $playerO = \App\Lib\DsManager\Models\Orm\Player::create($player);
	59	+ $this->assertNotEmpty($playerO);
	60	+ }
	61	+ $teamArray['coach']['team_id'] = $teamO->id;
	62	+ $coachO = \App\Lib\DsManager\Models\Orm\Coach::create($teamArray['coach']);
	63	+ $this->assertNotEmpty($coachO);
64	64
65		- $this->assertNotEmpty(
66		- \App\Lib\DsManager\Models\Orm\Team::with(
67		- 'roster'
68		- )->with(
69		- 'coach'
70		- )->where(
71		- [
72		- 'id' => $teamO->id
73		- ]
74		- )->get()->toArray()
75		- );
76		- }
	65	+ $this->assertNotEmpty(
	66	+ \App\Lib\DsManager\Models\Orm\Team::with(
	67	+ 'roster'
	68	+ )->with(
	69	+ 'coach'
	70	+ )->where(
	71	+ [
	72	+ 'id' => $teamO->id
	73	+ ]
	74	+ )->get()->toArray()
	75	+ );
	76	+ }
77	77	}

		@@ -8,76 +8,76 @@
		block discarded – undo
8	8	{
9	9
10	10
11		- /**
12		- * @group Modules
13		- * @group config
14		- */
15		- public function testAllTheModulesGot11Players()
16		- {
17		- $modules = \App\Lib\Helpers\Config::get('modules.modules');
18		- $this->assertNotEmpty($modules);
19		- foreach ($modules as $key => $module) {
20		- $this->assertNotEmpty($module["roles"]);
21		- $count = 0;
22		- foreach ($module["roles"] as $roleNum) {
23		- $count += $roleNum;
24		- }
25		- $this->assertTrue(11 === $count, "Not correct Players for $key");
26		- }
27		- }
	11	+ /**
	12	+ * @group Modules
	13	+ * @group config
	14	+ */
	15	+ public function testAllTheModulesGot11Players()
	16	+ {
	17	+ $modules = \App\Lib\Helpers\Config::get('modules.modules');
	18	+ $this->assertNotEmpty($modules);
	19	+ foreach ($modules as $key => $module) {
	20	+ $this->assertNotEmpty($module["roles"]);
	21	+ $count = 0;
	22	+ foreach ($module["roles"] as $roleNum) {
	23	+ $count += $roleNum;
	24	+ }
	25	+ $this->assertTrue(11 === $count, "Not correct Players for $key");
	26	+ }
	27	+ }
28	28
29		- /**
30		- * @group Roles
31		- * @group config
32		- */
33		- public function testCorrectDisplayModuleDescriptionRole()
34		- {
35		- $modules = \App\Lib\Helpers\Config::get('modules.modules');
36		- $this->assertNotEmpty($modules);
37		- $roles = \App\Lib\Helpers\Config::get('modules.roles');
38		- $rolesKeys = array_keys($roles);
	29	+ /**
	30	+ * @group Roles
	31	+ * @group config
	32	+ */
	33	+ public function testCorrectDisplayModuleDescriptionRole()
	34	+ {
	35	+ $modules = \App\Lib\Helpers\Config::get('modules.modules');
	36	+ $this->assertNotEmpty($modules);
	37	+ $roles = \App\Lib\Helpers\Config::get('modules.roles');
	38	+ $rolesKeys = array_keys($roles);
39	39
40		- foreach ($modules as $key => $module) {
41		- $this->assertNotEmpty($module["roles"]);
42		- foreach ($module["roles"] as $index => $playNum) {
43		- if ($playNum != 0) {
44		- $this->assertGreaterThan(0, $playNum);
45		- $this->assertNotNull($roles[$rolesKeys[$index]]["description"]);
46		- }
47		- }
48		- }
49		- }
	40	+ foreach ($modules as $key => $module) {
	41	+ $this->assertNotEmpty($module["roles"]);
	42	+ foreach ($module["roles"] as $index => $playNum) {
	43	+ if ($playNum != 0) {
	44	+ $this->assertGreaterThan(0, $playNum);
	45	+ $this->assertNotNull($roles[$rolesKeys[$index]]["description"]);
	46	+ }
	47	+ }
	48	+ }
	49	+ }
50	50
51		- /**
52		- * @group rand
53		- *
54		- */
55		- public function testRandomizer()
56		- {
57		- $yes = 0;
58		- $no = 0;
59		- for ($i = 1; $i <= 100; $i++) {
60		- if (\App\Lib\DsManager\Helpers\Randomizer::boolOnPercentage(20)) {
61		- $yes++;
62		- } else {
63		- $no++;
64		- }
65		- }
66		- $this->assertNotEmpty($yes);
67		- $this->assertNotEmpty($no);
68		- $this->assertGreaterThan($yes, $no);
69		- }
	51	+ /**
	52	+ * @group rand
	53	+ *
	54	+ */
	55	+ public function testRandomizer()
	56	+ {
	57	+ $yes = 0;
	58	+ $no = 0;
	59	+ for ($i = 1; $i <= 100; $i++) {
	60	+ if (\App\Lib\DsManager\Helpers\Randomizer::boolOnPercentage(20)) {
	61	+ $yes++;
	62	+ } else {
	63	+ $no++;
	64	+ }
	65	+ }
	66	+ $this->assertNotEmpty($yes);
	67	+ $this->assertNotEmpty($no);
	68	+ $this->assertGreaterThan($yes, $no);
	69	+ }
70	70
71		- /**
72		- * @group randFiller
73		- *
74		- */
75		- public function testRandomFiller()
76		- {
77		- $rndF = new \App\Lib\DsManager\Helpers\RandomFiller();
78		- for ($i = 1; $i <= 10; $i++) {
79		- $this->assertNotEmpty($rndF->getLocale());
80		- }
81		- }
	71	+ /**
	72	+ * @group randFiller
	73	+ *
	74	+ */
	75	+ public function testRandomFiller()
	76	+ {
	77	+ $rndF = new \App\Lib\DsManager\Helpers\RandomFiller();
	78	+ for ($i = 1; $i <= 10; $i++) {
	79	+ $this->assertNotEmpty($rndF->getLocale());
	80	+ }
	81	+ }
82	82
83	83	}

		@@ -3,20 +3,20 @@
		block discarded – undo
3	3
4	4	class ATeamsSeeder
5	5	{
6		- function run()
7		- {
8		- $teamNumber = 10;
9		- $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
10		- for ($i = 1; $i <= $teamNumber; $i++) {
11		- $team = $rndFiller->getTeam($rndFiller->getLocale());
12		- $teamArray = $team->toArray();
13		- $teamO = \App\Lib\DsManager\Models\Orm\Team::create($teamArray);
14		- foreach ($teamArray['roster'] as $player) {
15		- $player['team_id'] = $teamO->id;
16		- \App\Lib\DsManager\Models\Orm\Player::create($player);
17		- }
18		- $teamArray['coach']['team_id'] = $teamO->id;
19		- \App\Lib\DsManager\Models\Orm\Coach::create($teamArray['coach']);
20		- }
21		- }
	6	+ function run()
	7	+ {
	8	+ $teamNumber = 10;
	9	+ $rndFiller = new \App\Lib\DsManager\Helpers\RandomFiller();
	10	+ for ($i = 1; $i <= $teamNumber; $i++) {
	11	+ $team = $rndFiller->getTeam($rndFiller->getLocale());
	12	+ $teamArray = $team->toArray();
	13	+ $teamO = \App\Lib\DsManager\Models\Orm\Team::create($teamArray);
	14	+ foreach ($teamArray['roster'] as $player) {
	15	+ $player['team_id'] = $teamO->id;
	16	+ \App\Lib\DsManager\Models\Orm\Player::create($player);
	17	+ }
	18	+ $teamArray['coach']['team_id'] = $teamO->id;
	19	+ \App\Lib\DsManager\Models\Orm\Coach::create($teamArray['coach']);
	20	+ }
	21	+ }
22	22	}
23	23	\ No newline at end of file

vikkio88 / dsManager-php

Push — master ( 01ad84...898da4 )

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +24 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +65 added lines, -65 removed lines patch added patch discarded remove patch

Indentation +61 added lines, -61 removed lines patch added patch discarded remove patch

Indentation +67 added lines, -67 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch