Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class Helpers extends \PHPUnit_Framework_TestCase |
||
|
|||
8 | { |
||
9 | |||
10 | |||
11 | /** |
||
12 | * @group Helpers |
||
13 | * @group FixtureGenerator |
||
14 | * @group generatefixture |
||
15 | */ |
||
16 | public function testFixtureGenerator() |
||
29 | |||
30 | /** |
||
31 | * @group Helpers |
||
32 | * @group MatchSimulator |
||
33 | */ |
||
34 | View Code Duplication | public function testMatchSimulator() |
|
52 | |||
53 | /** |
||
54 | * @group Helpers |
||
55 | * @group RoundSimulator |
||
56 | */ |
||
57 | View Code Duplication | public function testRoundSimulator() |
|
77 | |||
78 | } |
||
79 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.