Match::simulate() - Code Metrics - vikkio88/dsManager-php - Measure and Improve Code Quality continuously with Scrutinizer

Match::simulate() F
last analyzed 2016-09-08 19:33 UTC

↳ Parent: Match

Complexity

Conditions	15
Paths	2700

Size

Total Lines	62
Code Lines	46

Duplication

Lines	8
Ratio	12.9 %

Importance

Changes	8
Bugs	1	Features	4

Metric	Value
c	8
b	1
f	4
dl	8
loc	62
rs	2.9275
cc	15
eloc	46
nc	2700
nop	0

How to fix Long Method Complexity

<?php

namespace App\Lib\DsManager\Models;

use App\Lib\DsManager\Helpers\Randomizer;
use App\Lib\DsManager\Models\Common\DsManagerModel;

/**
 * Class Match
 * @package App\Lib\DsManager\Models
 */
class Match extends DsManagerModel
{
    /**
     * @var Team
     */
    private $homeTeam;
    /**
     * @var Team
     */
    private $awayTeam;

    /**
     * Match constructor.
     * @param Team $home
     * @param Team $away
     */
    public function __construct(Team $home, Team $away)
    {
        $this->homeTeam = $home;
        $this->awayTeam = $away;
    }

    /**
     * @return MatchResult
     */
    public function simulate()
    {
        $homePoints = $this->homeTeam->getAvgSkill();
        $awayPoints = $this->awayTeam->getAvgSkill();

        $homePoints += $this->malusModule(
            $this->homeTeam->coach->favouriteModule,
            $this->homeTeam->playersPerRoleArray()
        );
        $awayPoints += $this->malusModule(
            $this->awayTeam->coach->favouriteModule,
            $this->awayTeam->playersPerRoleArray()
        );

        $goalHome = 0;
        $goalAway = 0;

        if (Randomizer::boolOnPercentage(80)) {
            if (($homePoints - $awayPoints) < 0) {
                $goalAway = ($awayPoints - $homePoints) % 6;
                $goalHome += $this->chance();
                $goalAway += $this->chance();
                $goalHome += $this->bonusHome();
            } else {
                $goalHome = ($homePoints - $awayPoints) % 6;
                $goalAway += $this->chance();
                $goalHome += $this->bonusHome();
            }
        } else {
            $goalHome += $this->chance();
            $goalAway += $this->chance();
            $goalHome += $this->bonusHome();
        }
        $goalHome += $this->bonusAge($this->homeTeam);
        $goalAway += $this->bonusAge($this->awayTeam);

        //Bonus on Good GoalKeeper
        $goalies = $this->homeTeam->getBestPlayerForRole("GK");
        $goalAway -= $this->bonusGoalKeeper($goalies);
        $goalies = $this->awayTeam->getBestPlayerForRole("GK");
        $goalHome -= $this->bonusGoalKeeper($goalies);
        //
        $homeModule = new Module($this->homeTeam->coach->favouriteModule);
        $awayModule = new Module($this->awayTeam->coach->favouriteModule);
        if ($homeModule->isOffensive()) {
            $goalHome += Randomizer::boolOnPercentage(50) ? rand(1, 2) : 0;
            $goalAway += Randomizer::boolOnPercentage(20) ? 1 : 0;
        }
        if ($awayModule->isOffensive()) {
            $goalAway += Randomizer::boolOnPercentage(50) ? rand(1, 2) : 0;
            $goalHome += Randomizer::boolOnPercentage(20) ? 1 : 0;
        }
        if ($awayModule->isDefensive()) {
            $goalHome -= Randomizer::boolOnPercentage(50) ? 1 : 0;
        }
        if ($homeModule->isDefensive()) {
            $goalAway -= Randomizer::boolOnPercentage(50) ? 1 : 0;
        }
        $goalHome = $goalHome < 0 ? 0 : $goalHome;
        $goalAway = $goalAway < 0 ? 0 : $goalAway;
        return new MatchResult($goalHome, $goalAway, $this->homeTeam, $this->awayTeam);
    }

    /**
     * @param Team $team
     * @return int
     */
    private function bonusAge(Team $team)
    {
        if ($team->getAvgAge() > 29 || $team->getAvgAge() < 24) {
            return $this->chance();
        }
        return 0;
    }

    /**
     * @param $goalkeeper
     * @return int
     */
    private function bonusGoalKeeper($goalkeeper)
    {
        $skillGoalkeeper = empty($goalkeeper) ? 1 : $goalkeeper->skillAvg;
        return (Randomizer::boolOnPercentage($skillGoalkeeper) ? 1 : 0);
    }

    /**
     * @return int
     */
    private function chance()
    {
        return rand(0, 3);
    }

    /**
     * @return int
     */
    private function bonusHome()
    {
        return Randomizer::boolOnPercentage(66) ? 1 : 0;
    }

    /**
     * @param $moduleString
     * @param $playersRoleArray
     * @return int
     */
    private function malusModule($moduleString, $playersRoleArray)
    {
        $module = new Module($moduleString);
        if ($module->isApplicableToArray($playersRoleArray)) {
            return rand(1, 10);
        } else {
            return (-1) * rand(1, 10);
        }
    }

    /**
     * @param array $ormMatchArray
     * @return Match
     */
    public static function fromArray($ormMatchArray = [])
    {
        $homeTeam = Team::fromArray($ormMatchArray['home_team']);
        $awayTeam = Team::fromArray($ormMatchArray['away_team']);
        return new Match($homeTeam, $awayTeam);
    }

    /**
     * @return mixed
     */
    function toArray()

    {
        $result = [];
        $result['home_team_id'] = $this->homeTeam->id;
        $result['away_team_id'] = $this->awayTeam->id;
        return $result;
    }
}

1		<?php
2
3		namespace App\Lib\DsManager\Models;
4
5		use App\Lib\DsManager\Helpers\Randomizer;
6		use App\Lib\DsManager\Models\Common\DsManagerModel;
7
8		/**
9		* Class Match
10		* @package App\Lib\DsManager\Models
11		*/
12		class Match extends DsManagerModel
13		{
14		/**
15		* @var Team
16		*/
17		private $homeTeam;
18		/**
19		* @var Team
20		*/
21		private $awayTeam;
22
23		/**
24		* Match constructor.
25		* @param Team $home
26		* @param Team $away
27		*/
28		public function __construct(Team $home, Team $away)
29		{
30		$this->homeTeam = $home;
31		$this->awayTeam = $away;
32		}
33
34		/**
35		* @return MatchResult
36		*/
37		public function simulate()
38		{
39		$homePoints = $this->homeTeam->getAvgSkill();
40		$awayPoints = $this->awayTeam->getAvgSkill();
41
42		$homePoints += $this->malusModule(
43		$this->homeTeam->coach->favouriteModule,
44		$this->homeTeam->playersPerRoleArray()
45		);
46		$awayPoints += $this->malusModule(
47		$this->awayTeam->coach->favouriteModule,
48		$this->awayTeam->playersPerRoleArray()
49		);
50
51		$goalHome = 0;
52		$goalAway = 0;
53
54		if (Randomizer::boolOnPercentage(80)) {
55		if (($homePoints - $awayPoints) < 0) {
56		$goalAway = ($awayPoints - $homePoints) % 6;
57		$goalHome += $this->chance();
58		$goalAway += $this->chance();
59		$goalHome += $this->bonusHome();
60		} else {
61		$goalHome = ($homePoints - $awayPoints) % 6;
62		$goalAway += $this->chance();
63		$goalHome += $this->bonusHome();
64		}
65		} else {
66		$goalHome += $this->chance();
67		$goalAway += $this->chance();
68		$goalHome += $this->bonusHome();
69		}
70		$goalHome += $this->bonusAge($this->homeTeam);
71		$goalAway += $this->bonusAge($this->awayTeam);
72
73		//Bonus on Good GoalKeeper
74		$goalies = $this->homeTeam->getBestPlayerForRole("GK");
75		$goalAway -= $this->bonusGoalKeeper($goalies);
76		$goalies = $this->awayTeam->getBestPlayerForRole("GK");
77		$goalHome -= $this->bonusGoalKeeper($goalies);
78		//
79		$homeModule = new Module($this->homeTeam->coach->favouriteModule);
80		$awayModule = new Module($this->awayTeam->coach->favouriteModule);
81	View Code Duplication	if ($homeModule->isOffensive()) {
82		$goalHome += Randomizer::boolOnPercentage(50) ? rand(1, 2) : 0;
83		$goalAway += Randomizer::boolOnPercentage(20) ? 1 : 0;
84		}
85	View Code Duplication	if ($awayModule->isOffensive()) {
86		$goalAway += Randomizer::boolOnPercentage(50) ? rand(1, 2) : 0;
87		$goalHome += Randomizer::boolOnPercentage(20) ? 1 : 0;
88		}
89		if ($awayModule->isDefensive()) {
90		$goalHome -= Randomizer::boolOnPercentage(50) ? 1 : 0;
91		}
92		if ($homeModule->isDefensive()) {
93		$goalAway -= Randomizer::boolOnPercentage(50) ? 1 : 0;
94		}
95		$goalHome = $goalHome < 0 ? 0 : $goalHome;
96		$goalAway = $goalAway < 0 ? 0 : $goalAway;
97		return new MatchResult($goalHome, $goalAway, $this->homeTeam, $this->awayTeam);
98		}
99
100		/**
101		* @param Team $team
102		* @return int
103		*/
104		private function bonusAge(Team $team)
105		{
106		if ($team->getAvgAge() > 29 \|\| $team->getAvgAge() < 24) {
107		return $this->chance();
108		}
109		return 0;
110		}
111
112		/**
113		* @param $goalkeeper
114		* @return int
115		*/
116		private function bonusGoalKeeper($goalkeeper)
117		{
118		$skillGoalkeeper = empty($goalkeeper) ? 1 : $goalkeeper->skillAvg;
119		return (Randomizer::boolOnPercentage($skillGoalkeeper) ? 1 : 0);
120		}
121
122		/**
123		* @return int
124		*/
125		private function chance()
126		{
127		return rand(0, 3);
128		}
129
130		/**
131		* @return int
132		*/
133		private function bonusHome()
134		{
135		return Randomizer::boolOnPercentage(66) ? 1 : 0;
136		}
137
138		/**
139		* @param $moduleString
140		* @param $playersRoleArray
141		* @return int
142		*/
143		private function malusModule($moduleString, $playersRoleArray)
144		{
145		$module = new Module($moduleString);
146		if ($module->isApplicableToArray($playersRoleArray)) {
147		return rand(1, 10);
148		} else {
149		return (-1) * rand(1, 10);
150		}
151		}
152
153		/**
154		* @param array $ormMatchArray
155		* @return Match
156		*/
157		public static function fromArray($ormMatchArray = [])
158		{
159		$homeTeam = Team::fromArray($ormMatchArray['home_team']);
160		$awayTeam = Team::fromArray($ormMatchArray['away_team']);
161		return new Match($homeTeam, $awayTeam);
162		}
163
164		/**
165		* @return mixed
166		*/
167		function toArray()
		0 ignored issues – show Best Practice introduced 2016-08-28 18:28 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
168		{
169		$result = [];
170		$result['home_team_id'] = $this->homeTeam->id;
171		$result['away_team_id'] = $this->awayTeam->id;
172		return $result;
173		}
174		}

vikkio88 / dsManager-php

Match::simulate() F last analyzed 2016-09-08 19:33 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Match::simulate() F
last analyzed 2016-09-08 19:33 UTC