Issues in View.php (master) - Issues in master - vijinho/kohana2-legacy - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1240)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

system/libraries/View.php (17 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php defined('SYSPATH') or die('No direct access allowed.');
/**
 * Loads and displays Kohana view files. Can also handle output of some binary
 * files, such as image, Javascript, and CSS files.
 *
 * $Id: View.php 4072 2009-03-13 17:20:38Z jheathco $
 *
 * @package    Core
 * @author     Kohana Team
 * @copyright  (c) 2007-2008 Kohana Team
 * @license    http://kohanaphp.com/license.html
 */
class View_Core
{

    // The view file name and type
    protected $kohana_filename = false;
    protected $kohana_filetype = false;

    // View variable storage
    protected $kohana_local_data = array();
    protected static $kohana_global_data = array();

    /**
     * Creates a new View using the given parameters.
     *
     * @param   string  view name
     * @param   array   pre-load data
     * @param   string  type of file: html, css, js, etc.
     * @param string $name

     * @return  View
     */
    public static function factory($name = null, $data = null, $type = null)
    {
        return new View($name, $data, $type);
    }

    /**
     * Attempts to load a view and pre-load view data.
     *
     * @throws  Kohana_Exception  if the requested view cannot be found
     * @param   string  view name
     * @param   array   pre-load data
     * @param   string  type of file: html, css, js, etc.
     * @return  void

     */
    public function __construct($name = null, $data = null, $type = null)
    {
        if (is_string($name) and $name !== '') {
            // Set the filename
            $this->set_filename($name, $type);
        }

        if (is_array($data) and ! empty($data)) {
            // Preload data using array_merge, to allow user extensions
            $this->kohana_local_data = array_merge($this->kohana_local_data, $data);
        }
    }

    /**
     * Magic method access to test for view property
     *
     * @param   string   View property to test for
     * @return  boolean

     */
    public function __isset($key = null)
    {
        return $this->is_set($key);
    }

    /**
     * Sets the view filename.
     *
     * @chainable
     * @param   string  view filename
     * @param   string  view file type
     * @param string $name
     * @return  View_Core
     */
    public function set_filename($name, $type = null)
    {
        if ($type == null) {
            // Load the filename and set the content type
            $this->kohana_filename = Kohana::find_file('views', $name, true);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            $this->kohana_filetype = EXT;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        } else {
            // Check if the filetype is allowed by the configuration
            if (! in_array($type, Kohana::config('view.allowed_filetypes'))) {
                throw new Kohana_Exception('core.invalid_filetype', $type);
            }

            // Load the filename and set the content type
            $this->kohana_filename = Kohana::find_file('views', $name, true, $type);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            $this->kohana_filetype = Kohana::config('mimes.'.$type);
$answer = 42;

$correct = false;

$correct = (bool) $answer;

            if ($this->kohana_filetype == null) {
                // Use the specified type
                $this->kohana_filetype = $type;
            }
        }

        return $this;
    }

    /**
     * Sets a view variable.
     *
     * @param   string|array  name of variable or an array of variables
     * @param   mixed         value when using a named variable
     * @return  View_Core
     */
    public function set($name, $value = null)
    {
        if (is_array($name)) {
            foreach ($name as $key => $value) {
                $this->__set($key, $value);
            }
        } else {
            $this->__set($name, $value);
        }

        return $this;
    }

    /**
     * Checks for a property existence in the view locally or globally. Unlike the built in __isset(),
     * this method can take an array of properties to test simultaneously.
     *
     * @param string $key property name to test for

     * @param array $key array of property names to test for
     * @return boolean property test result
     * @return array associative array of keys and boolean test result

     */
    public function is_set($key = false)
    {
        // Setup result;
        $result = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // If key is an array
        if (is_array($key)) {
            // Set the result to an array
            $result = array();

            // Foreach key
            foreach ($key as $property) {
                // Set the result to an associative array
                $result[$property] = (array_key_exists($property, $this->kohana_local_data) or array_key_exists($property, View::$kohana_global_data)) ? true : false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        } else {
            // Otherwise just check one property
            $result = (array_key_exists($key, $this->kohana_local_data) or array_key_exists($key, View::$kohana_global_data)) ? true : false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        // Return the result
        return $result;
    }

    /**
     * Sets a bound variable by reference.
     *
     * @param   string   name of variable
     * @param   mixed    variable to assign by reference
     * @param string $name
     * @return  View_Core
     */
    public function bind($name, & $var)
    {
        $this->kohana_local_data[$name] =& $var;

        return $this;
    }

    /**
     * Sets a view global variable.
     *
     * @param   string|array  name of variable or an array of variables
     * @param   mixed         value when using a named variable
     * @return  void
     */
    public static function set_global($name, $value = null)
    {
        if (is_array($name)) {
            foreach ($name as $key => $value) {
                View::$kohana_global_data[$key] = $value;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        } else {
            View::$kohana_global_data[$name] = $value;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    /**
     * Magically sets a view variable.
     *
     * @param   string   variable key
     * @param   string   variable value
     * @return  void
     */
    public function __set($key, $value)
    {
        $this->kohana_local_data[$key] = $value;
    }

    /**
     * Magically gets a view variable.
     *
     * @param  string  variable key
     * @return mixed   variable value if the key is found
     * @return void    if the key is not found
     */
    public function &__get($key)
    {
        if (isset($this->kohana_local_data[$key])) {
            return $this->kohana_local_data[$key];
        }

        if (isset(View::$kohana_global_data[$key])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return View::$kohana_global_data[$key];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        if (isset($this->$key)) {
            return $this->$key;
        }
    }

    /**
     * Magically converts view object to string.
     *
     * @return  string
     */
    public function __toString()
    {
        try {
            return $this->render();
        } catch (Exception $e) {
            // Display the exception using its internal __toString method
            return (string) $e;
        }
    }

    /**
     * Renders a view.
     *
     * @param   boolean   set to TRUE to echo the output instead of returning it
     * @param   callback  special renderer to pass the output through
     * @return  string    if print is FALSE
     * @return  void      if print is TRUE
     */
    public function render($print = false, $renderer = false)
    {
        if (empty($this->kohana_filename)) {
            throw new Kohana_Exception('core.view_set_filename');
        }

        if (is_string($this->kohana_filetype)) {
            // Merge global and local data, local overrides global with the same name
            $data = array_merge(View::$kohana_global_data, $this->kohana_local_data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            // Load the view in the controller for access to $this
            $output = Kohana::$instance->_kohana_load_view($this->kohana_filename, $data);

            if ($renderer !== false and is_callable($renderer, true)) {
                // Pass the output through the user defined renderer
                $output = call_user_func($renderer, $output);
            }

            if ($print === true) {
                // Display the output
                echo $output;
                return;
            }
        } else {
            // Set the content type and size
            header('Content-Type: '.$this->kohana_filetype[0]);

            if ($print === true) {
                if ($file = fopen($this->kohana_filename, 'rb')) {
                    // Display the output
                    fpassthru($file);
                    fclose($file);
                }
                return;
            }

            // Fetch the file contents
            $output = file_get_contents($this->kohana_filename);
        }

        return $output;
    }
} // End View


vijinho / kohana2-legacy

Issues (1240)

Security Analysis not enabled

system/libraries/View.php (17 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like