Issues in Profiler.php (master) - Issues in master - vijinho/kohana2-legacy - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1240)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

system/libraries/Profiler.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php defined('SYSPATH') or die('No direct access allowed.');
/**
 * Adds useful information to the bottom of the current page for debugging and optimization purposes.
 *
 * Benchmarks   - The times and memory usage of benchmarks run by the Benchmark library.
 * Database     - The raw SQL and number of affected rows of Database queries.
 * Session Data - Data stored in the current session if using the Session library.
 * POST Data    - The name and values of any POST data submitted to the current page.
 * Cookie Data  - All cookies sent for the current request.
 *
 * $Id: Profiler.php 4383 2009-06-03 00:17:24Z ixmatus $
 *
 * @package    Profiler
 * @author     Kohana Team
 * @copyright  (c) 2007-2008 Kohana Team
 * @license    http://kohanaphp.com/license.html
 */
class Profiler_Core
{
    protected $profiles = array();
    protected $show;

    public function __construct()
    {
        // Add all built in profiles to event
        Event::add('profiler.run', array($this, 'benchmarks'));
        Event::add('profiler.run', array($this, 'database'));
        Event::add('profiler.run', array($this, 'session'));
        Event::add('profiler.run', array($this, 'post'));
        Event::add('profiler.run', array($this, 'cookies'));

        // Add profiler to page output automatically
        Event::add('system.display', array($this, 'render'));

        Kohana::log('debug', 'Profiler Library initialized');
    }

    /**
     * Magic __call method. Creates a new profiler section object.
     *
     * @param   string   input type
     * @param   string   input name
     * @return  object

     */
    public function __call($method, $args)
    {
        if (! $this->show or (is_array($this->show) and ! in_array($args[0], $this->show))) {
            return false;
        }

        // Class name
        $class = 'Profiler_'.ucfirst($method);

        $class = new $class();

        $this->profiles[$args[0]] = $class;

        return $class;
    }

    /**
     * Disables the profiler for this page only.
     * Best used when profiler is autoloaded.
     *
     * @return  void
     */
    public function disable()
    {
        // Removes itself from the event queue
        Event::clear('system.display', array($this, 'render'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Render the profiler. Output is added to the bottom of the page by default.
     *
     * @param   boolean  return the output if TRUE
     * @return  void|string
     */
    public function render($return = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $start = microtime(true);

        $get = isset($_GET['profiler']) ? explode(',', $_GET['profiler']) : array();
        $this->show = empty($get) ? Kohana::config('profiler.show') : $get;

        Event::run('profiler.run', $this);

        $styles = '';
        foreach ($this->profiles as $profile) {
            $styles .= $profile->styles();
        }

        // Don't display if there's no profiles
        if (empty($this->profiles)) {
            return;
        }

        // Load the profiler view
        $data = array(
            'profiles' => $this->profiles,
            'styles'   => $styles,
            'execution_time' => microtime(true) - $start
        );
        $view = new View('kohana_profiler', $data);

        // Return rendered view if $return is TRUE
        if ($return === true) {
            return $view->render();
        }

        // Add profiler data to the output
        if (stripos(Kohana::$output, '</body>') !== false) {
            // Closing body tag was found, insert the profiler data before it
            Kohana::$output = str_ireplace('</body>', $view->render().'</body>', Kohana::$output);
        } else {
            // Append the profiler data to the output
            Kohana::$output .= $view->render();
        }
    }

    /**
     * Benchmark times and memory usage from the Benchmark library.
     *
     * @return  void
     */
    public function benchmarks()
    {
        if (! $table = $this->table('benchmarks')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return;
        }

        $table->add_column();
        $table->add_column('kp-column kp-data');
        $table->add_column('kp-column kp-data');
        $table->add_column('kp-column kp-data');
        $table->add_row(array('Benchmarks', 'Time', 'Count', 'Memory'), 'kp-title', 'background-color: #FFE0E0');

        $benchmarks = Benchmark::get(true);

        // Moves the first benchmark (total execution time) to the end of the array
        $benchmarks = array_slice($benchmarks, 1) + array_slice($benchmarks, 0, 1);

        text::alternate();
        foreach ($benchmarks as $name => $benchmark) {
            // Clean unique id from system benchmark names
            $name = ucwords(str_replace(array('_', '-'), ' ', str_replace(SYSTEM_BENCHMARK.'_', '', $name)));

            $data = array($name, number_format($benchmark['time'], 3), $benchmark['count'], number_format($benchmark['memory'] / 1024 / 1024, 2).'MB');
            $class = text::alternate('', 'kp-altrow');

            if ($name == 'Total Execution') {
                $class = 'kp-totalrow';
            }

            $table->add_row($data, $class);
        }
    }

    /**
     * Database query benchmarks.
     *
     * @return  void
     */
    public function database()
    {
        if (! $table = $this->table('database')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return;
        }

        $table->add_column();
        $table->add_column('kp-column kp-data');
        $table->add_column('kp-column kp-data');
        $table->add_row(array('Queries', 'Time', 'Rows'), 'kp-title', 'background-color: #E0FFE0');

        $queries = Database::$benchmarks;

        text::alternate();
        $total_time = $total_rows = 0;
        foreach ($queries as $query) {
            $data = array($query['query'], number_format($query['time'], 3), $query['rows']);
            $class = text::alternate('', 'kp-altrow');
            $table->add_row($data, $class);
            $total_time += $query['time'];
            $total_rows += $query['rows'];
        }

        $data = array('Total: ' . count($queries), number_format($total_time, 3), $total_rows);
        $table->add_row($data, 'kp-totalrow');
    }

    /**
     * Session data.
     *
     * @return  void
     */
    public function session()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (empty($_SESSION)) {
            return;
        }

        if (! $table = $this->table('session')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return;
        }

        $table->add_column('kp-name');
        $table->add_column();
        $table->add_row(array('Session', 'Value'), 'kp-title', 'background-color: #CCE8FB');

        text::alternate();
        foreach ($_SESSION as $name => $value) {
            if (is_object($value)) {
                $value = get_class($value).' [object]';
            }

            $data = array($name, $value);
            $class = text::alternate('', 'kp-altrow');
            $table->add_row($data, $class);
        }
    }

    /**
     * POST data.
     *
     * @return  void
     */
    public function post()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (empty($_POST)) {
            return;
        }

        if (! $table = $this->table('post')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return;
        }

        $table->add_column('kp-name');
        $table->add_column();
        $table->add_row(array('POST', 'Value'), 'kp-title', 'background-color: #E0E0FF');

        text::alternate();
        foreach ($_POST as $name => $value) {
            $data = array($name, $value);
            $class = text::alternate('', 'kp-altrow');
            $table->add_row($data, $class);
        }
    }

    /**
     * Cookie data.
     *
     * @return  void
     */
    public function cookies()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (empty($_COOKIE)) {
            return;
        }

        if (! $table = $this->table('cookies')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return;
        }

        $table->add_column('kp-name');
        $table->add_column();
        $table->add_row(array('Cookies', 'Value'), 'kp-title', 'background-color: #FFF4D7');

        text::alternate();
        foreach ($_COOKIE as $name => $value) {
            $data = array($name, $value);
            $class = text::alternate('', 'kp-altrow');
            $table->add_row($data, $class);
        }
    }
}


1		<?php defined('SYSPATH') or die('No direct access allowed.');
2		/**
3		* Adds useful information to the bottom of the current page for debugging and optimization purposes.
4		*
5		* Benchmarks - The times and memory usage of benchmarks run by the Benchmark library.
6		* Database - The raw SQL and number of affected rows of Database queries.
7		* Session Data - Data stored in the current session if using the Session library.
8		* POST Data - The name and values of any POST data submitted to the current page.
9		* Cookie Data - All cookies sent for the current request.
10		*
11		* $Id: Profiler.php 4383 2009-06-03 00:17:24Z ixmatus $
12		*
13		* @package Profiler
14		* @author Kohana Team
15		* @copyright (c) 2007-2008 Kohana Team
16		* @license http://kohanaphp.com/license.html
17		*/
18		class Profiler_Core
19		{
20		protected $profiles = array();
21		protected $show;
22
23		public function __construct()
24		{
25		// Add all built in profiles to event
26		Event::add('profiler.run', array($this, 'benchmarks'));
27		Event::add('profiler.run', array($this, 'database'));
28		Event::add('profiler.run', array($this, 'session'));
29		Event::add('profiler.run', array($this, 'post'));
30		Event::add('profiler.run', array($this, 'cookies'));
31
32		// Add profiler to page output automatically
33		Event::add('system.display', array($this, 'render'));
34
35		Kohana::log('debug', 'Profiler Library initialized');
36		}
37
38		/**
39		* Magic __call method. Creates a new profiler section object.
40		*
41		* @param string input type
42		* @param string input name
43		* @return object
		0 ignored issues – show Documentation introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `false\|object`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
44		*/
45		public function __call($method, $args)
46		{
47		if (! $this->show or (is_array($this->show) and ! in_array($args[0], $this->show))) {
48		return false;
49		}
50
51		// Class name
52		$class = 'Profiler_'.ucfirst($method);
53
54		$class = new $class();
55
56		$this->profiles[$args[0]] = $class;
57
58		return $class;
59		}
60
61		/**
62		* Disables the profiler for this page only.
63		* Best used when profiler is autoloaded.
64		*
65		* @return void
66		*/
67		public function disable()
68		{
69		// Removes itself from the event queue
70		Event::clear('system.display', array($this, 'render'));
		0 ignored issues – show Documentation introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array($this, 'render')` is of type `array<integer,this<Profi...r_Core>","1":"string"}>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
71		}
72
73		/**
74		* Render the profiler. Output is added to the bottom of the page by default.
75		*
76		* @param boolean return the output if TRUE
77		* @return void\|string
78		*/
79		public function render($return = false)
		0 ignored issues – show Coding Style introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `render` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
80		{
81		$start = microtime(true);
82
83		$get = isset($_GET['profiler']) ? explode(',', $_GET['profiler']) : array();
84		$this->show = empty($get) ? Kohana::config('profiler.show') : $get;
85
86		Event::run('profiler.run', $this);
87
88		$styles = '';
89		foreach ($this->profiles as $profile) {
90		$styles .= $profile->styles();
91		}
92
93		// Don't display if there's no profiles
94		if (empty($this->profiles)) {
95		return;
96		}
97
98		// Load the profiler view
99		$data = array(
100		'profiles' => $this->profiles,
101		'styles' => $styles,
102		'execution_time' => microtime(true) - $start
103		);
104		$view = new View('kohana_profiler', $data);
105
106		// Return rendered view if $return is TRUE
107		if ($return === true) {
108		return $view->render();
109		}
110
111		// Add profiler data to the output
112		if (stripos(Kohana::$output, '</body>') !== false) {
113		// Closing body tag was found, insert the profiler data before it
114		Kohana::$output = str_ireplace('</body>', $view->render().'</body>', Kohana::$output);
115		} else {
116		// Append the profiler data to the output
117		Kohana::$output .= $view->render();
118		}
119		}
120
121		/**
122		* Benchmark times and memory usage from the Benchmark library.
123		*
124		* @return void
125		*/
126		public function benchmarks()
127		{
128		if (! $table = $this->table('benchmarks')) {
		0 ignored issues – show Documentation Bug introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `table` does not exist on `object<Profiler_Core>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
129		return;
130		}
131
132		$table->add_column();
133		$table->add_column('kp-column kp-data');
134		$table->add_column('kp-column kp-data');
135		$table->add_column('kp-column kp-data');
136		$table->add_row(array('Benchmarks', 'Time', 'Count', 'Memory'), 'kp-title', 'background-color: #FFE0E0');
137
138		$benchmarks = Benchmark::get(true);
139
140		// Moves the first benchmark (total execution time) to the end of the array
141		$benchmarks = array_slice($benchmarks, 1) + array_slice($benchmarks, 0, 1);
142
143		text::alternate();
144		foreach ($benchmarks as $name => $benchmark) {
145		// Clean unique id from system benchmark names
146		$name = ucwords(str_replace(array('_', '-'), ' ', str_replace(SYSTEM_BENCHMARK.'_', '', $name)));
147
148		$data = array($name, number_format($benchmark['time'], 3), $benchmark['count'], number_format($benchmark['memory'] / 1024 / 1024, 2).'MB');
149		$class = text::alternate('', 'kp-altrow');
150
151		if ($name == 'Total Execution') {
152		$class = 'kp-totalrow';
153		}
154
155		$table->add_row($data, $class);
156		}
157		}
158
159		/**
160		* Database query benchmarks.
161		*
162		* @return void
163		*/
164		public function database()
165		{
166		if (! $table = $this->table('database')) {
		0 ignored issues – show Documentation Bug introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `table` does not exist on `object<Profiler_Core>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
167		return;
168		}
169
170		$table->add_column();
171		$table->add_column('kp-column kp-data');
172		$table->add_column('kp-column kp-data');
173		$table->add_row(array('Queries', 'Time', 'Rows'), 'kp-title', 'background-color: #E0FFE0');
174
175		$queries = Database::$benchmarks;
176
177		text::alternate();
178		$total_time = $total_rows = 0;
179		foreach ($queries as $query) {
180		$data = array($query['query'], number_format($query['time'], 3), $query['rows']);
181		$class = text::alternate('', 'kp-altrow');
182		$table->add_row($data, $class);
183		$total_time += $query['time'];
184		$total_rows += $query['rows'];
185		}
186
187		$data = array('Total: ' . count($queries), number_format($total_time, 3), $total_rows);
188		$table->add_row($data, 'kp-totalrow');
189		}
190
191		/**
192		* Session data.
193		*
194		* @return void
195		*/
196		public function session()
		0 ignored issues – show Coding Style introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `session` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
197		{
198		if (empty($_SESSION)) {
199		return;
200		}
201
202		if (! $table = $this->table('session')) {
		0 ignored issues – show Documentation Bug introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `table` does not exist on `object<Profiler_Core>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
203		return;
204		}
205
206		$table->add_column('kp-name');
207		$table->add_column();
208		$table->add_row(array('Session', 'Value'), 'kp-title', 'background-color: #CCE8FB');
209
210		text::alternate();
211		foreach ($_SESSION as $name => $value) {
212		if (is_object($value)) {
213		$value = get_class($value).' [object]';
214		}
215
216		$data = array($name, $value);
217		$class = text::alternate('', 'kp-altrow');
218		$table->add_row($data, $class);
219		}
220		}
221
222		/**
223		* POST data.
224		*
225		* @return void
226		*/
227	View Code Duplication	public function post()
		0 ignored issues – show Duplication introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `post` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
228		{
229		if (empty($_POST)) {
230		return;
231		}
232
233		if (! $table = $this->table('post')) {
		0 ignored issues – show Documentation Bug introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `table` does not exist on `object<Profiler_Core>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
234		return;
235		}
236
237		$table->add_column('kp-name');
238		$table->add_column();
239		$table->add_row(array('POST', 'Value'), 'kp-title', 'background-color: #E0E0FF');
240
241		text::alternate();
242		foreach ($_POST as $name => $value) {
243		$data = array($name, $value);
244		$class = text::alternate('', 'kp-altrow');
245		$table->add_row($data, $class);
246		}
247		}
248
249		/**
250		* Cookie data.
251		*
252		* @return void
253		*/
254	View Code Duplication	public function cookies()
		0 ignored issues – show Duplication introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `cookies` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
255		{
256		if (empty($_COOKIE)) {
257		return;
258		}
259
260		if (! $table = $this->table('cookies')) {
		0 ignored issues – show Documentation Bug introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `table` does not exist on `object<Profiler_Core>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
261		return;
262		}
263
264		$table->add_column('kp-name');
265		$table->add_column();
266		$table->add_row(array('Cookies', 'Value'), 'kp-title', 'background-color: #FFF4D7');
267
268		text::alternate();
269		foreach ($_COOKIE as $name => $value) {
270		$data = array($name, $value);
271		$class = text::alternate('', 'kp-altrow');
272		$table->add_row($data, $class);
273		}
274		}
275		}
276

vijinho / kohana2-legacy

Issues (1240)

Security Analysis not enabled

system/libraries/Profiler.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like