Issues in ORM_Versioned.php (master) - Issues in master - vijinho/kohana2-legacy - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1240)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

system/libraries/ORM_Versioned.php (3 issues)

Labels

Documentation 3

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Object Relational Mapping (ORM) "versioned" extension. Allows ORM objects to
 * be revisioned instead of updated.
 *
 * $Id$
 *
 * @package    ORM
 * @author     Kohana Team
 * @copyright  (c) 2007-2008 Kohana Team
 * @license    http://kohanaphp.com/license.html
 */
class ORM_Versioned_Core extends ORM
{
    protected $last_version = null;

    /**
     * Overload ORM::save() to support versioned data
     *
     * @chainable
     * @return  ORM

     */
    public function save()
    {
        $this->last_version = 1 + ($this->last_version === null ? $this->object['version'] : $this->last_version);
        $this->__set('version', $this->last_version);

        parent::save();

        if ($this->saved) {
            $data = array();
            foreach ($this->object as $key => $value) {
                if ($key === 'id') {
                    continue;
                }

                $data[$key] = $value;
            }
            $data[$this->foreign_key()] = $this->id;

            $this->db->insert($this->table_name.'_versions', $data);
        }

        return $this;
    }

    /**
     * Loads previous version from current object
     *
     * @chainable
     * @return  ORM

     */
    public function previous()
    {
        if (! $this->loaded) {
            return $this;
        }

        $this->last_version = ($this->last_version === null) ? $this->object['version'] : $this->last_version;
        $version = $this->last_version - 1;

        $query = $this->db
            ->where($this->foreign_key(), $this->object[$this->primary_key])
            ->where('version', $version)
            ->limit(1)
            ->get($this->table_name.'_versions');

        if ($query->count()) {
            $this->load_values($query->result(false)->current());
        }

        return $this;
    }

    /**
     * Restores the object with data from stored version
     *
     * @param   integer  version number you want to restore
     * @return  ORM

     */
    public function restore($version)
    {
        if (! $this->loaded) {
            return $this;
        }

        $query = $this->db
            ->where($this->foreign_key(), $this->object[$this->primary_key])
            ->where('version', $version)
            ->limit(1)
            ->get($this->table_name.'_versions');

        if ($query->count()) {
            $row = $query->result(false)->current();

            foreach ($row as $key => $value) {
                if ($key === $this->primary_key or $key === $this->foreign_key()) {
                    // Do not overwrite the primary key
                    continue;
                }

                if ($key === 'version') {
                    // Always use the current version
                    $value = $this->version;
                }

                $this->__set($key, $value);
            }

            $this->save();
        }

        return $this;
    }

    /**
     * Overloads ORM::delete() to delete all versioned entries of current object
     * and the object itself
     *
     * @param   integer  id of the object you want to delete
     * @return  ORM
     */
    public function delete($id = null)
    {
        if ($id === null) {
            // Use the current object id
            $id = $this->object[$this->primary_key];
        }

        if ($status = parent::delete($id)) {
            $this->db->where($this->foreign_key(), $id)->delete($this->table_name.'_versions');
        }

        return $status;
    }
}


1			<?php
2			/**
3			* Object Relational Mapping (ORM) "versioned" extension. Allows ORM objects to
4			* be revisioned instead of updated.
5			*
6			* $Id$
7			*
8			* @package ORM
9			* @author Kohana Team
10			* @copyright (c) 2007-2008 Kohana Team
11			* @license http://kohanaphp.com/license.html
12			*/
13			class ORM_Versioned_Core extends ORM
14			{
15			protected $last_version = null;
16
17			/**
18			* Overload ORM::save() to support versioned data
19			*
20			* @chainable
21			* @return ORM
			0 ignored issues – show Documentation introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider making the return type a bit more specific; maybe use `ORM_Versioned_Core`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
22			*/
23			public function save()
24			{
25			$this->last_version = 1 + ($this->last_version === null ? $this->object['version'] : $this->last_version);
26			$this->__set('version', $this->last_version);
27
28			parent::save();
29
30			if ($this->saved) {
31			$data = array();
32			foreach ($this->object as $key => $value) {
33			if ($key === 'id') {
34			continue;
35			}
36
37			$data[$key] = $value;
38			}
39			$data[$this->foreign_key()] = $this->id;
40
41			$this->db->insert($this->table_name.'_versions', $data);
42			}
43
44			return $this;
45			}
46
47			/**
48			* Loads previous version from current object
49			*
50			* @chainable
51			* @return ORM
			0 ignored issues – show Documentation introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider making the return type a bit more specific; maybe use `ORM_Versioned_Core`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
52			*/
53			public function previous()
54			{
55			if (! $this->loaded) {
56			return $this;
57			}
58
59			$this->last_version = ($this->last_version === null) ? $this->object['version'] : $this->last_version;
60			$version = $this->last_version - 1;
61
62			$query = $this->db
63			->where($this->foreign_key(), $this->object[$this->primary_key])
64			->where('version', $version)
65			->limit(1)
66			->get($this->table_name.'_versions');
67
68			if ($query->count()) {
69			$this->load_values($query->result(false)->current());
70			}
71
72			return $this;
73			}
74
75			/**
76			* Restores the object with data from stored version
77			*
78			* @param integer version number you want to restore
79			* @return ORM
			0 ignored issues – show Documentation introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider making the return type a bit more specific; maybe use `ORM_Versioned_Core`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
80			*/
81			public function restore($version)
82			{
83			if (! $this->loaded) {
84			return $this;
85			}
86
87			$query = $this->db
88			->where($this->foreign_key(), $this->object[$this->primary_key])
89			->where('version', $version)
90			->limit(1)
91			->get($this->table_name.'_versions');
92
93			if ($query->count()) {
94			$row = $query->result(false)->current();
95
96			foreach ($row as $key => $value) {
97			if ($key === $this->primary_key or $key === $this->foreign_key()) {
98			// Do not overwrite the primary key
99			continue;
100			}
101
102			if ($key === 'version') {
103			// Always use the current version
104			$value = $this->version;
105			}
106
107			$this->__set($key, $value);
108			}
109
110			$this->save();
111			}
112
113			return $this;
114			}
115
116			/**
117			* Overloads ORM::delete() to delete all versioned entries of current object
118			* and the object itself
119			*
120			* @param integer id of the object you want to delete
121			* @return ORM
122			*/
123			public function delete($id = null)
124			{
125			if ($id === null) {
126			// Use the current object id
127			$id = $this->object[$this->primary_key];
128			}
129
130			if ($status = parent::delete($id)) {
131			$this->db->where($this->foreign_key(), $id)->delete($this->table_name.'_versions');
132			}
133
134			return $status;
135			}
136			}
137

vijinho / kohana2-legacy

Issues (1240)

Security Analysis not enabled

system/libraries/ORM_Versioned.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like