vijinho / kohana2-legacy

system/libraries/Image.php

<?php defined('SYSPATH') or die('No direct access allowed.');
/**
 * Manipulate images using standard methods such as resize, crop, rotate, etc.
 * This class must be re-initialized for every image you wish to manipulate.
 *
 * $Id: Image.php 4072 2009-03-13 17:20:38Z jheathco $
 *
 * @package    Image
 * @author     Kohana Team
 * @copyright  (c) 2007-2008 Kohana Team
 * @license    http://kohanaphp.com/license.html
 */
class Image_Core
{

    // Master Dimension
    const NONE = 1;
    const AUTO = 2;
    const HEIGHT = 3;
    const WIDTH = 4;
    // Flip Directions
    const HORIZONTAL = 5;
    const VERTICAL = 6;

    // Allowed image types
    public static $allowed_types = array(
        IMAGETYPE_GIF => 'gif',
        IMAGETYPE_JPEG => 'jpg',
        IMAGETYPE_PNG => 'png',
        IMAGETYPE_TIFF_II => 'tiff',
        IMAGETYPE_TIFF_MM => 'tiff',
    );

    // Driver instance
    protected $driver;

    // Driver actions
    protected $actions = array();

    // Reference to the current image filename
    protected $image = '';

    /**
     * Creates a new Image instance and returns it.
     *
     * @param   string   filename of image
     * @param   array    non-default configurations
     * @return  object

Consider making the return type a bit more specific; maybe use Image.

     */
    public static function factory($image, $config = null)
    {
        return new Image($image, $config);
    }

    /**
     * Creates a new image editor instance.
     *
     * @throws  Kohana_Exception
     * @param   string   filename of image
     * @param   array    non-default configurations
     * @return  void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct($image, $config = null)
    {
        static $check;

        // Make the check exactly once
        ($check === null) and $check = function_exists('getimagesize');

        if ($check === false) {
            throw new Kohana_Exception('image.getimagesize_missing');
        }

        // Check to make sure the image exists
        if (! is_file($image)) {
            throw new Kohana_Exception('image.file_not_found', $image);
        }

        // Disable error reporting, to prevent PHP warnings
        $ER = error_reporting(0);

Avoid variables with short names like $ER. Configured minimum length is 3.

        // Fetch the image size and mime type
        $image_info = getimagesize($image);

        // Turn on error reporting again
        error_reporting($ER);

        // Make sure that the image is readable and valid
        if (! is_array($image_info) or count($image_info) < 3) {
            throw new Kohana_Exception('image.file_unreadable', $image);
        }

        // Check to make sure the image type is allowed
        if (! isset(Image::$allowed_types[$image_info[2]])) {
            throw new Kohana_Exception('image.type_not_allowed', $image);
        }

        // Image has been validated, load it
        $this->image = array(

It seems like array('file' => str_replace('\\', '/', realpath($image)), 'width' => $image_info[0], 'height' => $image_info[1], 'type' => $image_info[2], 'ext' => \Image::$allowed_types[$image_info[2]], 'mime' => $image_info['mime']) of type array<string,?,{"file":"string","width":"?","height":"?","type":"?","ext":"?","mime":"?"}> is incompatible with the declared type string of property $image.

            'file' => str_replace('\\', '/', realpath($image)),
            'width' => $image_info[0],
            'height' => $image_info[1],
            'type' => $image_info[2],
            'ext' => Image::$allowed_types[$image_info[2]],
            'mime' => $image_info['mime']
        );

        // Load configuration
        $this->config = (array) $config + Kohana::config('image');

The property config does not exist. Did you maybe forget to declare it?

        // Set driver class name
        $driver = 'Image_'.ucfirst($this->config['driver']).'_Driver';

        // Load the driver
        if (! Kohana::auto_load($driver)) {

This code seems to be duplicated across your project.

            throw new Kohana_Exception('core.driver_not_found', $this->config['driver'], get_class($this));
        }

        // Initialize the driver
        $this->driver = new $driver($this->config['params']);

        // Validate the driver
        if (! ($this->driver instanceof Image_Driver)) {

This code seems to be duplicated across your project.

            throw new Kohana_Exception('core.driver_implements', $this->config['driver'], get_class($this), 'Image_Driver');
        }
    }

    /**
     * Handles retrieval of pre-save image properties
     *
     * @param   string  property name
     * @return  string
     */
    public function __get($property)
    {
        if (isset($this->image[$property])) {
            return $this->image[$property];
        } else {
            throw new Kohana_Exception('core.invalid_property', $property, get_class($this));
        }
    }

    /**
     * Resize an image to a specific width and height. By default, Kohana will
     * maintain the aspect ratio using the width as the master dimension. If you
     * wish to use height as master dim, set $image->master_dim = Image::HEIGHT
     * This method is chainable.
     *
     * @throws  Kohana_Exception
     * @param   integer  width
     * @param   integer  height
     * @param   integer  one of: Image::NONE, Image::AUTO, Image::WIDTH, Image::HEIGHT
     * @return  Image_Core
     */
    public function resize($width, $height, $master = null)
    {
        if (! $this->valid_size('width', $width)) {
            throw new Kohana_Exception('image.invalid_width', $width);
        }

        if (! $this->valid_size('height', $height)) {
            throw new Kohana_Exception('image.invalid_height', $height);
        }

        if (empty($width) and empty($height)) {
            throw new Kohana_Exception('image.invalid_dimensions', __FUNCTION__);
        }

        if ($master === null) {
            // Maintain the aspect ratio by default
            $master = Image::AUTO;
        } elseif (! $this->valid_size('master', $master)) {
            throw new Kohana_Exception('image.invalid_master');
        }

        $this->actions['resize'] = array(
            'width'  => $width,
            'height' => $height,
            'master' => $master,
        );

        return $this;
    }

    /**
     * Crop an image to a specific width and height. You may also set the top
     * and left offset.
     * This method is chainable.
     *
     * @throws  Kohana_Exception
     * @param   integer  width
     * @param   integer  height
     * @param   integer  top offset, pixel value or one of: top, center, bottom
     * @param   integer  left offset, pixel value or one of: left, center, right
     * @return  Image_Core
     */
    public function crop($width, $height, $top = 'center', $left = 'center')
    {
        if (! $this->valid_size('width', $width)) {
            throw new Kohana_Exception('image.invalid_width', $width);
        }

        if (! $this->valid_size('height', $height)) {
            throw new Kohana_Exception('image.invalid_height', $height);
        }

        if (! $this->valid_size('top', $top)) {
            throw new Kohana_Exception('image.invalid_top', $top);
        }

        if (! $this->valid_size('left', $left)) {
            throw new Kohana_Exception('image.invalid_left', $left);
        }

        if (empty($width) and empty($height)) {
            throw new Kohana_Exception('image.invalid_dimensions', __FUNCTION__);
        }

        $this->actions['crop'] = array(
            'width'  => $width,
            'height' => $height,
            'top'    => $top,
            'left'   => $left,
        );

        return $this;
    }

    /**
     * Allows rotation of an image by 180 degrees clockwise or counter clockwise.
     *
     * @param   integer  degrees
     * @return  Image_Core
     */
    public function rotate($degrees)
    {
        $degrees = (int) $degrees;

        if ($degrees > 180) {
            do {
                // Keep subtracting full circles until the degrees have normalized
                $degrees -= 360;
            } while ($degrees > 180);
        }

        if ($degrees < -180) {
            do {
                // Keep adding full circles until the degrees have normalized
                $degrees += 360;
            } while ($degrees < -180);
        }

        $this->actions['rotate'] = $degrees;

        return $this;
    }

    /**
     * Flip an image horizontally or vertically.
     *
     * @throws  Kohana_Exception
     * @param   integer  direction
     * @return  Image_Core
     */
    public function flip($direction)
    {
        if ($direction !== Image::HORIZONTAL and $direction !== Image::VERTICAL) {
            throw new Kohana_Exception('image.invalid_flip');
        }

        $this->actions['flip'] = $direction;

        return $this;
    }

    /**
     * Change the quality of an image.
     *
     * @param   integer  quality as a percentage
     * @return  Image_Core
     */
    public function quality($amount)
    {
        $this->actions['quality'] = max(1, min($amount, 100));

        return $this;
    }

    /**
     * Sharpen an image.
     *
     * @param   integer  amount to sharpen, usually ~20 is ideal
     * @return  Image_Core
     */
    public function sharpen($amount)
    {
        $this->actions['sharpen'] = max(1, min($amount, 100));

        return $this;
    }

    /**
     * Save the image to a new image or overwrite this image.
     *
     * @throws  Kohana_Exception
     * @param   string   new image filename
     * @param   integer  permissions for new image
     * @param   boolean  keep or discard image process actions
     * @return  object
     */
    public function save($new_image = false, $chmod = 0644, $keep_actions = false)
    {
        // If no new image is defined, use the current image
        empty($new_image) and $new_image = $this->image['file'];

        // Separate the directory and filename
        $dir  = pathinfo($new_image, PATHINFO_DIRNAME);
        $file = pathinfo($new_image, PATHINFO_BASENAME);

        // Normalize the path
        $dir = str_replace('\\', '/', realpath($dir)).'/';

        if (! is_writable($dir)) {
            throw new Kohana_Exception('image.directory_unwritable', $dir);
        }

        if ($status = $this->driver->process($this->image, $this->actions, $dir, $file)) {
            if ($chmod !== false) {
                // Set permissions
                chmod($new_image, $chmod);
            }
        }

        // Reset actions. Subsequent save() or render() will not apply previous actions.
        if ($keep_actions === false) {
            $this->actions = array();
        }

        return $status;
    }

    /**
     * Output the image to the browser.
     *
     * @param   boolean  keep or discard image process actions
     * @return	object
     */
    public function render($keep_actions = false)
    {
        $new_image = $this->image['file'];

        // Separate the directory and filename
        $dir  = pathinfo($new_image, PATHINFO_DIRNAME);
        $file = pathinfo($new_image, PATHINFO_BASENAME);

        // Normalize the path
        $dir = str_replace('\\', '/', realpath($dir)).'/';

        // Process the image with the driver
        $status = $this->driver->process($this->image, $this->actions, $dir, $file, $render = true);

        // Reset actions. Subsequent save() or render() will not apply previous actions.
        if ($keep_actions === false) {
            $this->actions = array();
        }

        return $status;
    }

    /**
     * Sanitize a given value type.
     *
     * @param   string   type of property
     * @param   mixed    property value
     * @param string $type
     * @return  boolean
     */
    protected function valid_size($type, & $value)
    {
        if (is_null($value)) {
            return true;
        }

        if (! is_scalar($value)) {
            return false;
        }

        switch ($type) {
            case 'width':
            case 'height':
                if (is_string($value) and ! ctype_digit($value)) {
                    // Only numbers and percent signs
                    if (! preg_match('/^[0-9]++%$/D', $value)) {
                        return false;
                    }
                } else {
                    $value = (int) $value;
                }
            break;
            case 'top':

This code seems to be duplicated across your project.

                if (is_string($value) and ! ctype_digit($value)) {
                    if (! in_array($value, array('top', 'bottom', 'center'))) {
                        return false;
                    }
                } else {
                    $value = (int) $value;
                }
            break;
            case 'left':

This code seems to be duplicated across your project.

                if (is_string($value) and ! ctype_digit($value)) {
                    if (! in_array($value, array('left', 'right', 'center'))) {
                        return false;
                    }
                } else {
                    $value = (int) $value;
                }
            break;
            case 'master':
                if ($value !== Image::NONE and
                    $value !== Image::AUTO and
                    $value !== Image::WIDTH and
                    $value !== Image::HEIGHT) {
                    return false;
                }
            break;
        }

        return true;
    }
} // End Image