vijinho / kohana2-legacy

system/helpers/feed.php

<?php defined('SYSPATH') or die('No direct access allowed.');
/**
 * Feed helper class.
 *
 * $Id: feed.php 4152 2009-04-03 23:26:23Z ixmatus $
 *
 * @package    Core
 * @author     Kohana Team
 * @copyright  (c) 2007-2008 Kohana Team
 * @license    http://kohanaphp.com/license.html
 */
class feed_Core
{

    /**
     * Parses a remote feed into an array.
     *
     * @param   string   remote feed URL
     * @param   integer  item limit to fetch
     * @return  array
     */
    public static function parse($feed, $limit = 0)
    {
        // Check if SimpleXML is installed
        if (! function_exists('simplexml_load_file')) {
            throw new Kohana_User_Exception('Feed Error', 'SimpleXML must be installed!');
        }
        
        // Make limit an integer
        $limit = (int) $limit;

        // Disable error reporting while opening the feed
        $ER = error_reporting(0);

Avoid variables with short names like $ER. Configured minimum length is 3.

        // Allow loading by filename or raw XML string
        $load = (is_file($feed) or valid::url($feed)) ? 'simplexml_load_file' : 'simplexml_load_string';

        // Load the feed
        $feed = $load($feed, 'SimpleXMLElement', LIBXML_NOCDATA);

        // Restore error reporting
        error_reporting($ER);

        // Feed could not be loaded
        if ($feed === false) {
            return array();
        }

        // Detect the feed type. RSS 1.0/2.0 and Atom 1.0 are supported.
        $feed = isset($feed->channel) ? $feed->xpath('//item') : $feed->entry;

        $i = 0;
        $items = array();

        foreach ($feed as $item) {
            if ($limit > 0 and $i++ === $limit) {
                break;
            }

            $items[] = (array) $item;
        }

        return $items;
    }

    /**
     * Creates a feed from the given parameters.
     *
     * @param   array   feed information
     * @param   array   items to add to the feed
     * @param   string  define which format to use
     * @param   string  define which encoding to use
     * @return  string

Should the return type not be string|false?

     */
    public static function create($info, $items, $format = 'rss2', $encoding = 'UTF-8')

The parameter $format is not used and could be removed.

    {
        $info += array('title' => 'Generated Feed', 'link' => '', 'generator' => 'KohanaPHP');

        $feed = '<?xml version="1.0" encoding="'.$encoding.'"?><rss version="2.0"><channel></channel></rss>';
        $feed = simplexml_load_string($feed);

        foreach ($info as $name => $value) {

This code seems to be duplicated across your project.

            if (($name === 'pubDate' or $name === 'lastBuildDate') and (is_int($value) or ctype_digit($value))) {
                // Convert timestamps to RFC 822 formatted dates
                $value = date(DATE_RFC822, $value);
            } elseif (($name === 'link' or $name === 'docs') and strpos($value, '://') === false) {
                // Convert URIs to URLs
                $value = url::site($value, 'http');
            }

            // Add the info to the channel
            $feed->channel->addChild($name, $value);
        }

        foreach ($items as $item) {
            // Add the item to the channel
            $row = $feed->channel->addChild('item');

            foreach ($item as $name => $value) {

This code seems to be duplicated across your project.

                if ($name === 'pubDate' and (is_int($value) or ctype_digit($value))) {
                    // Convert timestamps to RFC 822 formatted dates
                    $value = date(DATE_RFC822, $value);
                } elseif (($name === 'link' or $name === 'guid') and strpos($value, '://') === false) {
                    // Convert URIs to URLs
                    $value = url::site($value, 'http');
                }

                // Add the info to the row
                $row->addChild($name, $value);
            }
        }

        return $feed->asXML();
    }
} // End feed