Issues in cookie.php (master) - Issues in master - vijinho/kohana2-legacy - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1240)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

system/helpers/cookie.php (1 issue)

Labels

Coding Style 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php defined('SYSPATH') or die('No direct access allowed.');
/**
 * Cookie helper class.
 *
 * $Id: cookie.php 3769 2008-12-15 00:48:56Z zombor $
 *
 * @package    Core
 * @author     Kohana Team
 * @copyright  (c) 2007-2008 Kohana Team
 * @license    http://kohanaphp.com/license.html
 */
class cookie_Core
{

    /**
     * Sets a cookie with the given parameters.
     *
     * @param   string   cookie name or array of config options
     * @param   string   cookie value
     * @param   integer  number of seconds before the cookie expires
     * @param   string   URL path to allow
     * @param   string   URL domain to allow
     * @param   boolean  HTTPS only
     * @param   boolean  HTTP only (requires PHP 5.2 or higher)
     * @return  boolean
     */
    public static function set($name, $value = null, $expire = null, $path = null, $domain = null, $secure = null, $httponly = null)
    {
        if (headers_sent()) {
            return false;
        }

        // If the name param is an array, we import it
        is_array($name) and extract($name, EXTR_OVERWRITE);

        // Fetch default options
        $config = Kohana::config('cookie');

        foreach (array('value', 'expire', 'domain', 'path', 'secure', 'httponly') as $item) {
            if ($$item === null and isset($config[$item])) {
                $$item = $config[$item];
            }
        }

        // Expiration timestamp
        $expire = ($expire == 0) ? 0 : time() + (int) $expire;

        return setcookie($name, $value, $expire, $path, $domain, $secure, $httponly);
    }

    /**
     * Fetch a cookie value, using the Input library.
     *
     * @param   string   cookie name
     * @param   mixed    default value
     * @param   boolean  use XSS cleaning on the value
     * @return  string
     */
    public static function get($name, $default = null, $xss_clean = false)
    {
        return Input::instance()->cookie($name, $default, $xss_clean);
    }

    /**
     * Nullify and unset a cookie.
     *
     * @param   string   cookie name
     * @param   string   URL path
     * @param   string   URL domain
     * @return  boolean
     */
    public static function delete($name, $path = null, $domain = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (! isset($_COOKIE[$name])) {
            return false;
        }

        // Delete the cookie from globals
        unset($_COOKIE[$name]);

        // Sets the cookie value to an empty string, and the expiration to 24 hours ago
        return cookie::set($name, '', -86400, $path, $domain, false, false);
    }
} // End cookie


1			<?php defined('SYSPATH') or die('No direct access allowed.');
2			/**
3			* Cookie helper class.
4			*
5			* $Id: cookie.php 3769 2008-12-15 00:48:56Z zombor $
6			*
7			* @package Core
8			* @author Kohana Team
9			* @copyright (c) 2007-2008 Kohana Team
10			* @license http://kohanaphp.com/license.html
11			*/
12			class cookie_Core
13			{
14
15			/**
16			* Sets a cookie with the given parameters.
17			*
18			* @param string cookie name or array of config options
19			* @param string cookie value
20			* @param integer number of seconds before the cookie expires
21			* @param string URL path to allow
22			* @param string URL domain to allow
23			* @param boolean HTTPS only
24			* @param boolean HTTP only (requires PHP 5.2 or higher)
25			* @return boolean
26			*/
27			public static function set($name, $value = null, $expire = null, $path = null, $domain = null, $secure = null, $httponly = null)
28			{
29			if (headers_sent()) {
30			return false;
31			}
32
33			// If the name param is an array, we import it
34			is_array($name) and extract($name, EXTR_OVERWRITE);
35
36			// Fetch default options
37			$config = Kohana::config('cookie');
38
39			foreach (array('value', 'expire', 'domain', 'path', 'secure', 'httponly') as $item) {
40			if ($$item === null and isset($config[$item])) {
41			$$item = $config[$item];
42			}
43			}
44
45			// Expiration timestamp
46			$expire = ($expire == 0) ? 0 : time() + (int) $expire;
47
48			return setcookie($name, $value, $expire, $path, $domain, $secure, $httponly);
49			}
50
51			/**
52			* Fetch a cookie value, using the Input library.
53			*
54			* @param string cookie name
55			* @param mixed default value
56			* @param boolean use XSS cleaning on the value
57			* @return string
58			*/
59			public static function get($name, $default = null, $xss_clean = false)
60			{
61			return Input::instance()->cookie($name, $default, $xss_clean);
62			}
63
64			/**
65			* Nullify and unset a cookie.
66			*
67			* @param string cookie name
68			* @param string URL path
69			* @param string URL domain
70			* @return boolean
71			*/
72			public static function delete($name, $path = null, $domain = null)
			0 ignored issues – show Coding Style introduced 2016-08-25 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `delete` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
73			{
74			if (! isset($_COOKIE[$name])) {
75			return false;
76			}
77
78			// Delete the cookie from globals
79			unset($_COOKIE[$name]);
80
81			// Sets the cookie value to an empty string, and the expiration to 24 hours ago
82			return cookie::set($name, '', -86400, $path, $domain, false, false);
83			}
84			} // End cookie
85

vijinho / kohana2-legacy

Issues (1240)

Security Analysis not enabled

system/helpers/cookie.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like