Database_Driver

Complexity

Total Complexity

47

Size/Duplication

Total Lines	416
Duplicated Lines	9.86 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes	2
Bugs	1	Features	0

27 Methods

Rating	Name	Duplication	Size	Complexity
	connect()	0	1	?
	query()	0	1	?
A	delete()	0	4	1
A	update()	7	7	2
A	set_charset()	0	4	1
	escape_table()	0	1	?
	escape_column()	0	1	?
C	where()	0	35	13
A	like()	13	13	3
A	notlike()	13	13	3
A	regex()	0	4	1
A	notregex()	0	4	1
A	insert()	8	8	2
A	merge()	0	4	1
	limit()	0	1	?
A	stmt_prepare()	0	4	1
	compile_select()	0	1	?
A	has_operator()	0	4	1
B	escape()	0	24	6
	escape_str()	0	1	?
	list_tables()	0	1	?
	list_fields()	0	1	?
	show_error()	0	1	?
	field_data()	0	1	?
C	sql_type()	0	46	8
A	clear_cache()	0	10	2
A	query_hash()	0	4	1

<?php defined('SYSPATH') or die('No direct access allowed.');
/**
 * Database API driver
 *
 * $Id: Database.php 4343 2009-05-08 17:04:48Z jheathco $
 *
 * @package    Core
 * @author     Kohana Team
 * @copyright  (c) 2007-2008 Kohana Team
 * @license    http://kohanaphp.com/license.html
 */
abstract class Database_Driver
{
    protected $query_cache;

    /**
     * Connect to our database.
     * Returns FALSE on failure or a MySQL resource.
     *
     * @return mixed
     */
    abstract public function connect();

    /**
     * Perform a query based on a manually written query.
     *
     * @param  string  SQL query to execute
     * @return Database_Result
     */
    abstract public function query($sql);

    /**
     * Builds a DELETE query.
     *
     * @param   string  table name
     * @param   array   where clause
     * @return  string
     */
    public function delete($table, $where)
    {
        return 'DELETE FROM '.$this->escape_table($table).' WHERE '.implode(' ', $where);
    }

    /**
     * Builds an UPDATE query.
     *
     * @param   string  table name
     * @param   array   key => value pairs
     * @param   array   where clause
     * @return  string
     */
    public function update($table, $values, $where)

This method seems to be duplicated in your project.

    {
        foreach ($values as $key => $val) {
            $valstr[] = $this->escape_column($key).' = '.$val;

$valstr was never initialized. Although not strictly required by PHP, it is generally a good practice to add $valstr = array(); before regardless.

        }
        return 'UPDATE '.$this->escape_table($table).' SET '.implode(', ', $valstr).' WHERE '.implode(' ', $where);

The variable $valstr does not seem to be defined for all execution paths leading up to this point.

    }

    /**
     * Set the charset using 'SET NAMES <charset>'.
     *
     * @param  string  character set to use
     */
    public function set_charset($charset)
    {
        throw new Kohana_Database_Exception('database.not_implemented', __FUNCTION__);
    }

    /**
     * Wrap the tablename in backticks, has support for: table.field syntax.
     *
     * @param   string  table name
     * @return  string
     */
    abstract public function escape_table($table);

    /**
     * Escape a column/field name, has support for special commands.
     *
     * @param   string  column name
     * @return  string
     */
    abstract public function escape_column($column);

    /**
     * Builds a WHERE portion of a query.
     *
     * @param   mixed    key
     * @param   string   value
     * @param   string   type
     * @param   int      number of where clauses
     * @param   boolean  escape the value
     * @return  string
     */
    public function where($key, $value, $type, $num_wheres, $quote)
    {
        $prefix = ($num_wheres == 0) ? '' : $type;

        if ($quote === -1) {
            $value = '';
        } else {
            if ($value === null) {
                if (! $this->has_operator($key)) {
                    $key .= ' IS';
                }

                $value = ' NULL';
            } elseif (is_bool($value)) {
                if (! $this->has_operator($key)) {
                    $key .= ' =';
                }

                $value = ($value == true) ? ' 1' : ' 0';

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            } else {
                if (! $this->has_operator($key) and ! empty($key)) {
                    $key = $this->escape_column($key).' =';
                } else {
                    preg_match('/^(.+?)([<>!=]+|\bIS(?:\s+NULL))\s*$/i', $key, $matches);
                    if (isset($matches[1]) and isset($matches[2])) {
                        $key = $this->escape_column(trim($matches[1])).' '.trim($matches[2]);
                    }
                }

                $value = ' '.(($quote == true) ? $this->escape($value) : $value);
            }
        }

        return $prefix.$key.$value;
    }

    /**
     * Builds a LIKE portion of a query.
     *
     * @param   mixed    field name
     * @param   string   value to match with field
     * @param   boolean  add wildcards before and after the match
     * @param   string   clause type (AND or OR)
     * @param   int      number of likes
     * @return  string
     */
    public function like($field, $match, $auto, $type, $num_likes)

This method seems to be duplicated in your project.

    {
        $prefix = ($num_likes == 0) ? '' : $type;

        $match = $this->escape_str($match);

        if ($auto === true) {
            // Add the start and end quotes
            $match = '%'.str_replace('%', '\\%', $match).'%';
        }

        return $prefix.' '.$this->escape_column($field).' LIKE \''.$match . '\'';
    }

    /**
     * Builds a NOT LIKE portion of a query.
     *
     * @param   mixed   field name
     * @param   string  value to match with field
     * @param   string  clause type (AND or OR)
     * @param   int     number of likes
     * @return  string
     */
    public function notlike($field, $match, $auto, $type, $num_likes)

This method seems to be duplicated in your project.

    {
        $prefix = ($num_likes == 0) ? '' : $type;

        $match = $this->escape_str($match);

        if ($auto === true) {
            // Add the start and end quotes
            $match = '%'.$match.'%';
        }

        return $prefix.' '.$this->escape_column($field).' NOT LIKE \''.$match.'\'';
    }

    /**
     * Builds a REGEX portion of a query.
     *
     * @param   string   field name
     * @param   string   value to match with field
     * @param   string   clause type (AND or OR)
     * @param   integer  number of regexes
     * @return  string

Consider making the return type a bit more specific; maybe use NoType.

     */
    public function regex($field, $match, $type, $num_regexs)
    {
        throw new Kohana_Database_Exception('database.not_implemented', __FUNCTION__);
    }

    /**
     * Builds a NOT REGEX portion of a query.
     *
     * @param   string   field name
     * @param   string   value to match with field
     * @param   string   clause type (AND or OR)
     * @param   integer  number of regexes
     * @return  string

Consider making the return type a bit more specific; maybe use NoType.

     */
    public function notregex($field, $match, $type, $num_regexs)
    {
        throw new Kohana_Database_Exception('database.not_implemented', __FUNCTION__);
    }

    /**
     * Builds an INSERT query.
     *
     * @param   string  table name
     * @param   array   keys
     * @param   array   values
     * @return  string
     */
    public function insert($table, $keys, $values)

This method seems to be duplicated in your project.

    {
        // Escape the column names
        foreach ($keys as $key => $value) {
            $keys[$key] = $this->escape_column($value);
        }
        return 'INSERT INTO '.$this->escape_table($table).' ('.implode(', ', $keys).') VALUES ('.implode(', ', $values).')';
    }

    /**
     * Builds a MERGE portion of a query.
     *
     * @param   string  table name
     * @param   array   keys
     * @param   array   values
     * @return  string

Consider making the return type a bit more specific; maybe use NoType.

     */
    public function merge($table, $keys, $values)
    {
        throw new Kohana_Database_Exception('database.not_implemented', __FUNCTION__);
    }

    /**
     * Builds a LIMIT portion of a query.
     *
     * @param   integer  limit
     * @param   integer  offset
     * @return  string
     */
    abstract public function limit($limit, $offset = 0);

    /**
     * Creates a prepared statement.
     *
     * @param   string  SQL query
     * @return  Database_Stmt

Consider making the return type a bit more specific; maybe use NoType.

     */
    public function stmt_prepare($sql = '')

The parameter $sql is not used and could be removed.

    {
        throw new Kohana_Database_Exception('database.not_implemented', __FUNCTION__);
    }

    /**
     *  Compiles the SELECT statement.
     *  Generates a query string based on which functions were used.
     *  Should not be called directly, the get() function calls it.
     *
     * @param   array   select query values
     * @return  string
     */
    abstract public function compile_select($database);

    /**
     * Determines if the string has an arithmetic operator in it.
     *
     * @param   string   string to check
     * @return  boolean
     */
    public function has_operator($str)
    {
        return (bool) preg_match('/[<>!=]|\sIS(?:\s+NOT\s+)?\b|BETWEEN/i', trim($str));
    }

    /**
     * Escapes any input value.
     *
     * @param   mixed   value to escape
     * @return  string
     */
    public function escape($value)
    {
        if (! $this->db_config['escape']) {

The property db_config does not exist. Did you maybe forget to declare it?

            return $value;
        }

        switch (gettype($value)) {
            case 'string':
                $value = '\''.$this->escape_str($value).'\'';
            break;
            case 'boolean':
                $value = (int) $value;
            break;
            case 'double':
                // Convert to non-locale aware float to prevent possible commas
                $value = sprintf('%F', $value);
            break;
            default:
                $value = ($value === null) ? 'NULL' : $value;
            break;
        }

        return (string) $value;
    }

    /**
     * Escapes a string for a query.
     *
     * @param   mixed   value to escape
     * @return  string
     */
    abstract public function escape_str($str);

    /**
     * Lists all tables in the database.
     *
     * @return  array
     */
    abstract public function list_tables();

    /**
     * Lists all fields in a table.
     *
     * @param   string  table name
     * @return  array
     */
    abstract public function list_fields($table);

    /**
     * Returns the last database error.
     *
     * @return  string
     */
    abstract public function show_error();

    /**
     * Returns field data about a table.
     *
     * @param   string  table name
     * @return  array
     */
    abstract public function field_data($table);

    /**
     * Fetches SQL type information about a field, in a generic format.
     *
     * @param   string  field datatype
     * @return  string
     */
    protected function sql_type($str)
    {
        static $sql_types;

        if ($sql_types === null) {
            // Load SQL data types
            $sql_types = Kohana::config('sql_types');
        }

        $str = strtolower(trim($str));

        if (($open  = strpos($str, '(')) !== false) {
            // Find closing bracket
            $close = strpos($str, ')', $open) - 1;

            // Find the type without the size
            $type = substr($str, 0, $open);
        } else {
            // No length
            $type = $str;
        }

        empty($sql_types[$type]) and exit(

The method sql_type() contains an exit expression.

            'Unknown field type: '.$type.'. '.
            'Please report this: http://trac.kohanaphp.com/newticket'
        );

        // Fetch the field definition
        $field = $sql_types[$type];

        switch ($field['type']) {
            case 'string':
            case 'float':
                if (isset($close)) {
                    // Add the length to the field info
                    $field['length'] = substr($str, $open + 1, $close - $open);
                }
            break;
            case 'int':
                // Add unsigned value
                $field['unsigned'] = (strpos($str, 'unsigned') !== false);
            break;
        }

        return $field;
    }

    /**
     * Clears the internal query cache.
     *
     * @param  string  SQL query
     */
    public function clear_cache($sql = null)
    {
        if (empty($sql)) {
            $this->query_cache = array();
        } else {
            unset($this->query_cache[$this->query_hash($sql)]);
        }

        Kohana::log('debug', 'Database cache cleared: '.get_class($this));
    }

    /**
     * Creates a hash for an SQL query string. Replaces newlines with spaces,
     * trims, and hashes.
     *
     * @param   string  SQL query
     * @return  string
     */
    protected function query_hash($sql)
    {
        return sha1(str_replace("\n", ' ', trim($sql)));
    }
} // End Database Driver Interface

/**
 * Database_Result
 *
 */
abstract class Database_Result implements ArrayAccess, Iterator, Countable
{

    // Result resource, insert id, and SQL
    protected $result;
    protected $insert_id;
    protected $sql;

    // Current and total rows
    protected $current_row = 0;
    protected $total_rows  = 0;

    // Fetch function and return type
    protected $fetch_type;
    protected $return_type;

    /**
     * Returns the SQL used to fetch the result.
     *
     * @return  string
     */
    public function sql()
    {
        return $this->sql;
    }

    /**
     * Returns the insert id from the result.
     *
     * @return  integer

Should the return type not be integer|string?

     */
    public function insert_id()
    {
        return $this->insert_id;
    }

    /**
     * Prepares the query result.
     *
     * @param   boolean   return rows as objects
     * @param   mixed     type
     * @return  Database_Result
     */
    abstract public function result($object = true, $type = false);

    /**
     * Builds an array of query results.
     *
     * @param   boolean   return rows as objects
     * @param   mixed     type
     * @param boolean $object

Should the type for parameter $object not be boolean|null?

     * @return  array
     */
    abstract public function result_array($object = null, $type = false);

    /**
     * Gets the fields of an already run query.
     *
     * @return  array
     */
    abstract public function list_fields();

    /**
     * Seek to an offset in the results.
     *
     * @return  boolean
     */
    abstract public function seek($offset);

    /**
     * Countable: count
     */
    public function count()
    {
        return $this->total_rows;
    }

    /**
     * ArrayAccess: offsetExists
     */
    public function offsetExists($offset)
    {
        if ($this->total_rows > 0) {
            $min = 0;
            $max = $this->total_rows - 1;

            return ! ($offset < $min or $offset > $max);
        }

        return false;
    }

    /**
     * ArrayAccess: offsetGet
     */
    public function offsetGet($offset)

This method seems to be duplicated in your project.

    {
        if (! $this->seek($offset)) {
            return false;
        }

        // Return the row by calling the defined fetching callback
        return call_user_func($this->fetch_type, $this->result, $this->return_type);
    }

    /**
     * ArrayAccess: offsetSet
     *
     * @throws  Kohana_Database_Exception
     */
    final public function offsetSet($offset, $value)
    {
        throw new Kohana_Database_Exception('database.result_read_only');
    }

    /**
     * ArrayAccess: offsetUnset
     *
     * @throws  Kohana_Database_Exception
     */
    final public function offsetUnset($offset)
    {
        throw new Kohana_Database_Exception('database.result_read_only');
    }

    /**
     * Iterator: current
     */
    public function current()
    {
        return $this->offsetGet($this->current_row);
    }

    /**
     * Iterator: key
     */
    public function key()
    {
        return $this->current_row;
    }

    /**
     * Iterator: next
     */
    public function next()
    {
        ++$this->current_row;
        return $this;
    }

    /**
     * Iterator: prev
     */
    public function prev()
    {
        --$this->current_row;
        return $this;
    }

    /**
     * Iterator: rewind
     */
    public function rewind()
    {
        $this->current_row = 0;
        return $this;
    }

    /**
     * Iterator: valid
     */
    public function valid()
    {
        return $this->offsetExists($this->current_row);
    }
} // End Database Result Interface