Contact - Code Metrics - Inspection of "handle custom contact form page" - vijinho/f3-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev-master ( 4ebc69...e67cd9 )

by Vijay

created 2016-09-03 16:06 UTC

Contact A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
dl	0
loc	53
rs	10
c	0
b	0
f	0
wmc	9
lcom	1
cbo	4

2 Methods

Rating	Name	Duplication	Size	Complexity
C	contact()	0	26	8
A	contactPost()	0	6	1

<?php

namespace FFCMS\Controllers;

use FFCMS\{Mappers};


/**
 * Contact Page Controller Class.
 *
 * @author Vijay Mahrra <[email protected]>
 * @copyright (c) Copyright 2016 Vijay Mahrra
 * @license GPLv3 (http://www.gnu.org/licenses/gpl-3.0.html)
 */
class Contact extends Base
{
    protected $template_path = 'pages/';

    /**
     * Make contact page
     *
     * @param \Base $f3
     * @param array $params
     * @return void
     */
    public function contact(\Base $f3, array $params = [])

    {
        $page = new Mappers\Pages;
        $page->load(['slug = ?', 'contact']);

        // conditions if page is viewable
        $publishTime = strtotime($page->published);
        $expireTime = strtotime($page->expires);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $showPage = $f3->get('REQUEST.preview') || (
            'published' == $page->status &&
            'public' == $page->scopes &&
            'page' == $page->category &&
            time() > $publishTime &&
            (0 >= $expireTime || $expireTime > time())
        );

        if (!$showPage) {
            // 404
            echo 'page unavailable';
            die(404);
        }

        $f3->set('pagesMapper', $page);

        echo \View::instance()->render($this->template_path . '/contact.phtml');
    }

    /**
     * Contact page form post handler
     *
     * @param \Base $f3
     * @param array $params
     * @return void
     */
    public function contactPost(\Base $f3, array $params = [])

    {
        // handle form input, send email
        
        echo \View::instance()->render($this->template_path . '/contact.phtml');
    }

}


1			<?php
2
3			namespace FFCMS\Controllers;
4
5			use FFCMS\{Mappers};
6
7
8			/**
9			* Contact Page Controller Class.
10			*
11			* @author Vijay Mahrra <[email protected]>
12			* @copyright (c) Copyright 2016 Vijay Mahrra
13			* @license GPLv3 (http://www.gnu.org/licenses/gpl-3.0.html)
14			*/
15			class Contact extends Base
16			{
17			protected $template_path = 'pages/';
18
19			/**
20			* Make contact page
21			*
22			* @param \Base $f3
23			* @param array $params
24			* @return void
25			*/
26			public function contact(\Base $f3, array $params = [])
			0 ignored issues – show Unused Code introduced 2016-09-03 16:09 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
27			{
28			$page = new Mappers\Pages;
29			$page->load(['slug = ?', 'contact']);
30
31			// conditions if page is viewable
32			$publishTime = strtotime($page->published);
33			$expireTime = strtotime($page->expires);
			0 ignored issues – show Documentation introduced 2016-09-03 16:09 UTC by Report Bug Copy Issue Report The property `expires` does not exist on `object<FFCMS\Mappers\Pages>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			$showPage = $f3->get('REQUEST.preview') \|\| (
35			'published' == $page->status &&
36			'public' == $page->scopes &&
37			'page' == $page->category &&
38			time() > $publishTime &&
39			(0 >= $expireTime \|\| $expireTime > time())
40			);
41
42			if (!$showPage) {
43			// 404
44			echo 'page unavailable';
45			die(404);
46			}
47
48			$f3->set('pagesMapper', $page);
49
50			echo \View::instance()->render($this->template_path . '/contact.phtml');
51			}
52
53			/**
54			* Contact page form post handler
55			*
56			* @param \Base $f3
57			* @param array $params
58			* @return void
59			*/
60			public function contactPost(\Base $f3, array $params = [])
			0 ignored issues – show Unused Code introduced 2016-09-03 16:09 UTC by Report Bug Copy Issue Report The parameter `$f3` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-09-03 16:09 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
61			{
62			// handle form input, send email
63
64			echo \View::instance()->render($this->template_path . '/contact.phtml');
65			}
66
67			}
68

vijinho / f3-cms

Push — dev-master ( 4ebc69...e67cd9 )

Contact A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like