FFCMS\Controllers\Media\Images\Users

Complexity

Total Complexity

13

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
C	profile()	0	60	13

<?php

namespace FFCMS\Controllers\Media\Images;

use FFCMS\Mappers;

/**
 * Index Controller Class.
 *
 * @author Vijay Mahrra <vijay@yoyo.org>
 * @copyright (c) Copyright 2016 Vijay Mahrra
 * @license GPLv3 (http://www.gnu.org/licenses/gpl-3.0.html)
 */
class Users
{
    /**
     *
     *
     * @param \Base $f3
     * @param array $params
     * @return void

Should the return type not be string|null?

     */
    public function profile(\Base $f3, array $params = [])
    {
        // get asset table entry
        $asset = new Mappers\Assets;
        $asset->load(['users_uuid = ? AND ' . $asset->quotekey('key') . ' = ?', $params['uuid'], $params['key']]);
        if (null === $asset->uuid) {
            return $f3->status(404);
        }

        // get image dimensions
        $max    = $f3->get('assets.image.max');
        $height = abs((int) $f3->get('REQUEST.height'));
        $width  = abs((int) $f3->get('REQUEST.width'));

        if (empty($height) || empty($width)) {
            // resize on longest side
            if ($height > $width) {
                $width = $height;
            } elseif ($width > $height) {
                $height = $width;
            } else {
                // use default height/width if missing
                $height = $f3->get('assets.image.default.height');
                $width  = $f3->get('assets.image.default.width');
            }
        } elseif ($width > $max['width'] || $height > $max['height']) {
            // make sure maximum width/height not exceeded
            $height = $height > $max['height'] ? $max['height'] : $height;
            $width  = $width > $max['width'] ? $max['width'] : $width;
        }

        // load user mapper
        $usersMapper = new Mappers\Users;
        $usersMapper->load($params['uuid']);

        // work out filename
        $hash     = $f3->hash($asset); // generate unique hash for asset

$hash is not used, you could remove the assignment.

        $filename = 'profile_' . $width . 'x' . $height . '.jpg';

        // return the url if exists
        $url      = $usersMapper->profileImageUrl($filename);
        if (false !== $url) {
            return $f3->reroute($url);
        }

        // 404 if the original asset file does not exist
        if (!file_exists($asset->filename)) {
            return $f3->status(404);
        }

        // create new resized file
        $img      = new \Image($asset->filename);
        $img->resize($width, $height);
        if (!$f3->write($usersMapper->profileImageFilePath($filename), $img->dump('jpeg', $f3->get('assets.image.default.quality.jpg')))) {

The expression $f3->write($usersMapper->profileImageFilePath($filename), $img->dump('jpeg', $f3->get('assets.image.default.quality.jpg'))) of type integer|false is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

            return $f3->status(404);
        }

        // serve the generated image via the web
        return $f3->reroute($url);
    }
}