These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | namespace ViewComponents\Eloquent\Processor; |
||
4 | |||
5 | use Illuminate\Database\Eloquent\Builder; |
||
6 | use ViewComponents\ViewComponents\Data\Operation\OperationInterface; |
||
7 | use ViewComponents\ViewComponents\Data\Operation\PaginateOperation; |
||
8 | use ViewComponents\ViewComponents\Data\Processor\AbstractPaginateProcessor; |
||
9 | |||
10 | class PaginateProcessor extends AbstractPaginateProcessor |
||
11 | { |
||
12 | /** |
||
13 | * @param Builder $src |
||
14 | * @param OperationInterface|PaginateOperation $operation |
||
15 | * @return mixed |
||
16 | */ |
||
17 | public function process($src, OperationInterface $operation) |
||
18 | { |
||
19 | |||
20 | $src->getQuery() |
||
21 | ->limit($operation->getPageSize()) |
||
0 ignored issues
–
show
|
|||
22 | ->offset($this->getOffset($operation)); |
||
0 ignored issues
–
show
$operation of type object<ViewComponents\Vi...ion\OperationInterface> is not a sub-type of object<ViewComponents\Vi...tion\PaginateOperation> . It seems like you assume a concrete implementation of the interface ViewComponents\ViewCompo...tion\OperationInterface to be always present.
This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.
Loading history...
|
|||
23 | return $src; |
||
24 | } |
||
25 | } |
||
26 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: