TeamProvider::getNbPostDay() - Code Metrics - Inspection of "Feat: Add CoreProviderInterface" - video-games-records/dwh-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (21f7ca)

by BENARD

created 2023-05-29 17:47 UTC

TeamProvider::getNbPostDay() A

↳ Parent: TeamProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	17
nc	2
nop	2
dl	0
loc	23
rs	9.7
c	1
b	0
f	0

<?php

namespace VideoGamesRecords\DwhBundle\DataProvider\Core;

use DateTime;

class TeamProvider extends AbstractTablePlayerProvider
{
    /**
     * @return array
     */
    public function getData(): array
    {
        $query = $this->em->createQuery(
            "
            SELECT t.id,
                   t.pointChart,
                   t.pointBadge,
                   t.chartRank0,
                   t.chartRank1,
                   t.chartRank2,
                   t.chartRank3,
                   t.rankPointChart,
                   t.rankMedal,
                   t.rankBadge,
                   t.rankCup,
                   t.gameRank0,
                   t.gameRank1,
                   t.gameRank2,
                   t.gameRank3,
                   t.nbMasterBadge,
                   t.pointGame,
                   t.rankPointGame                  
            FROM VideoGamesRecords\CoreBundle\Entity\Team t"
        );
        return $query->getResult();

    }

    /**
     * @param DateTime $date1
     * @param DateTime $date2
     * @return array
     */
    public function getNbPostDay(DateTime $date1, DateTime $date2): array
    {
        $query = $this->em->createQuery(
            "
            SELECT
                 t.id,
                 COUNT(pc.id) as nb
            FROM VideoGamesRecords\CoreBundle\Entity\PlayerChart pc
            JOIN pc.player p
            JOIN p.team t
            WHERE pc.lastUpdate BETWEEN :date1 AND :date2
            GROUP BY t.id"
        );

        $query->setParameter('date1', $date1);
        $query->setParameter('date2', $date2);
        $result = $query->getResult();

        $data = array();
        foreach ($result as $row) {
            $data[$row['id']] = $row['nb'];
        }
        return $data;
    }
}



1			<?php
2
3			namespace VideoGamesRecords\DwhBundle\DataProvider\Core;
4
5			use DateTime;
6
7			class TeamProvider extends AbstractTablePlayerProvider
8			{
9			/**
10			* @return array
11			*/
12			public function getData(): array
13			{
14			$query = $this->em->createQuery(
15			"
16			SELECT t.id,
17			t.pointChart,
18			t.pointBadge,
19			t.chartRank0,
20			t.chartRank1,
21			t.chartRank2,
22			t.chartRank3,
23			t.rankPointChart,
24			t.rankMedal,
25			t.rankBadge,
26			t.rankCup,
27			t.gameRank0,
28			t.gameRank1,
29			t.gameRank2,
30			t.gameRank3,
31			t.nbMasterBadge,
32			t.pointGame,
33			t.rankPointGame
34			FROM VideoGamesRecords\CoreBundle\Entity\Team t"
35			);
36			return $query->getResult();
			0 ignored issues – show Bug Best Practice introduced 2023-05-29 17:51 UTC by Report Bug Copy Issue Report The expression `return $query->getResult()` could return the type `integer` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
37			}
38
39			/**
40			* @param DateTime $date1
41			* @param DateTime $date2
42			* @return array
43			*/
44			public function getNbPostDay(DateTime $date1, DateTime $date2): array
45			{
46			$query = $this->em->createQuery(
47			"
48			SELECT
49			t.id,
50			COUNT(pc.id) as nb
51			FROM VideoGamesRecords\CoreBundle\Entity\PlayerChart pc
52			JOIN pc.player p
53			JOIN p.team t
54			WHERE pc.lastUpdate BETWEEN :date1 AND :date2
55			GROUP BY t.id"
56			);
57
58			$query->setParameter('date1', $date1);
59			$query->setParameter('date2', $date2);
60			$result = $query->getResult();
61
62			$data = array();
63			foreach ($result as $row) {
64			$data[$row['id']] = $row['nb'];
65			}
66			return $data;
67			}
68			}
69
70

video-games-records / dwh-bundle

Branch — develop (21f7ca)

TeamProvider::getNbPostDay() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like