PlayerProvider::getDataRank() - Code Metrics - Inspection of "Feat: Add CoreProviderInterface" - video-games-records/dwh-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (21f7ca)

by BENARD

created 2023-05-29 17:47 UTC

PlayerProvider::getDataRank() A

↳ Parent: PlayerProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
nc	2
nop	0
dl	0
loc	18
rs	10
c	1
b	0
f	0

<?php

namespace VideoGamesRecords\DwhBundle\DataProvider\Core;

use DateTime;

class PlayerProvider extends AbstractTablePlayerProvider
{
    /**
     * @return array
     */
    public function getData(): array
    {
        $query = $this->em->createQuery(
            "
            SELECT p.id,
                   p.chartRank0,
                   p.chartRank1,
                   p.chartRank2,
                   p.chartRank3,
                   p.pointChart,
                   p.rankPointChart,
                   p.rankMedal,
                   p.nbChart,
                   p.pointGame,
                   p.rankPointGame                   
            FROM VideoGamesRecords\CoreBundle\Entity\Player p
            WHERE p.id <> 0"
        );
        return $query->getResult();

    }

    /**
     * @return array
     */
    public function getDataRank(): array
    {
        $query = $this->em->createQuery("
                    SELECT
                         p.id,
                         CASE WHEN pc.rank > 29 THEN 30 ELSE pc.rank END AS rank,
                         COUNT(pc.id) as nb
                    FROM VideoGamesRecords\CoreBundle\Entity\PlayerChart pc
                    JOIN pc.player p
                    WHERE pc.rank > 3            
                    GROUP BY p.id, rank");

        $result = $query->getResult();
        $data = array();
        foreach ($result as $row) {
            $data[$row['id']][$row['rank']] = $row['nb'];
        }
        return $data;
    }

    /**
     * @param DateTime $date1
     * @param DateTime $date2
     * @return array
     */
    public function getNbPostDay(DateTime $date1, DateTime $date2): array
    {
        $query = $this->em->createQuery("
            SELECT
                 p.id,
                 COUNT(pc.chart) as nb
            FROM VideoGamesRecords\CoreBundle\Entity\PlayerChart pc
            JOIN pc.player p
            WHERE pc.lastUpdate BETWEEN :date1 AND :date2
            GROUP BY p.id");


        $query->setParameter('date1', $date1);
        $query->setParameter('date2', $date2);
        $result = $query->getResult();

        $data = array();
        foreach ($result as $row) {
            $data[$row['id']] = $row['nb'];
        }
        return $data;
    }
}



1			<?php
2
3			namespace VideoGamesRecords\DwhBundle\DataProvider\Core;
4
5			use DateTime;
6
7			class PlayerProvider extends AbstractTablePlayerProvider
8			{
9			/**
10			* @return array
11			*/
12			public function getData(): array
13			{
14			$query = $this->em->createQuery(
15			"
16			SELECT p.id,
17			p.chartRank0,
18			p.chartRank1,
19			p.chartRank2,
20			p.chartRank3,
21			p.pointChart,
22			p.rankPointChart,
23			p.rankMedal,
24			p.nbChart,
25			p.pointGame,
26			p.rankPointGame
27			FROM VideoGamesRecords\CoreBundle\Entity\Player p
28			WHERE p.id <> 0"
29			);
30			return $query->getResult();
			0 ignored issues – show Bug Best Practice introduced 2023-05-29 17:51 UTC by Report Bug Copy Issue Report The expression `return $query->getResult()` could return the type `integer` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
31			}
32
33			/**
34			* @return array
35			*/
36			public function getDataRank(): array
37			{
38			$query = $this->em->createQuery("
39			SELECT
40			p.id,
41			CASE WHEN pc.rank > 29 THEN 30 ELSE pc.rank END AS rank,
42			COUNT(pc.id) as nb
43			FROM VideoGamesRecords\CoreBundle\Entity\PlayerChart pc
44			JOIN pc.player p
45			WHERE pc.rank > 3
46			GROUP BY p.id, rank");
47
48			$result = $query->getResult();
49			$data = array();
50			foreach ($result as $row) {
51			$data[$row['id']][$row['rank']] = $row['nb'];
52			}
53			return $data;
54			}
55
56			/**
57			* @param DateTime $date1
58			* @param DateTime $date2
59			* @return array
60			*/
61			public function getNbPostDay(DateTime $date1, DateTime $date2): array
62			{
63			$query = $this->em->createQuery("
64			SELECT
65			p.id,
66			COUNT(pc.chart) as nb
67			FROM VideoGamesRecords\CoreBundle\Entity\PlayerChart pc
68			JOIN pc.player p
69			WHERE pc.lastUpdate BETWEEN :date1 AND :date2
70			GROUP BY p.id");
71
72
73			$query->setParameter('date1', $date1);
74			$query->setParameter('date2', $date2);
75			$result = $query->getResult();
76
77			$data = array();
78			foreach ($result as $row) {
79			$data[$row['id']] = $row['nb'];
80			}
81			return $data;
82			}
83			}
84
85

video-games-records / dwh-bundle

Branch — develop (21f7ca)

PlayerProvider::getDataRank() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like