PlayerRankingQuery::getRankingPoints() - Code Metrics - Inspection of "Feat: Clean code" - video-games-records/core-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 915dc4...d2c44b )

by BENARD

created 2023-06-11 20:03 UTC

PlayerRankingQuery::getRankingPoints() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	0

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	0
dl	0
loc	2
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace VideoGamesRecords\CoreBundle\DataProvider\Ranking\Player;

use Doctrine\ORM\Exception\ORMException;
use VideoGamesRecords\CoreBundle\DataProvider\Ranking\AbstractRankingQuery;

class PlayerRankingQuery extends AbstractRankingQuery
{
    /**
     * @param array $options
     * @return array
     * @throws ORMException
     */
    public function getRankingPointChart(array $options = []): array
    {
        return $this->getRanking('rankPointChart', $options);
    }

    /**
     * @param array $options
     * @return array
     * @throws ORMException
     */
    public function getRankingPointGame(array $options = []): array
    {
        return $this->getRanking('rankPointGame', $options);
    }

    /**
     * @param array $options
     * @return array
     * @throws ORMException
     */
    public function getRankingMedals(array $options = []): array
    {
        return $this->getRanking('rankMedal', $options);
    }

    /**
     * @param array $options
     * @return array
     * @throws ORMException
     */
    public function getRankingBadge(array $options = []): array
    {
        return $this->getRanking('rankBadge', $options);
    }

    /**
     * @param array $options
     * @return array
     * @throws ORMException
     */
    public function getRankingCup(array $options = []): array
    {
        return $this->getRanking('rankCup', $options);
    }

    /**
     * @param array $options
     * @return array
     * @throws ORMException
     */
    public function getRankingProof(array $options = []): array
    {
        return $this->getRanking('rankProof', $options);
    }

    /**
     * @param string $column
     * @param array  $options
     * @return array
     * @throws ORMException
     */
    private function getRanking(string $column = 'rankPointChart', array $options = []): array
    {
        $maxRank = $options['maxRank'] ?? 100;
        $limit = $options['limit'] ?? null;
        $player = $this->getPlayer();
        $team = !empty($options['idTeam']) ? $this->em->getReference('VideoGamesRecords\CoreBundle\Entity\Team', $options['idTeam']) : null;

        $query = $this->em->createQueryBuilder()
            ->select('p')
            ->from('VideoGamesRecords\CoreBundle\Entity\Player', 'p')
            ->leftJoin('p.team', 't')
            ->addSelect('t')
            ->leftJoin('p.country', 'c')
            ->addSelect('c')
            ->leftJoin('c.translations', 'trans')
            ->addSelect('trans')
            ->where("p.$column != 0")
            ->orderBy("p.$column");

        if ($team !== null) {
            $query->andWhere('(p.team = :team)')
                ->setParameter('team', $team);
        } elseif (($maxRank !== null) && ($player !== null)) {
            $query->andWhere("(p.$column <= :maxRank OR p = :player)")
                ->setParameter('maxRank', $maxRank)
                ->setParameter('player', $player);
        } else {
            $query->andWhere("p.$column <= :maxRank")
                ->setParameter('maxRank', $maxRank);
        }

        if (null !== $limit) {
            $query->setMaxResults($limit);
        }

        return $query->getQuery()->getResult();

    }
}


1			<?php
2
3			namespace VideoGamesRecords\CoreBundle\DataProvider\Ranking\Player;
4
5			use Doctrine\ORM\Exception\ORMException;
6			use VideoGamesRecords\CoreBundle\DataProvider\Ranking\AbstractRankingQuery;
7
8			class PlayerRankingQuery extends AbstractRankingQuery
9			{
10			/**
11			* @param array $options
12			* @return array
13			* @throws ORMException
14			*/
15			public function getRankingPointChart(array $options = []): array
16			{
17			return $this->getRanking('rankPointChart', $options);
18			}
19
20			/**
21			* @param array $options
22			* @return array
23			* @throws ORMException
24			*/
25			public function getRankingPointGame(array $options = []): array
26			{
27			return $this->getRanking('rankPointGame', $options);
28			}
29
30			/**
31			* @param array $options
32			* @return array
33			* @throws ORMException
34			*/
35			public function getRankingMedals(array $options = []): array
36			{
37			return $this->getRanking('rankMedal', $options);
38			}
39
40			/**
41			* @param array $options
42			* @return array
43			* @throws ORMException
44			*/
45			public function getRankingBadge(array $options = []): array
46			{
47			return $this->getRanking('rankBadge', $options);
48			}
49
50			/**
51			* @param array $options
52			* @return array
53			* @throws ORMException
54			*/
55			public function getRankingCup(array $options = []): array
56			{
57			return $this->getRanking('rankCup', $options);
58			}
59
60			/**
61			* @param array $options
62			* @return array
63			* @throws ORMException
64			*/
65			public function getRankingProof(array $options = []): array
66			{
67			return $this->getRanking('rankProof', $options);
68			}
69
70			/**
71			* @param string $column
72			* @param array $options
73			* @return array
74			* @throws ORMException
75			*/
76			private function getRanking(string $column = 'rankPointChart', array $options = []): array
77			{
78			$maxRank = $options['maxRank'] ?? 100;
79			$limit = $options['limit'] ?? null;
80			$player = $this->getPlayer();
81			$team = !empty($options['idTeam']) ? $this->em->getReference('VideoGamesRecords\CoreBundle\Entity\Team', $options['idTeam']) : null;
82
83			$query = $this->em->createQueryBuilder()
84			->select('p')
85			->from('VideoGamesRecords\CoreBundle\Entity\Player', 'p')
86			->leftJoin('p.team', 't')
87			->addSelect('t')
88			->leftJoin('p.country', 'c')
89			->addSelect('c')
90			->leftJoin('c.translations', 'trans')
91			->addSelect('trans')
92			->where("p.$column != 0")
93			->orderBy("p.$column");
94
95			if ($team !== null) {
96			$query->andWhere('(p.team = :team)')
97			->setParameter('team', $team);
98			} elseif (($maxRank !== null) && ($player !== null)) {
99			$query->andWhere("(p.$column <= :maxRank OR p = :player)")
100			->setParameter('maxRank', $maxRank)
101			->setParameter('player', $player);
102			} else {
103			$query->andWhere("p.$column <= :maxRank")
104			->setParameter('maxRank', $maxRank);
105			}
106
107			if (null !== $limit) {
108			$query->setMaxResults($limit);
109			}
110
111			return $query->getQuery()->getResult();
			0 ignored issues – show Bug Best Practice introduced 2022-11-12 10:13 UTC by Report Bug Copy Issue Report The expression `return $query->getQuery()->getResult()` could return the type `integer` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
112			}
113			}
114

video-games-records / core-bundle

Push — develop ( 915dc4...d2c44b )

PlayerRankingQuery::getRankingPoints() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like