ChartController::playerRanking() - Code Metrics - Inspection of "Add api for chart and submit scores" - video-games-records/core-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#64)

unknown

created 2018-09-25 19:31 UTC

ChartController::playerRanking() A

↳ Parent: ChartController

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	2
dl	0
loc	9
rs	10
c	0
b	0
f	0

<?php

namespace VideoGamesRecords\CoreBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use VideoGamesRecords\CoreBundle\Entity\Chart;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\JsonResponse;

/**
 * Class ChartController
 */
class ChartController extends Controller
{


    /**
     * @param Chart    $chart
     * @param Request $request
     * @return mixed
     */
    public function playerRanking(Chart $chart, Request $request)
    {
        $maxRank = $request->query->get('maxRank', 20);
        $idPlayer = $request->query->get('idPlayer', null);

        $ranking = $this->getDoctrine()
            ->getRepository('VideoGamesRecordsCoreBundle:PlayerChart')
            ->getRanking($chart, null, $maxRank);

        return $ranking;
    }
}


1			<?php
2
3			namespace VideoGamesRecords\CoreBundle\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
6			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7			use VideoGamesRecords\CoreBundle\Entity\Chart;
8			use Symfony\Component\HttpFoundation\Request;
9			use Symfony\Component\HttpFoundation\JsonResponse;
10
11			/**
12			* Class ChartController
13			*/
14			class ChartController extends Controller
15			{
16
17
18			/**
19			* @param Chart $chart
20			* @param Request $request
21			* @return mixed
22			*/
23			public function playerRanking(Chart $chart, Request $request)
24			{
25			$maxRank = $request->query->get('maxRank', 20);
26			$idPlayer = $request->query->get('idPlayer', null);
			0 ignored issues – show Unused Code introduced 2018-09-25 18:53 UTC by Report Bug Copy Issue Report The assignment to `$idPlayer` is dead and can be removed. Loading history...
27			$ranking = $this->getDoctrine()
28			->getRepository('VideoGamesRecordsCoreBundle:PlayerChart')
29			->getRanking($chart, null, $maxRank);
30
31			return $ranking;
32			}
33			}
34

video-games-records / core-bundle

Pull Request — develop (#64)

ChartController::playerRanking() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like