VideoGamesRecords\CoreBundle\DataProvider\Ranking\Player\PlayerCountryRankingQuery

Complexity

Total Complexity

4

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getRankingMedals()	0	3	1
A	getRankingPoints()	0	24	3

<?php

namespace VideoGamesRecords\CoreBundle\DataProvider\Ranking\Player;

use VideoGamesRecords\CoreBundle\DataProvider\Ranking\AbstractRankingQuery;
use VideoGamesRecords\CoreBundle\Contracts\Ranking\RankingQueryInterface;

class PlayerCountryRankingQuery extends AbstractRankingQuery implements RankingQueryInterface
{
    /**
     * @param int|null $id
     * @param array    $options
     * @return array
     */
    public function getRankingPoints(int $id = null, array $options = []): array
    {
        $country = $this->em->getRepository('VideoGamesRecords\CoreBundle\Entity\Country')->find($id);
        if (null === $country) {
            return [];
        }

        $maxRank = $options['maxRank'] ?? null;

        $query = $this->em->createQueryBuilder('p')

The call to Doctrine\ORM\EntityManagerInterface::createQueryBuilder() has too many arguments starting with 'p'.

            ->select('p')
            ->from('VideoGamesRecords\CoreBundle\Entity\Player', 'p')
            ->where('(p.country = :country)')
            ->setParameter('country', $country)
            ->orderBy('p.rankCountry');

        if ($maxRank !== null) {
            $query->andWhere('p.rankCountry <= :maxRank')
                ->setParameter('maxRank', $maxRank);
        } else {
            $query->setMaxResults($maxRank);
        }

        return $query->getQuery()->getResult();

The expression return $query->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param int|null $id
     * @param array $options
     * @return array
     */
    public function getRankingMedals(int $id = null, array $options = []): array
    {
        return array();
    }
}