IgdbGameMatchingCommand::execute() - Code Metrics - Inspection of "Add command matching igdb games" - video-games-records/core-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( 2488e6...f76d21 )

by BENARD

created 2025-10-21 17:49 UTC

IgdbGameMatchingCommand::execute() F

↳ Parent: IgdbGameMatchingCommand

Complexity

Conditions	17
Paths	2256

Size

Total Lines	135
Code Lines	90

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	17
eloc	90
nc	2256
nop	2
dl	0
loc	135
rs	1.0581
c	1
b	0
f	0

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace VideoGamesRecords\CoreBundle\Command;

use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use VideoGamesRecords\CoreBundle\Entity\Game;
use VideoGamesRecords\CoreBundle\Domain\Igdb\Service\GameMatchingService;

#[AsCommand(
    name: 'vgr:igdb:match-games',
    description: 'Automatically match Core Bundle games with IGDB games'
)]
class IgdbGameMatchingCommand extends Command
{
    public function __construct(
        private readonly EntityManagerInterface $entityManager,
        private readonly GameMatchingService $gameMatchingService
    ) {
        parent::__construct();
    }

    protected function configure(): void
    {
        $this
            ->addOption(
                'dry-run',
                'd',
                InputOption::VALUE_NONE,
                'Show what would be matched without actually updating the database'
            )
            ->addOption(
                'game-id',
                'g',
                InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY,
                'Process only specific game IDs (can be used multiple times)'
            )
            ->addOption(
                'limit',
                'l',
                InputOption::VALUE_OPTIONAL,
                'Maximum number of games to process',
                100
            )
            ->addOption(
                'batch-size',
                'b',
                InputOption::VALUE_OPTIONAL,
                'Number of games to process in each batch before flushing',
                10
            )
            ->addOption(
                'without-igdb-only',
                'w',
                InputOption::VALUE_NONE,
                'Process only games that do not have an IGDB association yet'
            );
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $io = new SymfonyStyle($input, $output);
        $dryRun = $input->getOption('dry-run');
        $gameIds = $input->getOption('game-id');
        $limit = (int) $input->getOption('limit');
        $batchSize = (int) $input->getOption('batch-size');
        $withoutIgdbOnly = $input->getOption('without-igdb-only');

        $io->title('IGDB Game Matching Service');

        if ($dryRun) {
            $io->note('Running in DRY-RUN mode - no changes will be made to the database');
        }

        try {
            $games = $this->getGamesToProcess($gameIds, $withoutIgdbOnly, $limit);
            $totalGames = count($games);

            if ($totalGames === 0) {
                $io->success('No games to process.');
                return Command::SUCCESS;
            }

            $io->info(sprintf('Found %d games to process', $totalGames));

            if (!$dryRun) {
                $statistics = $this->gameMatchingService->getMatchingStatistics();
                $io->section('Current Statistics');
                $io->table(
                    ['Metric', 'Value'],
                    [
                        ['Total Games', $statistics['total_games']],
                        ['Games with IGDB Association', $statistics['games_with_igdb_association']],
                        ['Games without IGDB Association', $statistics['games_without_igdb_association']],
                        ['Matching Percentage', $statistics['matching_percentage'] . '%']
                    ]
                );
            }

            $io->progressStart($totalGames);

            $processedCount = 0;
            $matchedCount = 0;
            $errorCount = 0;
            $skippedCount = 0;

            foreach (array_chunk($games, $batchSize) as $gameBatch) {
                foreach ($gameBatch as $game) {
                    try {
                        if ($game->getIgdbGame() !== null && $withoutIgdbOnly) {
                            $skippedCount++;
                            $io->progressAdvance();
                            continue;
                        }

                        if ($dryRun) {
                            $io->text(sprintf(
                                'Would process: %s (ID: %d) - Platforms: %s',
                                $game->getLibGameEn(),
                                $game->getId(),
                                $this->getPlatformNames($game)
                            ));
                            $processedCount++;
                        } else {
                            $igdbGame = $this->gameMatchingService->findAndAssociateIgdbGame($game);

                            if ($igdbGame !== null) {
                                $matchedCount++;
                                $io->text(sprintf(
                                    'Matched: %s → IGDB Game ID: %d',
                                    $game->getLibGameEn(),
                                    $igdbGame->getId()
                                ));
                            }
                            $processedCount++;
                        }
                    } catch (\Exception $e) {
                        $errorCount++;
                        $io->error(sprintf(
                            'Error processing game %s (ID: %d): %s',
                            $game->getLibGameEn(),
                            $game->getId(),
                            $e->getMessage()
                        ));
                    }

                    $io->progressAdvance();
                }

                if (!$dryRun) {
                    $this->entityManager->clear();
                }
            }

            $io->progressFinish();

            $io->section('Processing Summary');
            $resultTable = [
                ['Total Games Processed', $processedCount],
                ['Successfully Matched', $matchedCount],
                ['Errors', $errorCount],
                ['Skipped (already matched)', $skippedCount]
            ];

            if ($dryRun) {
                $resultTable[] = ['⚠️  DRY RUN MODE', 'No changes made'];
            }

            $io->table(['Metric', 'Count'], $resultTable);

            if (!$dryRun && $matchedCount > 0) {
                $io->section('Updated Statistics');
                $finalStatistics = $this->gameMatchingService->getMatchingStatistics();
                $io->table(
                    ['Metric', 'Value'],
                    [
                        ['Total Games', $finalStatistics['total_games']],
                        ['Games with IGDB Association', $finalStatistics['games_with_igdb_association']],
                        ['Games without IGDB Association', $finalStatistics['games_without_igdb_association']],
                        ['Matching Percentage', $finalStatistics['matching_percentage'] . '%']
                    ]
                );
            }

            if ($errorCount > 0) {
                $io->warning(sprintf('%d errors occurred during processing. Check the logs for details.', $errorCount));
                return Command::FAILURE;
            }

            $io->success('Game matching completed successfully!');
            return Command::SUCCESS;
        } catch (\Exception $e) {
            $io->error('Command failed: ' . $e->getMessage());
            return Command::FAILURE;
        }
    }

    private function getGamesToProcess(?array $gameIds, bool $withoutIgdbOnly, int $limit): array
    {
        $queryBuilder = $this->entityManager->getRepository(Game::class)->createQueryBuilder('g');

        if (!empty($gameIds)) {
            $queryBuilder->where('g.id IN (:gameIds)')
                        ->setParameter('gameIds', array_map('intval', $gameIds));
        }

        if ($withoutIgdbOnly) {
            $queryBuilder->andWhere('g.igdbGame IS NULL');
        }

        $queryBuilder->setMaxResults($limit);

        return $queryBuilder->getQuery()->getResult();
    }

    private function getPlatformNames(Game $game): string
    {
        $platformNames = [];
        foreach ($game->getPlatforms() as $platform) {
            $platformNames[] = $platform->getLibPlatform();
        }
        return implode(', ', $platformNames);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace VideoGamesRecords\CoreBundle\Command;
6
7			use Doctrine\ORM\EntityManagerInterface;
8			use Symfony\Component\Console\Attribute\AsCommand;
9			use Symfony\Component\Console\Command\Command;
10			use Symfony\Component\Console\Input\InputInterface;
11			use Symfony\Component\Console\Input\InputOption;
12			use Symfony\Component\Console\Output\OutputInterface;
13			use Symfony\Component\Console\Style\SymfonyStyle;
14			use VideoGamesRecords\CoreBundle\Entity\Game;
15			use VideoGamesRecords\CoreBundle\Domain\Igdb\Service\GameMatchingService;
16
17			#[AsCommand(
18			name: 'vgr:igdb:match-games',
19			description: 'Automatically match Core Bundle games with IGDB games'
20			)]
21			class IgdbGameMatchingCommand extends Command
22			{
23			public function __construct(
24			private readonly EntityManagerInterface $entityManager,
25			private readonly GameMatchingService $gameMatchingService
26			) {
27			parent::__construct();
28			}
29
30			protected function configure(): void
31			{
32			$this
33			->addOption(
34			'dry-run',
35			'd',
36			InputOption::VALUE_NONE,
37			'Show what would be matched without actually updating the database'
38			)
39			->addOption(
40			'game-id',
41			'g',
42			InputOption::VALUE_OPTIONAL \| InputOption::VALUE_IS_ARRAY,
43			'Process only specific game IDs (can be used multiple times)'
44			)
45			->addOption(
46			'limit',
47			'l',
48			InputOption::VALUE_OPTIONAL,
49			'Maximum number of games to process',
50			100
51			)
52			->addOption(
53			'batch-size',
54			'b',
55			InputOption::VALUE_OPTIONAL,
56			'Number of games to process in each batch before flushing',
57			10
58			)
59			->addOption(
60			'without-igdb-only',
61			'w',
62			InputOption::VALUE_NONE,
63			'Process only games that do not have an IGDB association yet'
64			);
65			}
66
67			protected function execute(InputInterface $input, OutputInterface $output): int
68			{
69			$io = new SymfonyStyle($input, $output);
70			$dryRun = $input->getOption('dry-run');
71			$gameIds = $input->getOption('game-id');
72			$limit = (int) $input->getOption('limit');
73			$batchSize = (int) $input->getOption('batch-size');
74			$withoutIgdbOnly = $input->getOption('without-igdb-only');
75
76			$io->title('IGDB Game Matching Service');
77
78			if ($dryRun) {
79			$io->note('Running in DRY-RUN mode - no changes will be made to the database');
80			}
81
82			try {
83			$games = $this->getGamesToProcess($gameIds, $withoutIgdbOnly, $limit);
84			$totalGames = count($games);
85
86			if ($totalGames === 0) {
87			$io->success('No games to process.');
88			return Command::SUCCESS;
89			}
90
91			$io->info(sprintf('Found %d games to process', $totalGames));
92
93			if (!$dryRun) {
94			$statistics = $this->gameMatchingService->getMatchingStatistics();
95			$io->section('Current Statistics');
96			$io->table(
97			['Metric', 'Value'],
98			[
99			['Total Games', $statistics['total_games']],
100			['Games with IGDB Association', $statistics['games_with_igdb_association']],
101			['Games without IGDB Association', $statistics['games_without_igdb_association']],
102			['Matching Percentage', $statistics['matching_percentage'] . '%']
103			]
104			);
105			}
106
107			$io->progressStart($totalGames);
108
109			$processedCount = 0;
110			$matchedCount = 0;
111			$errorCount = 0;
112			$skippedCount = 0;
113
114			foreach (array_chunk($games, $batchSize) as $gameBatch) {
115			foreach ($gameBatch as $game) {
116			try {
117			if ($game->getIgdbGame() !== null && $withoutIgdbOnly) {
118			$skippedCount++;
119			$io->progressAdvance();
120			continue;
121			}
122
123			if ($dryRun) {
124			$io->text(sprintf(
125			'Would process: %s (ID: %d) - Platforms: %s',
126			$game->getLibGameEn(),
127			$game->getId(),
128			$this->getPlatformNames($game)
129			));
130			$processedCount++;
131			} else {
132			$igdbGame = $this->gameMatchingService->findAndAssociateIgdbGame($game);
133
134			if ($igdbGame !== null) {
135			$matchedCount++;
136			$io->text(sprintf(
137			'Matched: %s → IGDB Game ID: %d',
138			$game->getLibGameEn(),
139			$igdbGame->getId()
140			));
141			}
142			$processedCount++;
143			}
144			} catch (\Exception $e) {
145			$errorCount++;
146			$io->error(sprintf(
147			'Error processing game %s (ID: %d): %s',
148			$game->getLibGameEn(),
149			$game->getId(),
150			$e->getMessage()
151			));
152			}
153
154			$io->progressAdvance();
155			}
156
157			if (!$dryRun) {
158			$this->entityManager->clear();
159			}
160			}
161
162			$io->progressFinish();
163
164			$io->section('Processing Summary');
165			$resultTable = [
166			['Total Games Processed', $processedCount],
167			['Successfully Matched', $matchedCount],
168			['Errors', $errorCount],
169			['Skipped (already matched)', $skippedCount]
170			];
171
172			if ($dryRun) {
173			$resultTable[] = ['⚠️ DRY RUN MODE', 'No changes made'];
174			}
175
176			$io->table(['Metric', 'Count'], $resultTable);
177
178			if (!$dryRun && $matchedCount > 0) {
179			$io->section('Updated Statistics');
180			$finalStatistics = $this->gameMatchingService->getMatchingStatistics();
181			$io->table(
182			['Metric', 'Value'],
183			[
184			['Total Games', $finalStatistics['total_games']],
185			['Games with IGDB Association', $finalStatistics['games_with_igdb_association']],
186			['Games without IGDB Association', $finalStatistics['games_without_igdb_association']],
187			['Matching Percentage', $finalStatistics['matching_percentage'] . '%']
188			]
189			);
190			}
191
192			if ($errorCount > 0) {
193			$io->warning(sprintf('%d errors occurred during processing. Check the logs for details.', $errorCount));
194			return Command::FAILURE;
195			}
196
197			$io->success('Game matching completed successfully!');
198			return Command::SUCCESS;
199			} catch (\Exception $e) {
200			$io->error('Command failed: ' . $e->getMessage());
201			return Command::FAILURE;
202			}
203			}
204
205			private function getGamesToProcess(?array $gameIds, bool $withoutIgdbOnly, int $limit): array
206			{
207			$queryBuilder = $this->entityManager->getRepository(Game::class)->createQueryBuilder('g');
208
209			if (!empty($gameIds)) {
210			$queryBuilder->where('g.id IN (:gameIds)')
211			->setParameter('gameIds', array_map('intval', $gameIds));
212			}
213
214			if ($withoutIgdbOnly) {
215			$queryBuilder->andWhere('g.igdbGame IS NULL');
216			}
217
218			$queryBuilder->setMaxResults($limit);
219
220			return $queryBuilder->getQuery()->getResult();
221			}
222
223			private function getPlatformNames(Game $game): string
224			{
225			$platformNames = [];
226			foreach ($game->getPlatforms() as $platform) {
227			$platformNames[] = $platform->getLibPlatform();
228			}
229			return implode(', ', $platformNames);
230			}
231			}
232

video-games-records / core-bundle

Push — develop ( 2488e6...f76d21 )

IgdbGameMatchingCommand::execute() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like