HtmlTopTrait::diff() - Code Metrics - Inspection of "Refactor: Move top article from dwh bundle" - video-games-records/core-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (38ee07)

by BENARD

created 2022-11-17 14:09 UTC

HtmlTopTrait::diff() A

↳ Parent: HtmlTopTrait

Complexity

Conditions	5
Paths	5

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	13
c	1
b	0
f	0
dl	0
loc	18
rs	9.5222
cc	5
nc	5
nop	2

<?php

namespace VideoGamesRecords\CoreBundle\Service\Article;

trait HtmlTopTrait
{
    use HtmlTopPlayerTrait;
    use HtmlTopGameTrait;

    /**
     * @param $row
     * @param $nbGame
     * @return string
     */
    private function diff($row, $nbGame): string
    {
        if ($row['oldRank'] != null) {
            if ($row['rank'] < $row['oldRank']) {
                if ($row['oldRank'] > $nbGame) {
                    $col = '<span class="article-top--new"><abbr title="New">N</abbr></span>';
                } else {
                    $col = sprintf('<span class="article-top--up">+%d <span class="screen-reader-text">position</span></span>', $row['oldRank'] - $row['rank']);
                }
            } elseif ($row['rank'] > $row['oldRank']) {
                $col = sprintf('<span class="article-top--down">-%d <span class="screen-reader-text">position</span></span>', $row['rank'] - $row['oldRank']);
            } else {
                $col = '<span class="article-top--equal"><abbr title="Same position">=</abbr></span>';
            }
        } else {
            $col = '<span class="article-top--new"><abbr title="New">N</abbr></span>';
        }
        return $col;
    }


    /**
     * @return string
     */
    private function getHtmLine(): string
    {
        return '
            <tr>
                <td>%d</td>
                <td>
		            <a href="%s">%s</a>
	            </td>
	            <td>%s posts</td>
	            <td>
	                %s
	            </td>
	        </tr>';
    }

    /**
     * @return string
     */
    private function getHtmlBottom1(): string
    {
        return '
            <tr>
                <td colspan="2" class="article-top__bottom-left">%d - %d</td>
                <td colspan="2" class="article-top__bottom-right">%d posts</td>
            </tr>';
    }

    /**
     * @return string
     */
    private function getHtmlBottom2(): string
    {
        return '
            <tfooter>
                <tr>
                    <th scope="row" colspan="2" class="article-top__bottom-left">Total</th>
                    <td colspan="2" class="article-top__bottom-right">%d posts</td>
                </tr>
            </tfooter>';
    }
}


1			<?php
2
3			namespace VideoGamesRecords\CoreBundle\Service\Article;
4
5			trait HtmlTopTrait
6			{
7			use HtmlTopPlayerTrait;
8			use HtmlTopGameTrait;
9
10			/**
11			* @param $row
12			* @param $nbGame
13			* @return string
14			*/
15			private function diff($row, $nbGame): string
16			{
17			if ($row['oldRank'] != null) {
18			if ($row['rank'] < $row['oldRank']) {
19			if ($row['oldRank'] > $nbGame) {
20			$col = '<span class="article-top--new"><abbr title="New">N</abbr></span>';
21			} else {
22			$col = sprintf('<span class="article-top--up">+%d <span class="screen-reader-text">position</span></span>', $row['oldRank'] - $row['rank']);
23			}
24			} elseif ($row['rank'] > $row['oldRank']) {
25			$col = sprintf('<span class="article-top--down">-%d <span class="screen-reader-text">position</span></span>', $row['rank'] - $row['oldRank']);
26			} else {
27			$col = '<span class="article-top--equal"><abbr title="Same position">=</abbr></span>';
28			}
29			} else {
30			$col = '<span class="article-top--new"><abbr title="New">N</abbr></span>';
31			}
32			return $col;
33			}
34
35
36			/**
37			* @return string
38			*/
39			private function getHtmLine(): string
40			{
41			return '
42			<tr>
43			<td>%d</td>
44			<td>
45			<a href="%s">%s</a>
46			</td>
47			<td>%s posts</td>
48			<td>
49			%s
50			</td>
51			</tr>';
52			}
53
54			/**
55			* @return string
56			*/
57			private function getHtmlBottom1(): string
58			{
59			return '
60			<tr>
61			<td colspan="2" class="article-top__bottom-left">%d - %d</td>
62			<td colspan="2" class="article-top__bottom-right">%d posts</td>
63			</tr>';
64			}
65
66			/**
67			* @return string
68			*/
69			private function getHtmlBottom2(): string
70			{
71			return '
72			<tfooter>
73			<tr>
74			<th scope="row" colspan="2" class="article-top__bottom-left">Total</th>
75			<td colspan="2" class="article-top__bottom-right">%d posts</td>
76			</tr>
77			</tfooter>';
78			}
79			}
80

video-games-records / core-bundle

Branch — develop (38ee07)

HtmlTopTrait::diff() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like