VideoGamesRecords\CoreBundle\Service\Article\HtmlTopGameTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getHtmlTopGame()	0	57	7

<?php

namespace VideoGamesRecords\CoreBundle\Service\Article;

trait HtmlTopGameTrait
{
    /**
     * @param        $data
     * @param string $locale
     * @return string
     */
    private function getHtmlTopGame($data, string $locale = 'en'): string
    {
        $html = '';

        if (count($data['list']) > 0) {
            $html .= '<div class="article-top article-top__games">';

            for ($i = 0; $i <= 2; $i++) {
                if (array_key_exists($i, $data['list'])) {
                    $html .= sprintf(
                        '<a href="%s"><img src="%s" alt="%s" class="article-top__game" /></a>',
                        '/' . $locale . '/' . $data['list'][$i]['game']->getUrl(),
                        'https://picture.video-games-records.com/game/' . $data['list'][$i]['game']->getPicture(),
                        $data['list'][$i]['game']->getName()
                    );
                }
                if ($i == 0) {
                    $html .= '<br />';
                }
            }

            $html .= '<table class="article-top__table">';
            $html .= '<thead>';
            $html .= '<tr>';
            $html .= '<th scope="col"><abbr title="Rank">#</abbr></th>';
            $html .= '<th scope="col">Game</th>';
            $html .= '<th scope="col">Posts submitted</th>';
            $html .= '<th scope="col">Position change</th>';
            $html .= '</tr>';
            $html .= '</tr>';
            $html .= '<tbody>';

            foreach ($data['list'] as $row) {
                $html .= sprintf(
                    $this->getHtmLine(),

It seems like getHtmLine() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    $row['rank'],
                    '/' . $locale . '/' . $row['game']->getUrl(),
                    $row['game']->getName(),
                    $row['nb'],
                    $this->diff($row, count($data['list']))

It seems like diff() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                );
            }
            if ($data['nbTotalPost'] > $data['nbPostFromList']) {
                $html .= sprintf(
                    $this->getHtmlBottom1(),

It seems like getHtmlBottom1() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    count($data['list']) + 1,
                    $data['nbItem'],
                    $data['nbTotalPost'] - $data['nbPostFromList']
                );
            }
            $html .= sprintf($this->getHtmlBottom2(), $data['nbTotalPost']);

It seems like getHtmlBottom2() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $html .= '</tbody>';
            $html .= '</table>';
            $html .= '</div>';
        }

        return $html;
    }
}