VideoGamesRecords\CoreBundle\Service\Game

Complexity

Total Complexity

23

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	updateFromCsv()	0	44	8
C	addFromCsv()	0	70	14

<?php
namespace VideoGamesRecords\CoreBundle\Service;

use VideoGamesRecords\CoreBundle\Entity\Group;
use VideoGamesRecords\CoreBundle\Entity\Chart;
use VideoGamesRecords\CoreBundle\Entity\ChartLib;

class Game
{
    private $em;
    private $directory;

    public function __construct(\Doctrine\ORM\EntityManager $em, $rootDir)
    {
        $this->em = $em;
        $this->directory = $rootDir . '/../var/data/game';
    }


    /**
     * Add groups and charts from a csv file
     */
    public function addFromCsv()
    {
        $files = array_diff(scandir($this->directory . '/in'), array('..', '.'));
        foreach ($files as $file) {
            if (substr($file, 0, 8) != 'game-add') {
                continue;
            }

            $fileIn = $this->directory . '/in/' . $file;
            $fileOut = $this->directory . '/out/' . $file;
            $handle = fopen($fileIn, 'r');
            $idGame = substr($file, 8, -4);

            if (!is_numeric($idGame)) {
                continue;
            }

            /** @var \VideoGamesRecords\CoreBundle\Entity\Game $game */
            $game = $this->em->getReference('VideoGamesRecords\CoreBundle\Entity\Game', $idGame);

            if ($game === null) {
                continue;
            }

            $group = null;
            $types = null;
            while (($row = fgetcsv($handle, null, ';')) !== false) {

It seems like $handle can also be of type false; however, parameter $handle of fgetcsv() does only seem to accept resource, maybe add an additional type check?

                $libEn = $row[1];
                $libFr = $row[2];
                if ((in_array($row[0], array('group', 'chart'))) && (isset($row[3]))) {
                    if ($row[3] != null) {
                        $types = explode('|', $row[3]);
                    }
                }
                switch ($row[0]) {
                    case 'object':
                        // DO nohting
                        break;
                    case 'group':
                        $group = new Group();
                        $group->translate('en', false)->setName($libEn);
                        $group->translate('fr', false)->setName($libFr);
                        $group->setGame($game);
                        $group->mergeNewTranslations();
                        $this->em->persist($group);
                        break;
                    case 'chart':
                        $chart = new Chart();
                        $chart->translate('en', false)->setName($libEn);
                        $chart->translate('fr', false)->setName($libFr);
                        $chart->setGroup($group);
                        $chart->mergeNewTranslations();

                        if ($types != null) {
                            foreach ($types as $idType) {
                                var_dump($idType);

var_dump($idType) looks like debug code. Are you sure you do not want to remove it?

                                $chartLib = new ChartLib();
                                $chartLib
                                    ->setChart($chart)
                                    ->setType($this->em->getReference('VideoGamesRecords\CoreBundle\Entity\ChartType', $idType));
                                $chart->addLib($chartLib);
                            }
                        }

                        $this->em->persist($chart);
                        break;
                }
            }
            $this->em->flush();
            rename($fileIn, $fileOut);
        }
    }


    /**
     * Update groups and charts from a csv file
     */
    public function updateFromCsv()
    {
        $files = array_diff(scandir($this->directory . '/in'), array('..', '.'));
        foreach ($files as $file) {
            if (substr($file, 0, 11) != 'game-update') {
                continue;
            }

            $fileIn = $this->directory . '/in/' . $file;
            $fileOut = $this->directory . '/out/' . $file;

The assignment to $fileOut is dead and can be removed.

            $handle = fopen($fileIn, 'r');
            $idGame = substr($file, 11, -4);

            if (!is_numeric($idGame)) {
                continue;
            }

            $group = null;
            $types = null;

The assignment to $types is dead and can be removed.

            while (($row = fgetcsv($handle, null, ';')) !== false) {

It seems like $handle can also be of type false; however, parameter $handle of fgetcsv() does only seem to accept resource, maybe add an additional type check?

                $id = $row[1];
                $libEn = $row[2];
                $libFr = $row[3];
                switch ($row[0]) {
                    case 'object':
                        // DO nohting
                        break;
                    case 'group':
                        $group = $this->em->getRepository('VideoGamesRecordsCoreBundle:Group')->find($id);
                        $group->translate('en', false)->setName($libEn);
                        $group->translate('fr', false)->setName($libFr);
                        $group->mergeNewTranslations();
                        $this->em->persist($group);
                        break;
                    case 'chart':
                        $chart = $this->em->getRepository('VideoGamesRecordsCoreBundle:Chart')->find($id);
                        $chart->translate('en', false)->setName($libEn);
                        $chart->translate('fr', false)->setName($libFr);
                        $chart->mergeNewTranslations();
                        $this->em->persist($chart);
                        break;
                }
            }
            $this->em->flush();
            //rename($fileIn, $fileOut);
        }
    }
}