VideoGamesRecords\CoreBundle\Ranking\Provider\Player\PlayerSerieRankingProvider::getRankingMedals()

Complexity

Conditions	6
Paths	13

Size

Total Lines	39
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getRankingMedals(int $id = null, array $options = []): array
    {
        $serie = $this->em->getRepository('VideoGamesRecords\CoreBundle\Entity\Serie')->find($id);
        if (null === $serie) {
            return [];
        }

        $maxRank = $options['maxRank'] ?? null;
        $player = $this->getPlayer();
        $limit = $options['limit'] ?? null;

        $query = $this->em->createQueryBuilder()
            ->select('ps')
            ->from('VideoGamesRecords\CoreBundle\Entity\PlayerSerie', 'ps')
            ->join('ps.player', 'p')
            ->addSelect('p')
            ->orderBy('ps.rankMedal');

        $query->where('ps.serie = :serie')
            ->setParameter('serie', $serie);

        $row = (null !== $player) ? $this->getRow($serie, $player) : null;

        if (null !== $maxRank) {
            if (null !== $row) {
                $query->andWhere('(ps.rankMedal <= :maxRank OR ps.rankMedal BETWEEN :min AND :max)')
                    ->setParameter('min', $row->getRankPoint() - 5)
                    ->setParameter('max', $row->getRankPoint() + 5);
            } else {
                $query->andWhere('ps.rankMedal <= :maxRank');
            }
            $query->setParameter('maxRank', $maxRank);
        }

        if (null !== $limit) {
            $query->setMaxResults($limit);
        }

        return $query->getQuery()->getResult();

The expression return $query->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }