VideoGamesRecords\CoreBundle\EventSubscriber\InsertLostPositionSubscriber::insertLostPosition()

Complexity

Conditions	10
Paths	2

Size

Total Lines	18
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function insertLostPosition(PlayerChartEvent $event): void
    {
        $playerChart = $event->getPlayerChart();
        $oldRank = $event->getOldRank();
        $oldNbEqual = $event->getOldNbEqual();
        $newRank = $playerChart->getRank();
        $newNbEqual = $playerChart->getNbEqual();

        if (
            (($oldRank >= 1) && ($oldRank <= 3) && ($newRank > $oldRank)) ||
            (($oldRank === 1) && ($oldNbEqual === 1) && ($newRank === 1) && ($newNbEqual > 1))
        ) {
            $lostPosition = new LostPosition();
            $lostPosition->setNewRank($newRank);

It seems like $newRank can also be of type null; however, parameter $newRank of VideoGamesRecords\CoreBundle\Entity\LostPosition::setNewRank() does only seem to accept integer, maybe add an additional type check?

            $lostPosition->setOldRank(($oldNbEqual == 1 && $oldRank == 1) ? 0 : $oldRank); //----- zero for losing platinum medal

It seems like $oldNbEqual == 1 && $oldRank == 1 ? 0 : $oldRank can also be of type null; however, parameter $oldRank of VideoGamesRecords\CoreBundle\Entity\LostPosition::setOldRank() does only seem to accept integer, maybe add an additional type check?

            $lostPosition->setPlayer($this->em->getReference(Player::class, $playerChart->getPlayer()->getId()));

It seems like $this->em->getReference(VideoGamesRecords\CoreBundle\Entity\Player::class, $playerChart->getPlayer()->getId()) can also be of type null; however, parameter $player of VideoGamesRecords\CoreBundle\Entity\LostPosition::setPlayer() does only seem to accept VideoGamesRecords\CoreBundle\Entity\Player, maybe add an additional type check?

            $lostPosition->setChart($this->em->getReference(Chart::class, $playerChart->getChart()->getId()));

It seems like $this->em->getReference(VideoGamesRecords\CoreBundle\Entity\Chart::class, $playerChart->getChart()->getId()) can also be of type null; however, parameter $chart of VideoGamesRecords\CoreBundle\Entity\LostPosition::setChart() does only seem to accept VideoGamesRecords\CoreBundle\Entity\Chart, maybe add an additional type check?

            $this->em->persist($lostPosition);
        }