VideoGamesRecords\DwhBundle\Service\TopPlayerProvider::getTop()

Complexity

Conditions	6
Paths	24

Size

Total Lines	62
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getTop(DateTime $date1Begin, DateTime $date1End, DateTime $date2Begin, DateTime $date2End, int $limit = 20): array
    {
        /** @var DwhPlayerRepository $dwhPlayerRepository */
        $dwhPlayerRepository = $this->dwhEntityManager->getRepository('VideoGamesRecords\DwhBundle\Entity\Player');

        /** @var CorePlayerRepository $dwhPlayerRepository */
        $corePlayerRepository = $this->defaultEntityManager->getRepository('VideoGamesRecords\CoreBundle\Entity\Player');

        $playerList1 = $dwhPlayerRepository->getTop(
            $date1Begin,
            $date1End,
            $limit
        );
        $playerList2 = $dwhPlayerRepository->getTop(
            $date2Begin,
            $date2End,
            $limit
        );

        // Get old rank
        $oldRank = array();
        foreach ($playerList2 as $key => $row) {
            $oldRank[$row['id']] = $key + 1;
        }

        $nbPostFromList = 0;
        for ($i=0, $nb=count($playerList1) - 1; $i <= $nb; ++$i) {

It seems like $playerList1 can also be of type integer and null; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            $idPlayer = $playerList1[$i]['id'];
            if (isset($oldRank[$idPlayer])) {
                $playerList1[$i]['oldRank'] = $oldRank[$idPlayer];
            } else {
                $playerList1[$i]['oldRank'] = null;
            }
            $player = $corePlayerRepository->find($idPlayer);
            $playerList1[$i]['player'] = $player;
            $nbPostFromList += $playerList1[$i]['nb'];
        }

        $nbPlayer = 0;

The assignment to $nbPlayer is dead and can be removed.

        try {
            $nbPlayer = $dwhPlayerRepository->getTotalNbPlayer($date1Begin, $date1End);
        } catch (NoResultException|NonUniqueResultException $e) {

Consider adding a comment why this CATCH block is empty.

        }

        $nbTotalPost = 0;

The assignment to $nbTotalPost is dead and can be removed.

        try {
            $nbTotalPost = $dwhPlayerRepository->getTotalNbPostDay($date1Begin, $date1End);
        } catch (NoResultException|NonUniqueResultException $e) {

Consider adding a comment why this CATCH block is empty.

        }

        $playerList = ToolsRanking::addRank(
            $playerList1,
            'rank',
            ['nb'],
            true
        );

        return array(
            'list' => $playerList,
            'nbPostFromList' => $nbPostFromList,
            'nb' => $nbPlayer,
            'nbTotalPost' => $nbTotalPost,
        );