FileSystemReader::validate() - Code Metrics - Inspection of "Adding more solid principles" - victormech/ditesto - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Victor

created 2017-10-24 01:05 UTC

FileSystemReader::validate() A

↳ Parent: FileSystemReader

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	0
cts	6
cp	0
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	5
nc	3
nop	0
crap	12

<?php

namespace LazyEight\DiTesto\FileSystem;

use LazyEight\DiTesto\Exceptions\FileSystemException;
use LazyEight\DiTesto\Interfaces\FileSystem\FileSystemPathInterface;
use LazyEight\DiTesto\Interfaces\FileSystem\FileSystemReaderInterface;
use Test\DiTesto\FileSystem\Exceptions\InvalidPathException;

class FileSystemReader implements FileSystemReaderInterface
{
    /**
     * @var FileSystemPathInterface
     */
    private $path;

    /**
     * FileSystemReader constructor.
     * @param FileSystemPathInterface $path
     */
    public function __construct(FileSystemPathInterface $path)
    {
        $this->path = $path;
    }

    /**
     * @inheritDoc
     */
    public function isReadable(): bool
    {
        return is_readable($this->path->rawPath());
    }

    /**
     * @inheritDoc
     */
    public function read(): string
    {
        $this->validate();
        return file_get_contents($this->path->rawPath());
    }

    /**
     * @throws FileSystemException
     * @throws InvalidPathException
     */
    public function validate()
    {
        if ($this->path->isDirectory()) {
            throw new InvalidPathException("Error, can't read content from a directory.");
        }

        if (!$this->isReadable()) {
            throw new FileSystemException("Error, can't read the file. The file not exists or is not readable.");
        }
    }
}


1		<?php
2
3		namespace LazyEight\DiTesto\FileSystem;
4
5		use LazyEight\DiTesto\Exceptions\FileSystemException;
6		use LazyEight\DiTesto\Interfaces\FileSystem\FileSystemPathInterface;
7		use LazyEight\DiTesto\Interfaces\FileSystem\FileSystemReaderInterface;
8		use Test\DiTesto\FileSystem\Exceptions\InvalidPathException;
9
10		class FileSystemReader implements FileSystemReaderInterface
11		{
12		/**
13		* @var FileSystemPathInterface
14		*/
15		private $path;
16
17		/**
18		* FileSystemReader constructor.
19		* @param FileSystemPathInterface $path
20		*/
21	1	public function __construct(FileSystemPathInterface $path)
22		{
23	1	$this->path = $path;
24	1	}
25
26		/**
27		* @inheritDoc
28		*/
29		public function isReadable(): bool
30		{
31		return is_readable($this->path->rawPath());
32		}
33
34		/**
35		* @inheritDoc
36		*/
37		public function read(): string
38		{
39		$this->validate();
40		return file_get_contents($this->path->rawPath());
41		}
42
43		/**
44		* @throws FileSystemException
45		* @throws InvalidPathException
46		*/
47		public function validate()
48		{
49		if ($this->path->isDirectory()) {
50		throw new InvalidPathException("Error, can't read content from a directory.");
51		}
52
53		if (!$this->isReadable()) {
54		throw new FileSystemException("Error, can't read the file. The file not exists or is not readable.");
55		}
56		}
57		}
58

victormech / ditesto

Pull Request — master (#13)

FileSystemReader::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like