ListSinceBlock::jsonSerialize() - Code Metrics - Inspection of "Improve code quality" - vherus/ZenCash-Rpc-Client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( abede7...d40790 )

by Nathan

created 2018-04-20 17:26 UTC

ListSinceBlock::jsonSerialize() A

↳ Parent: ListSinceBlock

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0
crap	1

<?php

namespace ZenCash\Rpc\Command\Wallet;

use ZenCash\Rpc\Command;

class ListSinceBlock implements Command
{
    private const METHOD = 'listsinceblock';
    private $hash;
    private $confirms;
    private $watchOnly;

    public function __construct(?string $blockHash, ?int $targetConfirmations, ?bool $includeWatchOnly)
    {
        $this->hash = $blockHash;
        $this->confirms = $targetConfirmations;
        $this->watchOnly = $includeWatchOnly;
    }

    public function jsonSerialize(): object
    {
        return (object) [
                'jsonrpc' => Command::JSON_RPC_VERSION,
                'id'      => Command::ID,
                'method'  => self::METHOD,
                'params' => array_merge(
                    $this->getHashParam(),
                    $this->getConfirmsParam(),
                    $this->getWatchOnlyParam()
                )
        ];
    }

    private function getHashParam(): array
    {
        return !is_null($this->hash) ? [ $this->hash ] : [ ];
    }

    private function getConfirmsParam(): array
    {
        return !is_null($this->hash) && !is_null($this->confirms) ? [ $this->confirms ] : [ ];
    }

    private function getWatchOnlyParam(): array
    {
        return !is_null($this->hash) && !is_null($this->confirms) && !is_null($this->watchOnly) ? [
            $this->watchOnly
        ] : [ ];
    }
}


1		<?php
2
3		namespace ZenCash\Rpc\Command\Wallet;
4
5		use ZenCash\Rpc\Command;
6
7		class ListSinceBlock implements Command
8		{
9		private const METHOD = 'listsinceblock';
10		private $hash;
11		private $confirms;
12		private $watchOnly;
13
14	4	public function __construct(?string $blockHash, ?int $targetConfirmations, ?bool $includeWatchOnly)
15		{
16	4	$this->hash = $blockHash;
17	4	$this->confirms = $targetConfirmations;
18	4	$this->watchOnly = $includeWatchOnly;
19	4	}
20
21	4	public function jsonSerialize(): object
22		{
23		return (object) [
24	4	'jsonrpc' => Command::JSON_RPC_VERSION,
25		'id' => Command::ID,
26	4	'method' => self::METHOD,
27	4	'params' => array_merge(
28	4	$this->getHashParam(),
29	4	$this->getConfirmsParam(),
30	4	$this->getWatchOnlyParam()
31		)
32		];
33		}
34
35	4	private function getHashParam(): array
36		{
37	4	return !is_null($this->hash) ? [ $this->hash ] : [ ];
38		}
39
40	4	private function getConfirmsParam(): array
41		{
42	4	return !is_null($this->hash) && !is_null($this->confirms) ? [ $this->confirms ] : [ ];
43		}
44
45	4	private function getWatchOnlyParam(): array
46		{
47	4	return !is_null($this->hash) && !is_null($this->confirms) && !is_null($this->watchOnly) ? [
48	1	$this->watchOnly
49	4	] : [ ];
50		}
51		}
52

vherus / ZenCash-Rpc-Client

Push — master ( abede7...d40790 )

ListSinceBlock::jsonSerialize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like