vfalies /
tmdb
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php declare(strict_types = 1); |
||
| 26 | View Code Duplication | class Favorite extends Account |
|
|
|
|||
| 27 | { |
||
| 28 | |||
| 29 | /** |
||
| 30 | * Get account favorite movies |
||
| 31 | * @return \Generator|Results\Movie |
||
| 32 | */ |
||
| 33 | 1 | public function getMovies() : \Generator |
|
| 37 | |||
| 38 | /** |
||
| 39 | * Get account favorite tvshows |
||
| 40 | * @return \Generator|Results\TVShow |
||
| 41 | */ |
||
| 42 | 1 | public function getTVShows() : \Generator |
|
| 46 | |||
| 47 | /** |
||
| 48 | * Marl a movie as favorite |
||
| 49 | * @param int $movie_id Movie id |
||
| 50 | * @return Favorite |
||
| 51 | */ |
||
| 52 | 2 | public function markMovieAsFavorite(int $movie_id) : Favorite |
|
| 56 | /** |
||
| 57 | |||
| 58 | * Unmark a movie as favorite |
||
| 59 | * @param int $movie_id Movie id |
||
| 60 | * @return Favorite |
||
| 61 | */ |
||
| 62 | 1 | public function unmarkMovieAsFavorite(int $movie_id) : Favorite |
|
| 66 | |||
| 67 | /** |
||
| 68 | * Mark a TV show as favorkite |
||
| 69 | * @param int $tvshow_id TV show id |
||
| 70 | * @return Favorite |
||
| 71 | */ |
||
| 72 | 1 | public function markTVShowAsFavorite(int $tvshow_id) : Favorite |
|
| 76 | |||
| 77 | /** |
||
| 78 | * Unmark a TV show as favorite |
||
| 79 | * @param int $tvshow_id TV Show id |
||
| 80 | * @return Favorite |
||
| 81 | */ |
||
| 82 | 1 | public function unmarkTVShowAsFavorite(int $tvshow_id) : Favorite |
|
| 86 | } |
||
| 87 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.