TVSeason::__construct() - Code Metrics - Inspection of "Rc/1.3.0" - vfalies/tmdb - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#17)

unknown

created 2017-06-20 11:34 UTC

TVSeason::__construct() A

↳ Parent: TVSeason

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	2
crap	1

<?php

namespace vfalies\tmdb\Results;

use vfalies\tmdb\Abstracts\Results;
use vfalies\tmdb\Tmdb;
use vfalies\tmdb\Interfaces\Results\TVSeasonResultsInterface;

class TVSeason extends Results implements TVSeasonResultsInterface
{

    protected $episode_count = 0;
    protected $season_number = 0;
    protected $poster_path   = null;

    /**
     * Constructor
     * @param \vfalies\tmdb\Tmdb $tmdb
     * @param \stdClass $result
     * @throws \Exception
     */
    public function __construct(Tmdb $tmdb, \stdClass $result)
    {
        parent::__construct($tmdb, $result);

        // Populate data
        $this->id            = $this->data->id;
        $this->release_date  = $this->data->air_date;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->episode_count = $this->data->episode_count;
        $this->poster_path   = $this->data->poster_path;
        $this->season_number = $this->data->season_number;
    }

    public function getId(): int
    {
        return $this->id;
    }

    public function getReleaseDate(): string
    {
        return $this->release_date;
    }

    public function getEpisodeCount(): int
    {
        return (int) $this->episode_count;
    }

    public function getSeasonNumber(): int
    {
        return (int) $this->season_number;
    }
}


1		<?php
2
3		namespace vfalies\tmdb\Results;
4
5		use vfalies\tmdb\Abstracts\Results;
6		use vfalies\tmdb\Tmdb;
7		use vfalies\tmdb\Interfaces\Results\TVSeasonResultsInterface;
8
9		class TVSeason extends Results implements TVSeasonResultsInterface
10		{
11
12		protected $episode_count = 0;
13		protected $season_number = 0;
14		protected $poster_path = null;
15
16		/**
17		* Constructor
18		* @param \vfalies\tmdb\Tmdb $tmdb
19		* @param \stdClass $result
20		* @throws \Exception
21		*/
22	5	public function __construct(Tmdb $tmdb, \stdClass $result)
23		{
24	5	parent::__construct($tmdb, $result);
25
26		// Populate data
27	5	$this->id = $this->data->id;
28	5	$this->release_date = $this->data->air_date;
		0 ignored issues – show Bug introduced 2017-06-20 11:33 UTC by Report Bug Copy Issue Report The property `release_date` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29	5	$this->episode_count = $this->data->episode_count;
30	5	$this->poster_path = $this->data->poster_path;
31	5	$this->season_number = $this->data->season_number;
32	5	}
33
34	1	public function getId(): int
35		{
36	1	return $this->id;
37		}
38
39	1	public function getReleaseDate(): string
40		{
41	1	return $this->release_date;
42		}
43
44	1	public function getEpisodeCount(): int
45		{
46	1	return (int) $this->episode_count;
47		}
48
49	1	public function getSeasonNumber(): int
50		{
51	1	return (int) $this->season_number;
52		}
53		}
54

vfalies / tmdb

Pull Request — master (#17)

TVSeason::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like