Item - Code Metrics - Inspection of "Refactoring duplication" - vfalies/tmdb - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7)

by vincent

created 2017-06-02 18:43 UTC

Item A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	45.07 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	10
lcom	1
cbo	2
dl	32
loc	71
ccs	25
cts	25
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	2
A	getPoster()	16	16	4
A	getBackdrop()	16	16	4

How to fix Duplicated Code

<?php

namespace vfalies\tmdb\Items;

abstract class Item
{
    /**
     * Constructor
     * @param \vfalies\tmdb\Tmdb $tmdb
     * @param int $item_id
     * @param array $options
     * @param string $item_name
     * @throws \Exception
     */
    public function __construct(\vfalies\tmdb\Tmdb $tmdb, int $item_id, array $options, string $item_name)
    {
        try
        {
            $this->id   = (int) $item_id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->tmdb = $tmdb;
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->conf = $this->tmdb->getConfiguration();
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $params     = $this->tmdb->checkOptions($options);
            $this->data = $this->tmdb->sendRequest(new \vfalies\tmdb\CurlRequest(), $item_name . '/'.(int) $item_id, null, $params);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        catch (\Exception $ex)
        {
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * Get item poster
     * @param string $size
     * @return string
     */
    public function getPoster(string $size = 'w185'): string

    {
        if (isset($this->data->poster_path))
        {
            if (!isset($this->conf->images->base_url))
            {
                throw new \Exception('base_url configuration not found');
            }
            if (!in_array($size, $this->conf->images->poster_sizes))
            {
                throw new \Exception('Incorrect poster size : ' . $size);
            }
            return $this->conf->images->base_url . $size . $this->data->poster_path;
        }
        return '';
    }

    /**
     * Get item backdrop
     * @param string $size
     * @return string|null
     */
    public function getBackdrop(string $size = 'w780'): string

    {
        if (isset($this->data->backdrop_path))
        {
            if (!isset($this->conf->images->base_url))
            {
                throw new \Exception('base_url configuration not found');
            }
            if (!in_array($size, $this->conf->images->backdrop_sizes))
            {
                throw new \Exception('Incorrect backdrop size : ' . $size);
            }
            return $this->conf->images->base_url . $size . $this->data->backdrop_path;
        }
        return '';
    }

}


1			<?php
2
3			namespace vfalies\tmdb\Items;
4
5			abstract class Item
6			{
7			/**
8			* Constructor
9			* @param \vfalies\tmdb\Tmdb $tmdb
10			* @param int $item_id
11			* @param array $options
12			* @param string $item_name
13			* @throws \Exception
14			*/
15	71		public function __construct(\vfalies\tmdb\Tmdb $tmdb, int $item_id, array $options, string $item_name)
16			{
17			try
18			{
19	71		$this->id = (int) $item_id;
			0 ignored issues – show Bug introduced 2017-06-02 18:46 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20	71		$this->tmdb = $tmdb;
			0 ignored issues – show Bug introduced 2017-06-02 18:46 UTC by Report Bug Copy Issue Report The property `tmdb` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21	71		$this->conf = $this->tmdb->getConfiguration();
			0 ignored issues – show Bug introduced 2017-06-02 18:46 UTC by Report Bug Copy Issue Report The property `conf` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22	71		$params = $this->tmdb->checkOptions($options);
23	71		$this->data = $this->tmdb->sendRequest(new \vfalies\tmdb\CurlRequest(), $item_name . '/'.(int) $item_id, null, $params);
			0 ignored issues – show Bug introduced 2017-06-02 18:46 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			}
25	3		catch (\Exception $ex)
26			{
27	3		throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
28			}
29	68		}
30
31			/**
32			* Get item poster
33			* @param string $size
34			* @return string
35			*/
36	12	View Code Duplication	public function getPoster(string $size = 'w185'): string
			0 ignored issues – show Duplication introduced 2017-06-02 11:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37			{
38	12		if (isset($this->data->poster_path))
39			{
40	9		if (!isset($this->conf->images->base_url))
41			{
42	3		throw new \Exception('base_url configuration not found');
43			}
44	6		if (!in_array($size, $this->conf->images->poster_sizes))
45			{
46	3		throw new \Exception('Incorrect poster size : ' . $size);
47			}
48	3		return $this->conf->images->base_url . $size . $this->data->poster_path;
49			}
50	3		return '';
51			}
52
53			/**
54			* Get item backdrop
55			* @param string $size
56			* @return string\|null
57			*/
58	12	View Code Duplication	public function getBackdrop(string $size = 'w780'): string
			0 ignored issues – show Duplication introduced 2017-06-02 11:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59			{
60	12		if (isset($this->data->backdrop_path))
61			{
62	9		if (!isset($this->conf->images->base_url))
63			{
64	3		throw new \Exception('base_url configuration not found');
65			}
66	6		if (!in_array($size, $this->conf->images->backdrop_sizes))
67			{
68	3		throw new \Exception('Incorrect backdrop size : ' . $size);
69			}
70	3		return $this->conf->images->base_url . $size . $this->data->backdrop_path;
71			}
72	3		return '';
73			}
74
75			}
76

vfalies / tmdb

Pull Request — master (#7)

Item A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like