PeopleTVShowCast - Code Metrics - Inspection of "Merge pull request #29 from vfalies/release/1.5.0" - vfalies/tmdb - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fc0106...465d67 )

by vincent

created 2017-07-18 13:07 UTC

PeopleTVShowCast A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	143
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	1
dl	143
loc	143
ccs	27
cts	27
cp	1
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	13	13	1
A	getId()	4	4	1
A	getCreditId()	4	4	1
A	getCharacter()	4	4	1
A	getName()	4	4	1
A	getOriginalName()	4	4	1
A	getPosterPath()	4	4	1
A	getFirstAirDate()	4	4	1
A	getEpisodeCount()	4	4	1

How to fix Duplicated Code

<?php

/**
 * This file is part of the Tmdb package.
 *
 * (c) Vincent Faliès <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Vincent Faliès <[email protected]>
 * @copyright Copyright (c) 2017
 */

namespace vfalies\tmdb\Results;

use vfalies\tmdb\Abstracts\Results;
use vfalies\tmdb\Interfaces\TmdbInterface;

/**
 * Class to manipulate a people tvshow cast result
 * @package Tmdb
 * @author Vincent Faliès <[email protected]>
 * @copyright Copyright (c) 2017
 */
class PeopleTVShowCast extends Results

{

    /**
     * Character name
     * @var string
     */
    protected $character = null;

    /**
     * Credit Id
     * @var string
     */
    protected $credit_id = null;

    /**
     * name
     * @var string
     */
    protected $name = null;

    /**
     * Image poster path
     * @var string
     */
    protected $poster_path = null;

    /**
     * original name
     * @var string
     */
    protected $original_name = null;

    /**
     * First air date
     * @var string
     */
    protected $first_air_date = null;

    /**
     * Id
     * @var int
     */
    protected $id = null;

    /**
     * Episode count
     * @var int
     */
    protected $episode_count = null;

    /**
     * Constructor
     * @param \vfalies\tmdb\Interfaces\TmdbInterface $tmdb
     * @param \stdClass $result
     */
    public function __construct(TmdbInterface $tmdb, \stdClass $result)
    {
        parent::__construct($tmdb, $result);

        $this->id             = $this->data->id;
        $this->episode_count  = $this->data->episode_count;
        $this->character      = $this->data->character;
        $this->credit_id      = $this->data->credit_id;
        $this->original_name  = $this->data->original_name;
        $this->name           = $this->data->name;
        $this->poster_path    = $this->data->poster_path;
        $this->first_air_date = $this->data->first_air_date;
    }

    /**
     * Get Id
     * @return int
     */
    public function getId()
    {
        return (int) $this->id;
    }

    /**
     * Get credit Id
     * @return string
     */
    public function getCreditId()
    {
        return $this->credit_id;
    }

    /**
     * Get character name
     * @return string
     */
    public function getCharacter()
    {
        return $this->character;
    }

    /**
     * Get name
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Get original name
     * @return string
     */
    public function getOriginalName()
    {
        return $this->original_name;
    }

    /**
     * Get poster path
     * @return string
     */
    public function getPosterPath()
    {
        return $this->poster_path;
    }

    /**
     * Get first air date
     * @return string
     */
    public function getFirstAirDate()
    {
        return $this->first_air_date;
    }

    /**
     * Episode count
     * @return boolean
     */
    public function getEpisodeCount()
    {
        return $this->episode_count;
    }

}


1			<?php
2
3			/**
4			* This file is part of the Tmdb package.
5			*
6			* (c) Vincent Faliès <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*
11			* @author Vincent Faliès <[email protected]>
12			* @copyright Copyright (c) 2017
13			*/
14
15			namespace vfalies\tmdb\Results;
16
17			use vfalies\tmdb\Abstracts\Results;
18			use vfalies\tmdb\Interfaces\TmdbInterface;
19
20			/**
21			* Class to manipulate a people tvshow cast result
22			* @package Tmdb
23			* @author Vincent Faliès <[email protected]>
24			* @copyright Copyright (c) 2017
25			*/
26		View Code Duplication	class PeopleTVShowCast extends Results
			0 ignored issues – show Duplication introduced 2017-07-18 07:59 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27			{
28
29			/**
30			* Character name
31			* @var string
32			*/
33			protected $character = null;
34
35			/**
36			* Credit Id
37			* @var string
38			*/
39			protected $credit_id = null;
40
41			/**
42			* name
43			* @var string
44			*/
45			protected $name = null;
46
47			/**
48			* Image poster path
49			* @var string
50			*/
51			protected $poster_path = null;
52
53			/**
54			* original name
55			* @var string
56			*/
57			protected $original_name = null;
58
59			/**
60			* First air date
61			* @var string
62			*/
63			protected $first_air_date = null;
64
65			/**
66			* Id
67			* @var int
68			*/
69			protected $id = null;
70
71			/**
72			* Episode count
73			* @var int
74			*/
75			protected $episode_count = null;
76
77			/**
78			* Constructor
79			* @param \vfalies\tmdb\Interfaces\TmdbInterface $tmdb
80			* @param \stdClass $result
81			*/
82	9		public function __construct(TmdbInterface $tmdb, \stdClass $result)
83			{
84	9		parent::__construct($tmdb, $result);
85
86	9		$this->id = $this->data->id;
87	9		$this->episode_count = $this->data->episode_count;
88	9		$this->character = $this->data->character;
89	9		$this->credit_id = $this->data->credit_id;
90	9		$this->original_name = $this->data->original_name;
91	9		$this->name = $this->data->name;
92	9		$this->poster_path = $this->data->poster_path;
93	9		$this->first_air_date = $this->data->first_air_date;
94	9		}
95
96			/**
97			* Get Id
98			* @return int
99			*/
100	1		public function getId()
101			{
102	1		return (int) $this->id;
103			}
104
105			/**
106			* Get credit Id
107			* @return string
108			*/
109	1		public function getCreditId()
110			{
111	1		return $this->credit_id;
112			}
113
114			/**
115			* Get character name
116			* @return string
117			*/
118	1		public function getCharacter()
119			{
120	1		return $this->character;
121			}
122
123			/**
124			* Get name
125			* @return string
126			*/
127	1		public function getName()
128			{
129	1		return $this->name;
130			}
131
132			/**
133			* Get original name
134			* @return string
135			*/
136	1		public function getOriginalName()
137			{
138	1		return $this->original_name;
139			}
140
141			/**
142			* Get poster path
143			* @return string
144			*/
145	1		public function getPosterPath()
146			{
147	1		return $this->poster_path;
148			}
149
150			/**
151			* Get first air date
152			* @return string
153			*/
154	1		public function getFirstAirDate()
155			{
156	1		return $this->first_air_date;
157			}
158
159			/**
160			* Episode count
161			* @return boolean
162			*/
163	1		public function getEpisodeCount()
164			{
165	1		return $this->episode_count;
166			}
167
168			}
169

vfalies / tmdb

Push — master ( fc0106...465d67 )

PeopleTVShowCast A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like