Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
26 | View Code Duplication | class PeopleMovieCast extends Results |
|
|
|||
27 | { |
||
28 | |||
29 | /** |
||
30 | * Adult |
||
31 | * @var boolean |
||
32 | */ |
||
33 | protected $adult = null; |
||
34 | |||
35 | /** |
||
36 | * Character name |
||
37 | * @var string |
||
38 | */ |
||
39 | protected $character = null; |
||
40 | |||
41 | /** |
||
42 | * Credit Id |
||
43 | * @var string |
||
44 | */ |
||
45 | protected $credit_id = null; |
||
46 | |||
47 | /** |
||
48 | * title |
||
49 | * @var string |
||
50 | */ |
||
51 | protected $title = null; |
||
52 | |||
53 | /** |
||
54 | * Image poster path |
||
55 | * @var string |
||
56 | */ |
||
57 | protected $poster_path = null; |
||
58 | |||
59 | /** |
||
60 | * original title |
||
61 | * @var string |
||
62 | */ |
||
63 | protected $original_title = null; |
||
64 | |||
65 | /** |
||
66 | * Release date |
||
67 | * @var string |
||
68 | */ |
||
69 | protected $release_date = null; |
||
70 | |||
71 | /** |
||
72 | * Id |
||
73 | * @var int |
||
74 | */ |
||
75 | protected $id = null; |
||
76 | |||
77 | /** |
||
78 | * Constructor |
||
79 | * @param \vfalies\tmdb\Interfaces\TmdbInterface $tmdb |
||
80 | * @param \stdClass $result |
||
81 | */ |
||
82 | 9 | public function __construct(TmdbInterface $tmdb, \stdClass $result) |
|
95 | |||
96 | /** |
||
97 | * Get Id |
||
98 | * @return int |
||
99 | */ |
||
100 | 1 | public function getId() |
|
104 | |||
105 | /** |
||
106 | * Get credit Id |
||
107 | * @return string |
||
108 | */ |
||
109 | 1 | public function getCreditId() |
|
113 | |||
114 | /** |
||
115 | * Get character name |
||
116 | * @return string |
||
117 | */ |
||
118 | 1 | public function getCharacter() |
|
122 | |||
123 | /** |
||
124 | * Get title |
||
125 | * @return string |
||
126 | */ |
||
127 | 1 | public function getTitle() |
|
131 | |||
132 | /** |
||
133 | * Get original title |
||
134 | * @return string |
||
135 | */ |
||
136 | 1 | public function getOriginalTitle() |
|
140 | |||
141 | /** |
||
142 | * Get poster path |
||
143 | * @return string |
||
144 | */ |
||
145 | 1 | public function getPosterPath() |
|
149 | |||
150 | /** |
||
151 | * Get release date |
||
152 | * @return string |
||
153 | */ |
||
154 | 1 | public function getReleaseDate() |
|
158 | |||
159 | /** |
||
160 | * Adult |
||
161 | * @return boolean |
||
162 | */ |
||
163 | 1 | public function getAdult() |
|
167 | } |
||
168 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.