Videos::__construct() - Code Metrics - Inspection of "Merge pull request #38 from vfalies/1.7-rc" - vfalies/tmdb - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9635db...d1c97e )

by vincent

created 2020-01-17 21:25 UTC

Videos::__construct() A

↳ Parent: Videos

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	13
c	0
b	0
f	0
ccs	11
cts	11
cp	1
rs	9.8333
cc	1
nc	1
nop	2
crap	1

<?php declare(strict_types = 1);
/**
 * This file is part of the Tmdb package.
 *
 * (c) Vincent Faliès <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Vincent Faliès <[email protected]>
 * @copyright Copyright (c) 2017-2020
 */


namespace VfacTmdb\Results;

use VfacTmdb\Abstracts\Results;
use VfacTmdb\Interfaces\Results\VideosResultsInterface;
use VfacTmdb\Interfaces\TmdbInterface;

/**
 * Class to manipulate a videos result
 * @package Tmdb
 * @author Vincent Faliès <[email protected]>
 * @copyright Copyright (c) 2017-2020
 */
class Videos extends Results implements VideosResultsInterface
{
    /**
     * Iso_639_1
     * @var string
     */
    protected $iso_639_1 = null;
    /**
     * Iso_3166_1
     * @var string
     */
    protected $iso_3166_1 = null;
    /**
     * Key
     * @var string
     */
    protected $key = null;
    /**
     * Name
     * @var string
     */
    protected $name = null;
    /**
     * Site
     * @var string
     */
    protected $site = null;
    /**
     * Id
     * @var string
     */
    protected $id = null;
    /**
     * Size
     *
     * @var int
     */
    protected $size = null;
    /**
     * Type
     *
     * @var string
     */
    protected $type = null;
    /**
     * Constructor
     * @param TmdbInterface $tmdb
     * @param \stdClass $result
     */
    public function __construct(TmdbInterface $tmdb, \stdClass $result)
    {
        parent::__construct($tmdb, $result);

        $this->video_id   = $this->data->id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->iso_639_1  = $this->data->iso_639_1;
        $this->iso_3166_1 = $this->data->iso_3166_1;
        $this->key        = $this->data->key;
        $this->name       = $this->data->name;
        $this->site       = $this->data->site;
        $this->size       = $this->data->size;
        $this->type       = $this->data->type;
    }

    /**
     * Get iso_639_1
     *
     * @return  string
     */
    public function getIso_639_1() : string
    {
        return $this->iso_639_1;
    }

    /**
     * Get iso_3166_1
     *
     * @return  string
     */
    public function getIso_3166_1() : string
    {
        return $this->iso_3166_1;
    }

    /**
     * Get key
     *
     * @return  string
     */
    public function getKey() : string
    {
        return $this->key;
    }

    /**
     * Get name
     *
     * @return  string
     */
    public function getName() : string
    {
        return $this->name;
    }

    /**
     * Get site
     *
     * @return  string
     */
    public function getSite() : string
    {
        return $this->site;
    }

    /**
     * Get id
     *
     * @return string
     */
    public function getVideoId() : string
    {
        return $this->video_id;
    }

    /**
     * Get size
     *
     * @return  int
     */
    public function getSize() : int
    {
        return $this->size;
    }

    /**
     * Get type
     *
     * @return  string
     */
    public function getType() : string
    {
        return $this->type;
    }

    /**
     * Get id
     *
     * @return int
     */
    public function getId() : ?int
    {
        return null;
    }
}


1		<?php declare(strict_types = 1);
2		/**
3		* This file is part of the Tmdb package.
4		*
5		* (c) Vincent Faliès <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*
10		* @author Vincent Faliès <[email protected]>
11		* @copyright Copyright (c) 2017-2020
12		*/
13
14
15		namespace VfacTmdb\Results;
16
17		use VfacTmdb\Abstracts\Results;
18		use VfacTmdb\Interfaces\Results\VideosResultsInterface;
19		use VfacTmdb\Interfaces\TmdbInterface;
20
21		/**
22		* Class to manipulate a videos result
23		* @package Tmdb
24		* @author Vincent Faliès <[email protected]>
25		* @copyright Copyright (c) 2017-2020
26		*/
27		class Videos extends Results implements VideosResultsInterface
28		{
29		/**
30		* Iso_639_1
31		* @var string
32		*/
33		protected $iso_639_1 = null;
34		/**
35		* Iso_3166_1
36		* @var string
37		*/
38		protected $iso_3166_1 = null;
39		/**
40		* Key
41		* @var string
42		*/
43		protected $key = null;
44		/**
45		* Name
46		* @var string
47		*/
48		protected $name = null;
49		/**
50		* Site
51		* @var string
52		*/
53		protected $site = null;
54		/**
55		* Id
56		* @var string
57		*/
58		protected $id = null;
59		/**
60		* Size
61		*
62		* @var int
63		*/
64		protected $size = null;
65		/**
66		* Type
67		*
68		* @var string
69		*/
70		protected $type = null;
71		/**
72		* Constructor
73		* @param TmdbInterface $tmdb
74		* @param \stdClass $result
75		*/
76	3	public function __construct(TmdbInterface $tmdb, \stdClass $result)
77		{
78	3	parent::__construct($tmdb, $result);
79
80	3	$this->video_id = $this->data->id;
		0 ignored issues – show Bug introduced 2020-01-17 21:23 UTC by Report Bug Copy Issue Report The property `video_id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
81	3	$this->iso_639_1 = $this->data->iso_639_1;
82	3	$this->iso_3166_1 = $this->data->iso_3166_1;
83	3	$this->key = $this->data->key;
84	3	$this->name = $this->data->name;
85	3	$this->site = $this->data->site;
86	3	$this->size = $this->data->size;
87	3	$this->type = $this->data->type;
88	3	}
89
90		/**
91		* Get iso_639_1
92		*
93		* @return string
94		*/
95		public function getIso_639_1() : string
96		{
97		return $this->iso_639_1;
98		}
99
100		/**
101		* Get iso_3166_1
102		*
103		* @return string
104		*/
105		public function getIso_3166_1() : string
106		{
107		return $this->iso_3166_1;
108		}
109
110		/**
111		* Get key
112		*
113		* @return string
114		*/
115		public function getKey() : string
116		{
117		return $this->key;
118		}
119
120		/**
121		* Get name
122		*
123		* @return string
124		*/
125		public function getName() : string
126		{
127		return $this->name;
128		}
129
130		/**
131		* Get site
132		*
133		* @return string
134		*/
135		public function getSite() : string
136		{
137		return $this->site;
138		}
139
140		/**
141		* Get id
142		*
143		* @return string
144		*/
145		public function getVideoId() : string
146		{
147		return $this->video_id;
148		}
149
150		/**
151		* Get size
152		*
153		* @return int
154		*/
155		public function getSize() : int
156		{
157		return $this->size;
158		}
159
160		/**
161		* Get type
162		*
163		* @return string
164		*/
165		public function getType() : string
166		{
167		return $this->type;
168		}
169
170		/**
171		* Get id
172		*
173		* @return int
174		*/
175		public function getId() : ?int
176		{
177		return null;
178		}
179		}
180

vfalies / tmdb

Push — master ( 9635db...d1c97e )

Videos::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like