MovieVideos::getVideos() - Code Metrics - Inspection of "Merge pull request #38 from vfalies/1.7-rc" - vfalies/tmdb - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9635db...d1c97e )

by vincent

created 2020-01-17 21:25 UTC

MovieVideos::getVideos() A

↳ Parent: MovieVideos

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	9
c	0
b	0
f	0
ccs	6
cts	6
cp	1
rs	9.9666
cc	3
nc	3
nop	0
crap	3

<?php declare(strict_types = 1);
/**
 * This file is part of the Tmdb package.
 *
 * (c) Vincent Faliès <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Vincent Faliès <[email protected]>
 * @copyright Copyright (c) 2017-2020
 */


namespace VfacTmdb\Items;

use VfacTmdb\Results;
use VfacTmdb\Interfaces\TmdbInterface;

/**
 * Movie Videos class
 * @package Tmdb
 * @author Vincent Faliès <[email protected]>
 * @copyright Copyright (c) 2017-2020
 */
class MovieVideos
{
    /**
     * Tmdb object
     * @var TmdbInterface
     */
    private $tmdb = null;
    /**
     * Logger object
     * @var \Psr\Log\LoggerInterface
     */
    protected $logger = null;
    /**
     * Params
     * @var array
     */
    protected $params = null;
    /**
     * Data
     * @var \stdClass
     */
    protected $data = null;
    /**
     * Options array
     * @var array
     */
    protected $options;

    /**
     * Constructor
     * @param TmdbInterface $tmdb
     * @param int $movie_id
     * @param array $options
     */
    public function __construct(TmdbInterface $tmdb, int $movie_id, array $options = array())

    {
        $this->tmdb    = $tmdb;
        $this->logger  = $tmdb->getLogger();
        $this->data    = $this->tmdb->getRequest('movie/' . $movie_id . '/videos');
        $this->options = $options;
    }

    public function getVideos() : \Generator
    {
        if (!empty($this->data->results)) {
            foreach ($this->data->results as $r) {
                $video = new Results\Videos($this->tmdb, $r);
                yield $video;
            }
        }
    }

}


1			<?php declare(strict_types = 1);
2			/**
3			* This file is part of the Tmdb package.
4			*
5			* (c) Vincent Faliès <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*
10			* @author Vincent Faliès <[email protected]>
11			* @copyright Copyright (c) 2017-2020
12			*/
13
14
15			namespace VfacTmdb\Items;
16
17			use VfacTmdb\Results;
18			use VfacTmdb\Interfaces\TmdbInterface;
19
20			/**
21			* Movie Videos class
22			* @package Tmdb
23			* @author Vincent Faliès <[email protected]>
24			* @copyright Copyright (c) 2017-2020
25			*/
26			class MovieVideos
27			{
28			/**
29			* Tmdb object
30			* @var TmdbInterface
31			*/
32			private $tmdb = null;
33			/**
34			* Logger object
35			* @var \Psr\Log\LoggerInterface
36			*/
37			protected $logger = null;
38			/**
39			* Params
40			* @var array
41			*/
42			protected $params = null;
43			/**
44			* Data
45			* @var \stdClass
46			*/
47			protected $data = null;
48			/**
49			* Options array
50			* @var array
51			*/
52			protected $options;
53
54			/**
55			* Constructor
56			* @param TmdbInterface $tmdb
57			* @param int $movie_id
58			* @param array $options
59			*/
60	3	View Code Duplication	public function __construct(TmdbInterface $tmdb, int $movie_id, array $options = array())
			0 ignored issues – show Duplication introduced 2020-01-17 21:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61			{
62	3		$this->tmdb = $tmdb;
63	3		$this->logger = $tmdb->getLogger();
64	3		$this->data = $this->tmdb->getRequest('movie/' . $movie_id . '/videos');
65	3		$this->options = $options;
66	3		}
67
68	3		public function getVideos() : \Generator
69			{
70	3		if (!empty($this->data->results)) {
71	3		foreach ($this->data->results as $r) {
72	3		$video = new Results\Videos($this->tmdb, $r);
73	3		yield $video;
74			}
75			}
76	3		}
77
78			}
79

vfalies / tmdb

Push — master ( 9635db...d1c97e )

MovieVideos::getVideos() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like