vfalies\tmdb\Genres

Complexity

Total Complexity

10

Size/Duplication

Total Lines	92
Duplicated Lines	23.91 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getMovieList()	11	11	2
A	getTVList()	11	11	2
A	getList()	0	20	3
A	genreItemGenerator()	0	7	2

<?php

namespace vfalies\tmdb;

class Genres implements Interfaces\GenresInterface
{

    protected $tmdb = null;

    /**
     * Constructor
     * @param \vfalies\tmdb\Tmdb $tmdb
     * @throws Exception
     */
    public function __construct(Tmdb $tmdb)
    {
        $this->tmdb = $tmdb;
    }

    /**
     * Get movie genres list
     * @param array $options
     * @return \Generator
     * @throws \Exception
     */
    public function getMovieList(array $options = array()): \Generator

This method seems to be duplicated in your project.

    {
        try
        {            
            return $this->getList('genre/movie/list', $options);
        }
        catch (\Exception $ex)
        {
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * Get TV genres list
     * @param array $options
     * @return \Generator
     * @throws \Exception
     */
    public function getTVList(array $options = array()): \Generator

This method seems to be duplicated in your project.

    {
        try
        {
            return $this->getList('genre/tv/list', $options);
        }
        catch (\Exception $ex)
        {
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * Generic getter list
     * @param string $type
     * @param array $options
     * @return \Generator
     * @throws \Exception
     */
    private function getList(string $type, array $options): \Generator
    {
        try
        {
            $params   = $this->tmdb->checkOptions($options);
            $response = $this->tmdb->sendRequest(new CurlRequest(), $type, null, $params);

            $genres = [];
            if (isset($response->genres))
            {
                $genres = $response->genres;
            }

            return $this->genreItemGenerator($genres);
        }
        catch (\Exception $ex)
        {
            throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
        }
    }

    /**
     * Genre Item generator method
     * @param array $results
     */
    private function genreItemGenerator(array $results): \Generator
    {
        foreach ($results as $result)
        {
            yield $result;
        }
    }

}