CardResourceTest::itReturnsASingleCard() - Code Metrics - Inspection of "Correct tests namespace" - verschoof/bunq-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b91597...be19b0 )

by Mitchel

created 2017-05-20 14:09 UTC

CardResourceTest::itReturnsASingleCard() A

↳ Parent: CardResourceTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	8

Duplication

Lines	20
Ratio	100 %

Importance

Changes

Metric	Value
dl	20
loc	20
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0

<?php

namespace Bunq\Tests\Resource;

use Bunq\BunqClient;
use Bunq\Resource\CardResource;
use PHPUnit\Framework\TestCase;
use Prophecy\Prophecy\ObjectProphecy;

final class CardResourceTest extends TestCase
{
    /**
     * @var BunqClient|ObjectProphecy
     */
    private $bunqClient;

    /**
     * @var CardResource
     */
    private $resource;

    public function setUp()
    {
        $this->bunqClient = $this->prophesize(BunqClient::class);
        $this->resource   = new CardResource($this->bunqClient->reveal());
    }

    /**
     * @test
     */
    public function itReturnsAListOfCards()
    {
        $this->bunqClient->get('/v1/user/1/card')->willReturn(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            [
                'Response' => [
                    [
                        'id' => 1,
                    ],
                    [
                        'id' => 2,
                    ],
                ],
            ]
        );

        $result = $this->resource->listCards(1);

        $expectedResult = [
            'Response' => [
                [
                    'id' => 1,
                ],
                [
                    'id' => 2,
                ],
            ],
        ];

        $this->assertEquals($expectedResult, $result);
    }

    /**
     * @test
     */
    public function itReturnsASingleCard()

    {
        $this->bunqClient->get('/v1/user/1/card/1')->willReturn(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            [
                'Response' => [
                    [
                        'id' => 1,
                    ],
                ],
            ]
        );

        $result = $this->resource->getCard(1, 1);

        $expectedResult = [
            'id' => 1,
        ];

        $this->assertEquals($expectedResult, $result);
    }
}



1		<?php
2
3		namespace Bunq\Tests\Resource;
4
5		use Bunq\BunqClient;
6		use Bunq\Resource\CardResource;
7		use PHPUnit\Framework\TestCase;
8		use Prophecy\Prophecy\ObjectProphecy;
9
10		final class CardResourceTest extends TestCase
11		{
12		/**
13		* @var BunqClient\|ObjectProphecy
14		*/
15		private $bunqClient;
16
17		/**
18		* @var CardResource
19		*/
20		private $resource;
21
22		public function setUp()
23		{
24		$this->bunqClient = $this->prophesize(BunqClient::class);
25		$this->resource = new CardResource($this->bunqClient->reveal());
26		}
27
28		/**
29		* @test
30		*/
31		public function itReturnsAListOfCards()
32		{
33		$this->bunqClient->get('/v1/user/1/card')->willReturn(
		0 ignored issues – show Bug introduced 2017-05-20 13:58 UTC by Report Bug Copy Issue Report The method `get` does only exist in `Bunq\BunqClient`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
34		[
35		'Response' => [
36		[
37		'id' => 1,
38		],
39		[
40		'id' => 2,
41		],
42		],
43		]
44		);
45
46		$result = $this->resource->listCards(1);
47
48		$expectedResult = [
49		'Response' => [
50		[
51		'id' => 1,
52		],
53		[
54		'id' => 2,
55		],
56		],
57		];
58
59		$this->assertEquals($expectedResult, $result);
60		}
61
62		/**
63		* @test
64		*/
65	View Code Duplication	public function itReturnsASingleCard()
		0 ignored issues – show Duplication introduced 2017-05-20 13:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		{
67		$this->bunqClient->get('/v1/user/1/card/1')->willReturn(
		0 ignored issues – show Bug introduced 2017-05-20 13:58 UTC by Report Bug Copy Issue Report The method `get` does only exist in `Bunq\BunqClient`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
68		[
69		'Response' => [
70		[
71		'id' => 1,
72		],
73		],
74		]
75		);
76
77		$result = $this->resource->getCard(1, 1);
78
79		$expectedResult = [
80		'id' => 1,
81		];
82
83		$this->assertEquals($expectedResult, $result);
84		}
85		}
86
87

verschoof / bunq-api

Push — master ( b91597...be19b0 )

CardResourceTest::itReturnsASingleCard() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like