Bunq\Tests\Certificate\Storage\FileCertificateStorageTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	43
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	4	4	1
A	itFindsACertificatedBasedOnAType()	12	12	1
A	itSavesACertificatesBasedOnAType()	11	11	1

<?php

namespace Bunq\Tests\Certificate\Storage;

use Bunq\Certificate\CertificateType;
use Bunq\Certificate\DefaultCertificate;
use Bunq\Certificate\Storage\FileCertificateStorage;
use PHPUnit\Framework\TestCase;

final class FileCertificateStorageTest extends TestCase

This class seems to be duplicated in your project.

{
    /**
     * @var FileCertificateStorage
     */
    private $storage;

    public function setUp()
    {
        $this->storage = new FileCertificateStorage('/tmp');
    }

    /**
     * @test
     */
    public function itFindsACertificatedBasedOnAType()
    {
        $certificate = DefaultCertificate::fromString('savedCertificate');
        $publicKey   = CertificateType::PRIVATE_KEY();

        @mkdir('/tmp/certificates');

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        file_put_contents('/tmp/certificates/' . $publicKey, $certificate->toString());

        $loadedCertificate = $this->storage->load($publicKey);

        $this->assertSame($certificate->toString(), $loadedCertificate->toString());
    }

    /**
     * @test
     */
    public function itSavesACertificatesBasedOnAType()
    {
        $certificate = DefaultCertificate::fromString('test');
        $publicKey   = CertificateType::PUBLIC_KEY();

        $this->storage->save($certificate, $publicKey);

        $result = @file_get_contents('/tmp/certificates/' . $publicKey);

        $this->assertSame($certificate->toString(), $result);
    }
}