RequestIdMiddlewareTest::itSetsAllHeadersAndRequestIdWhenNotGiven() - Code Metrics - Inspection of "Add bunq client" - verschoof/bunq-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 32a55a...fb9711 )

by Mitchel

created 2017-05-20 13:56 UTC

itSetsAllHeadersAndRequestIdWhenNotGiven() B

↳ Parent: RequestIdMiddlewareTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	29
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
c	0
b	0
f	0
rs	8.8571
cc	1
eloc	17
nc	1
nop	0

<?php

namespace Bunq\Test\Middleware;

use Bunq\Middleware\RequestIdMiddleware;
use GuzzleHttp\Psr7\Request;
use PHPUnit\Framework\TestCase;
use Prophecy\Prophecy\ObjectProphecy;
use Ramsey\Uuid\Uuid;
use Ramsey\Uuid\UuidFactory;

final class RequestIdMiddlewareTest extends TestCase
{
    /**
     * @var RequestIdMiddleware
     */
    private $middleware;

    public function setUp()
    {
        $this->middleware = new RequestIdMiddleware();
    }

    /**
     * @test
     */
    public function itSetsAllHeadersAndRequestIdWhenNotGiven()
    {
        $request = new Request('GET', 'uri', ['other-existing-header' => 'value']);

        // Create a Uuid object from a known UUID string
        $stringUuid = '253e0f90-8842-4731-91dd-0191816e6a28';
        $uuid       = Uuid::fromString($stringUuid);

        /** @var UuidFactory|ObjectProphecy $factoryMock */
        $factoryMock = $this->prophesize(UuidFactory::class);
        $factoryMock->uuid4()->willReturn($uuid);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        // Replace the default factory with our mock
        Uuid::setFactory($factoryMock->reveal());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $result = $this->middleware->__invoke($request);

        $headers         = [
            'X-Bunq-Client-Request-Id' => '253e0f90-8842-4731-91dd-0191816e6a28',
            'Cache-Control'            => 'no-cache',
            'X-Bunq-Geolocation'       => '52.3 4.89 12 100 NL',
            'X-Bunq-Language'          => 'nl_NL',
            'X-Bunq-Region'            => 'nl_NL',
            'other-existing-header'    => 'value',
        ];
        $expectedRequest = new Request('GET', 'uri', $headers, $request->getBody());

        $this->assertEquals($expectedRequest, $result);
    }

    /**
     * @test
     */
    public function itSetsAllHeadersAndNotRequestIdWhenGiven()
    {
        $givenRequestId = '253e0f90-8842-4731-91dd-0191816e6a29';
        $request        = new Request('GET', 'uri', []);

        $result = $this->middleware->__invoke($request, ['request-id' => $givenRequestId]);

        $headers         = [
            'X-Bunq-Client-Request-Id' => $givenRequestId,
            'Cache-Control'            => 'no-cache',
            'X-Bunq-Geolocation'       => '52.3 4.89 12 100 NL',
            'X-Bunq-Language'          => 'nl_NL',
            'X-Bunq-Region'            => 'nl_NL',
        ];
        $expectedRequest = new Request('GET', 'uri', $headers, $request->getBody());

        $this->assertEquals($expectedRequest, $result);

    }
}



Push — master ( 32a55a...fb9711 )

itSetsAllHeadersAndRequestIdWhenNotGiven() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Bunq\Test\Middleware;
4
5			use Bunq\Middleware\RequestIdMiddleware;
6			use GuzzleHttp\Psr7\Request;
7			use PHPUnit\Framework\TestCase;
8			use Prophecy\Prophecy\ObjectProphecy;
9			use Ramsey\Uuid\Uuid;
10			use Ramsey\Uuid\UuidFactory;
11
12			final class RequestIdMiddlewareTest extends TestCase
13			{
14			/**
15			* @var RequestIdMiddleware
16			*/
17			private $middleware;
18
19			public function setUp()
20			{
21			$this->middleware = new RequestIdMiddleware();
22			}
23
24			/**
25			* @test
26			*/
27			public function itSetsAllHeadersAndRequestIdWhenNotGiven()
28			{
29			$request = new Request('GET', 'uri', ['other-existing-header' => 'value']);
30
31			// Create a Uuid object from a known UUID string
32			$stringUuid = '253e0f90-8842-4731-91dd-0191816e6a28';
33			$uuid = Uuid::fromString($stringUuid);
34
35			/** @var UuidFactory\|ObjectProphecy $factoryMock */
36			$factoryMock = $this->prophesize(UuidFactory::class);
37			$factoryMock->uuid4()->willReturn($uuid);
			0 ignored issues – show Bug introduced 2017-05-20 13:58 UTC by Report Bug Copy Issue Report The method `uuid4` does only exist in `Ramsey\Uuid\UuidFactory`, but not in `Prophecy\Prophecy\ObjectProphecy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38
39			// Replace the default factory with our mock
40			Uuid::setFactory($factoryMock->reveal());
			0 ignored issues – show Bug introduced 2017-05-20 13:58 UTC by Report Bug Copy Issue Report The method `reveal` does only exist in `Prophecy\Prophecy\ObjectProphecy`, but not in `Ramsey\Uuid\UuidFactory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
41
42			$result = $this->middleware->__invoke($request);
43
44			$headers = [
45			'X-Bunq-Client-Request-Id' => '253e0f90-8842-4731-91dd-0191816e6a28',
46			'Cache-Control' => 'no-cache',
47			'X-Bunq-Geolocation' => '52.3 4.89 12 100 NL',
48			'X-Bunq-Language' => 'nl_NL',
49			'X-Bunq-Region' => 'nl_NL',
50			'other-existing-header' => 'value',
51			];
52			$expectedRequest = new Request('GET', 'uri', $headers, $request->getBody());
53
54			$this->assertEquals($expectedRequest, $result);
55			}
56
57			/**
58			* @test
59			*/
60			public function itSetsAllHeadersAndNotRequestIdWhenGiven()
61			{
62			$givenRequestId = '253e0f90-8842-4731-91dd-0191816e6a29';
63			$request = new Request('GET', 'uri', []);
64
65			$result = $this->middleware->__invoke($request, ['request-id' => $givenRequestId]);
66
67			$headers = [
68			'X-Bunq-Client-Request-Id' => $givenRequestId,
69			'Cache-Control' => 'no-cache',
70			'X-Bunq-Geolocation' => '52.3 4.89 12 100 NL',
71			'X-Bunq-Language' => 'nl_NL',
72			'X-Bunq-Region' => 'nl_NL',
73			];
74			$expectedRequest = new Request('GET', 'uri', $headers, $request->getBody());
75
76			$this->assertEquals($expectedRequest, $result);
77
78			}
79			}
80
81

verschoof / bunq-api

Push — master ( 32a55a...fb9711 )

itSetsAllHeadersAndRequestIdWhenNotGiven() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like