UserServiceTest - Code Metrics - Inspection of "fixing tests" - veraguido/gv - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fb1eb0...02cee8 )

by Guido

created 2020-03-05 17:46 UTC

UserServiceTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	181
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
dl	0
loc	181
rs	10
c	0
b	0
f	0
wmc	6
lcom	1
cbo	7

5 Methods

Rating	Name	Size	Complexity
A	validateEmail()	7	1
A	generateAndValidatePassword()	7	1
A	login()	48	1
A	logout()	19	1
A	testUserAuthorization()	27	1

<?php

use Gvera\Helpers\validation\ValidationService;
use Gvera\Models\User;
use Gvera\Models\UserRole;
use Doctrine\ORM\EntityRepository;
use Gvera\Helpers\session\Session;
use Gvera\Helpers\entities\GvEntityManager;
use PHPUnit\Framework\TestCase;

class UserServiceTest extends TestCase
{

    private $userService;
    /**
     * @test
     */
    private $user;
    /**
     * @var EntityRepository|\PHPUnit\Framework\MockObject\MockObject
     */
    private $repo;
    /**
     * @var GvEntityManager|\PHPUnit\Framework\MockObject\MockObject
     */
    private $gvEntityManager;

    public function validateEmail()
    {
        $invalidEmail = 'test';
        $this->assertFalse($this->userService->validateEmail($invalidEmail));
        $validEmail = '[email protected]';
        $this->assertTrue($this->userService->validateEmail($validEmail));
    }

    public function setUp():void
    {
        $this->repo = $this->createMock(EntityRepository::class);


        $this->gvEntityManager = $this->createMock(GvEntityManager::class);
        $gvEntityManager = $this->gvEntityManager;
        $gvEntityManager->expects($this->any())
            ->method('getRepository')
            ->willReturn($this->repo);

        $session = $this->createMock(Session::class);
        $session->expects($this->any())
            ->method('set')
            ->with($this->isType('string'), $this->isType('array'))
            ->willReturn(true);

        $this->userService = new \Gvera\Services\UserService($gvEntityManager, $session, new ValidationService());

        $role = new UserRole();
        $role->setName("testRole");
        $role->setRolePriority(5);

        $user = new User();
        $user->setEmail("[email protected]");
        $user->setUsername("test");
        $user->setRole($role);

        $this->user = $user;
        $passHash = $this->userService->generatePassword('test');
        $user->setPassword($passHash);



        $session->expects($this->any())
            ->method('get')
            ->with('user')
            ->willReturn(['role' => $role->getRolePriority(), 'username' => $user->getUsername()]);

        parent::setUp(); // TODO: Change the autogenerated stub
    }

    /**
     * @test
     */
    public function generateAndValidatePassword()
    {
        $passHash = $this->userService->generatePassword('password');
        $this->assertNotNull($passHash);

        $this->assertTrue($this->userService->validatePassword('password', $passHash));
    }

    /**
     * @test
     */
    public function login()
    {
        $this->expectException(Exception::class);


        $user = new User();
        $user->setEmail("[email protected]");
        $user->setUsername("test");
        $passHash = $this->userService->generatePassword('test');
        $user->setPassword($passHash);


        $repo = $this->createMock(EntityRepository::class);
        $repo->expects($this->any())
            ->method('findOneBy')
            ->willReturn($user);

        $gvEntityManager = $this->createMock(GvEntityManager::class);
        $gvEntityManager->expects($this->any())
            ->method('getRepository')
            ->willReturn($repo);

        $role = new UserRole();
        $role->setName("testRole");
        $role->setRolePriority(5);

        $user->setRole($role);

        $session = $this->createMock(Session::class);
        $session->expects($this->any())
            ->method('set')
            ->with($this->isType('string'), $this->isType('array'))
            ->willReturn(true);
        
        $session->expects($this->any())
            ->method('get')
            ->with('user')
            ->willReturn(['role' => $role->getRolePriority(), 'username' => $user->getUsername()]);
            

        $this->userService->entityManager = $gvEntityManager;
        $this->userService->session = $session;

        $this->userService->login($user->getUsername(), $passHash);
        $this->assertTrue($session->get('user')['username'] === $user->getUsername());

        $this->assertTrue($this->userService->getUserRole() === 5);
        $this->userService->login($user->getUsername(), 'failedpass');
    }

    /**
     * @test
     */
    public function logout()
    {
        $session = $this->createMock(Session::class);
        $session->expects($this->any())
            ->method('unsetByKey')
            ->with('user')
            ->willReturn(true);
        
        $session->expects($this->any())
            ->method('get')
            ->with('user')
            ->willReturn(null);

        $this->userService->session = $session;

        $this->userService->logout();

        $this->assertFalse($this->userService->isUserLoggedIn());
    }

    public function testUserAuthorization()
    {

        $roleAction = new \Gvera\Models\UserRoleAction();
        $roleAction->setActionName('test');

        $role = new UserRole();
        $role->setName("testRole");
        $role->setRolePriority(5);
        $role->addRoleAction($roleAction);

        $this->gvEntityManager->expects($this->any())->method('getRepository')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->willReturn($this->repo);

        $this->repo->expects($this->any())->method('findOneBy')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->willReturn($roleAction);

        $user = new User();
        $user->setEmail("[email protected]");
        $user->setUsername("test");
        $user->setRole($role);


        $this->assertTrue($this->userService->userCan($user, 'test'));
        $this->assertFalse($this->userService->userCan(null, 'asd'));

    }
}

1			<?php
2
3			use Gvera\Helpers\validation\ValidationService;
4			use Gvera\Models\User;
5			use Gvera\Models\UserRole;
6			use Doctrine\ORM\EntityRepository;
7			use Gvera\Helpers\session\Session;
8			use Gvera\Helpers\entities\GvEntityManager;
9			use PHPUnit\Framework\TestCase;
10
11			class UserServiceTest extends TestCase
12			{
13
14			private $userService;
15			/**
16			* @test
17			*/
18			private $user;
19			/**
20			* @var EntityRepository\|\PHPUnit\Framework\MockObject\MockObject
21			*/
22			private $repo;
23			/**
24			* @var GvEntityManager\|\PHPUnit\Framework\MockObject\MockObject
25			*/
26			private $gvEntityManager;
27
28			public function validateEmail()
29			{
30			$invalidEmail = 'test';
31			$this->assertFalse($this->userService->validateEmail($invalidEmail));
32			$validEmail = '[email protected]';
33			$this->assertTrue($this->userService->validateEmail($validEmail));
34			}
35
36			public function setUp():void
37			{
38			$this->repo = $this->createMock(EntityRepository::class);
39
40
41			$this->gvEntityManager = $this->createMock(GvEntityManager::class);
42			$gvEntityManager = $this->gvEntityManager;
43			$gvEntityManager->expects($this->any())
44			->method('getRepository')
45			->willReturn($this->repo);
46
47			$session = $this->createMock(Session::class);
48			$session->expects($this->any())
49			->method('set')
50			->with($this->isType('string'), $this->isType('array'))
51			->willReturn(true);
52
53			$this->userService = new \Gvera\Services\UserService($gvEntityManager, $session, new ValidationService());
54
55			$role = new UserRole();
56			$role->setName("testRole");
57			$role->setRolePriority(5);
58
59			$user = new User();
60			$user->setEmail("[email protected]");
61			$user->setUsername("test");
62			$user->setRole($role);
63
64			$this->user = $user;
65			$passHash = $this->userService->generatePassword('test');
66			$user->setPassword($passHash);
67
68
69
70			$session->expects($this->any())
71			->method('get')
72			->with('user')
73			->willReturn(['role' => $role->getRolePriority(), 'username' => $user->getUsername()]);
74
75			parent::setUp(); // TODO: Change the autogenerated stub
76			}
77
78			/**
79			* @test
80			*/
81			public function generateAndValidatePassword()
82			{
83			$passHash = $this->userService->generatePassword('password');
84			$this->assertNotNull($passHash);
85
86			$this->assertTrue($this->userService->validatePassword('password', $passHash));
87			}
88
89			/**
90			* @test
91			*/
92			public function login()
93			{
94			$this->expectException(Exception::class);
95
96
97			$user = new User();
98			$user->setEmail("[email protected]");
99			$user->setUsername("test");
100			$passHash = $this->userService->generatePassword('test');
101			$user->setPassword($passHash);
102
103
104			$repo = $this->createMock(EntityRepository::class);
105			$repo->expects($this->any())
106			->method('findOneBy')
107			->willReturn($user);
108
109			$gvEntityManager = $this->createMock(GvEntityManager::class);
110			$gvEntityManager->expects($this->any())
111			->method('getRepository')
112			->willReturn($repo);
113
114			$role = new UserRole();
115			$role->setName("testRole");
116			$role->setRolePriority(5);
117
118			$user->setRole($role);
119
120			$session = $this->createMock(Session::class);
121			$session->expects($this->any())
122			->method('set')
123			->with($this->isType('string'), $this->isType('array'))
124			->willReturn(true);
125
126			$session->expects($this->any())
127			->method('get')
128			->with('user')
129			->willReturn(['role' => $role->getRolePriority(), 'username' => $user->getUsername()]);
130
131
132			$this->userService->entityManager = $gvEntityManager;
133			$this->userService->session = $session;
134
135			$this->userService->login($user->getUsername(), $passHash);
136			$this->assertTrue($session->get('user')['username'] === $user->getUsername());
			0 ignored issues – show Bug introduced 2020-01-03 15:35 UTC by Report Bug Copy Issue Report The method `get()` does not seem to exist on `object<PHPUnit\Framework\MockObject\MockObject>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
137			$this->assertTrue($this->userService->getUserRole() === 5);
138			$this->userService->login($user->getUsername(), 'failedpass');
139			}
140
141			/**
142			* @test
143			*/
144			public function logout()
145			{
146			$session = $this->createMock(Session::class);
147			$session->expects($this->any())
148			->method('unsetByKey')
149			->with('user')
150			->willReturn(true);
151
152			$session->expects($this->any())
153			->method('get')
154			->with('user')
155			->willReturn(null);
156
157			$this->userService->session = $session;
158
159			$this->userService->logout();
160
161			$this->assertFalse($this->userService->isUserLoggedIn());
162			}
163
164			public function testUserAuthorization()
165			{
166
167			$roleAction = new \Gvera\Models\UserRoleAction();
168			$roleAction->setActionName('test');
169
170			$role = new UserRole();
171			$role->setName("testRole");
172			$role->setRolePriority(5);
173			$role->addRoleAction($roleAction);
174
175			$this->gvEntityManager->expects($this->any())->method('getRepository')
			0 ignored issues – show Bug introduced 2020-03-05 17:54 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit\Framework\MockObject\MockObject`, but not in `Gvera\Helpers\entities\GvEntityManager`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
176			->willReturn($this->repo);
177
178			$this->repo->expects($this->any())->method('findOneBy')
			0 ignored issues – show Bug introduced 2020-03-05 17:54 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit\Framework\MockObject\MockObject`, but not in `Doctrine\ORM\EntityRepository`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
179			->willReturn($roleAction);
180
181			$user = new User();
182			$user->setEmail("[email protected]");
183			$user->setUsername("test");
184			$user->setRole($role);
185
186
187			$this->assertTrue($this->userService->userCan($user, 'test'));
188			$this->assertFalse($this->userService->userCan(null, 'asd'));
189
190			}
191			}

veraguido / gv

Push — master ( fb1eb0...02cee8 )

UserServiceTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like