Venta\Routing\UrlGenerator

Complexity

Total Complexity

9

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

56.76%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	toCurrent()	0	12	2
A	toRoute()	0	12	2
A	buildRouteUri()	0	13	4

<?php declare(strict_types = 1);

namespace Venta\Routing;

use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\UriInterface;
use Venta\Contracts\Http\Request;
use Venta\Contracts\Routing\Route as RouteContract;
use Venta\Contracts\Routing\RouteCollection as RouteCollectionContract;
use Venta\Contracts\Routing\UrlGenerator as UrlGeneratorContract;
use Venta\Routing\Exception\RouteNotFoundException;

/**
 * Class UrlGenerator
 *
 * @package Venta\Routing
 */
class UrlGenerator implements UrlGeneratorContract
{
    /**
     * @var ServerRequestInterface
     */
    private $request;

    /**
     * @var RouteCollection
     */
    private $routes;

    /**
     * @var UriInterface
     */
    private $uri;

    /**
     * UrlGenerator constructor.
     *
     * @param Request $request
     * @param RouteCollectionContract $routes
     * @param UriInterface $uri
     */
    public function __construct(Request $request, RouteCollectionContract $routes, UriInterface $uri)
    {
        $this->request = $request;
        $this->routes = $routes;

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

$routes is of type object<Venta\Contracts\Routing\RouteCollection>, but the property $routes was declared to be of type object<Venta\Routing\RouteCollection>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->uri = $uri;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

    }

    /**
     * @inheritDoc
     */
    public function toCurrent(array $variables = [], array $query = []): UriInterface
    {
        $route = $this->request->getRoute();

It seems like you code against a concrete implementation and not the interface Psr\Http\Message\ServerRequestInterface as the method getRoute() does only exist in the following implementations of said interface: Venta\Http\Request.

        if ($route === null) {
            throw new RouteNotFoundException(
                sprintf('Unable to generate an URL for current.')
            );
        }

        return $this->buildRouteUri($route, $variables, $query);
    }

    /**
     * @inheritDoc
     */
    public function toRoute(string $routeName, array $variables = [], array $query = []): UriInterface
    {
        $route = $this->routes->findByName($routeName);

        if ($route === null) {
            throw new RouteNotFoundException(
                sprintf('Unable to generate an URL for the named route "%s" as such route does not exist.', $routeName)
            );
        }

        return $this->buildRouteUri($route, $variables, $query);
    }

    /**
     * Builds URI for provided route instance.
     *
     * @param RouteContract $route
     * @param array $variables
     * @param array $query
     * @return UriInterface
     */
    private function buildRouteUri(RouteContract $route, array $variables = [], array $query = []): UriInterface
    {
        $uri = $this->uri
            ->withScheme($route->getScheme() ?: $this->request->getUri()->getScheme())
            ->withHost($route->getHost() ?: $this->request->getUri()->getHost())
            ->withPath($route->compilePath($variables));

        if ($query) {

The expression $query of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $uri = $uri->withQuery(http_build_query($query));
        }

        return $uri;
    }
}