Venta\Http\Cookie

Complexity

Total Complexity

31

Size/Duplication

Total Lines	229
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

97.22%

Importance

Changes

0

17 Methods

Rating	Name	Duplication	Size	Complexity
D	__construct()	0	36	9
A	createFromString()	0	11	1
A	inDateInterval()	0	4	1
A	inDays()	0	4	1
A	inHours()	0	4	1
A	inMinutes()	0	4	1
A	inMonths()	0	4	1
A	inWeeks()	0	6	1
A	outdated()	0	4	1
C	__toString()	0	32	7
A	asPlainText()	0	4	1
A	getDomain()	0	4	1
A	getExpireTime()	0	4	1
A	getName()	0	4	1
A	getValue()	0	4	1
A	isHttpOnly()	0	4	1
A	isSecure()	0	4	1

<?php declare(strict_types = 1);

namespace Venta\Http;

use Venta\Contracts\Http\Cookie as CookieContract;

/**
 * Class Cookie
 *
 * @package Venta\Http
 */
class Cookie implements CookieContract
{
    protected $domain;

    protected $expire;

    protected $httpOnly;

    protected $name;

    protected $path;

    protected $secure;

    protected $value;

    /**
     * Cookie constructor.
     *
     * @param        $name
     * @param null $value
     * @param int $expire
     * @param string $path
     * @param null $domain
     * @param bool $secure
     * @param bool $httpOnly
     */
    public function __construct(
        $name,
        $value = null,
        $expire = 0,
        $path = '/',
        $domain = null,
        $secure = false,
        $httpOnly = true
    ) {
        if (preg_match("/[=,; \t\r\n\013\014]/", $name)) {
            throw new \InvalidArgumentException(sprintf('The cookie name "%s" contains invalid characters.', $name));
        }

        if (empty($name)) {
            throw new \InvalidArgumentException('The cookie name cannot be empty.');
        }

        $expire = ($expire === "") ? 0 : $expire;

The strict comparison === seems to always evaluate to false as the types of $expire (integer) and '' (string) can never be identical. Maybe you want to use a loose comparison == instead?

The string literal does not require double quotes, as per coding-style, please use single quotes.

        if ($expire instanceof \DateTimeInterface) {
            $expire = $expire->format('U');
        } elseif (!is_numeric($expire)) {
            $expire = strtotime($expire);

            if (false === $expire || -1 === $expire) {
                throw new \InvalidArgumentException('The cookie expiration time is not valid.');
            }
        }

        $this->name = $name;
        $this->value = $value;
        $this->domain = $domain;
        $this->expire = $expire;
        $this->path = empty($path) ? '/' : $path;
        $this->secure = (bool)$secure;
        $this->httpOnly = (bool)$httpOnly;
    }

    public static function createFromString(string $cookie)
    {
        $cookie = str_replace(' ', '', $cookie);
        $pattern =
            '/^(\w+)=(\w+);(?:expires=([^\s|\;]+);)?(?:path=([^\s|\;]+);)?(?:domain=([^\s|\;]+);)?(?:(secure);)?(httponly)?/';

This line exceeds maximum limit of 120 characters; contains 126 characters

        preg_match($pattern, $cookie, $result);
        array_shift($result);
        $reflected = new \ReflectionClass(self::class);

        return $reflected->newInstanceArgs($result);
    }

    /**
     * @param $string
     * @return int timestamp
     */
    public static function inDateInterval(string $string)
    {
        return (new \DateTime('now'))->add(new \DateInterval($string))->getTimestamp();
    }

    /**
     * @param $days
     * @return int timestamp
     */
    public static function inDays($days)
    {
        return (new \DateTime('now'))->add(new \DateInterval('P' . $days . 'D'))->getTimestamp();
    }

    /**
     * @param $hours
     * @return int timestamp
     */
    public static function inHours($hours)
    {
        return (new \DateTime('now'))->add(new \DateInterval('PT' . $hours . 'H'))->getTimestamp();
    }

    /**
     * @param $minutes
     * @return int timestamp
     */
    public static function inMinutes($minutes)
    {
        return (new \DateTime('now'))->add(new \DateInterval('PT' . $minutes . 'M'))->getTimestamp();
    }

    /**
     * @param $months
     * @return int timestamp
     */
    public static function inMonths($months)
    {
        return (new \DateTime('now'))->add(new \DateInterval('P' . $months . 'M'))->getTimestamp();
    }

    /**
     * @param $days
     * @return int timestamp
     */
    public static function inWeeks($days)
    {
        $weeks = $days * 7;

        return (new \DateTime('now'))->add(new \DateInterval('P' . $weeks . 'D'))->getTimestamp();
    }

    /**
     * @return int timestamp
     */
    public static function outdated()
    {
        return (new \DateTime('now'))->sub(new \DateInterval('P12M'))->getTimestamp();
    }

    /**
     * @return string
     */
    public function __toString()
    {
        $str = urlencode($this->getName()) . '=';

        if ('' === (string)$this->getValue()) {
            $str .= 'deleted; expires=' . gmdate('D, d-M-Y H:i:s T', static::outdated());
        } else {
            $str .= urlencode($this->getValue());

            if ($this->getExpireTime() !== 0) {
                $str .= '; expires=' . gmdate('D, d-M-Y H:i:s T', $this->getExpireTime());
            }
        }

        if ($this->path) {
            $str .= '; path=' . $this->path;
        }

        if ($this->getDomain()) {

The expression $this->getDomain() of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $str .= '; domain=' . $this->getDomain();
        }

        if (true === $this->isSecure()) {
            $str .= '; secure';
        }

        if (true === $this->isHttpOnly()) {
            $str .= '; httponly';
        }

        return (string)$str;
    }

    public function asPlainText()
    {
        return $this->__toString();
    }

    /**
     * @return string

Should the return type not be string|null?

     */
    public function getDomain()
    {
        return $this->domain;
    }

    /**
     * @return int|string timestamp
     */
    public function getExpireTime()
    {
        return $this->expire;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return string|null
     */
    public function getValue()
    {
        return $this->value;
    }

    /**
     * @return bool
     */
    public function isHttpOnly()
    {
        return $this->httpOnly;
    }

    /**
     * @return bool
     */
    public function isSecure()
    {
        return $this->secure;
    }
}