Venta\Config\ConfigBuilder

Complexity

Total Complexity

16

Size/Duplication

Total Lines	125
Duplicated Lines	27.2 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	addFileParser()	0	4	1
A	build()	0	4	1
A	merge()	0	4	1
A	mergeFile()	0	12	4
A	push()	17	17	4
A	set()	17	17	4

<?php

namespace Venta\Config;

use Venta\Contracts\Config\Config;

This use statement conflicts with another class in this namespace, Venta\Config\Config.

use Venta\Contracts\Config\ConfigBuilder as ConfigBuilderContract;
use Venta\Contracts\Config\ConfigFactory as ConfigFactoryContract;
use Venta\Contracts\Config\ConfigFileParser;
use Venta\Contracts\Config\ConfigParser;

/**
 * Class ConfigBuilder
 *
 * @package Venta\Config
 */
class ConfigBuilder implements ConfigBuilderContract
{
    /**
     * @var ConfigFactory
     */
    private $configFactory;

    /**
     * Items holder array.
     *
     * @var array
     */
    private $items = [];

    /**
     * @var ConfigFileParser[]|ConfigParser[]
     */
    private $parsers = [];

    /**
     * Construct function.
     *
     * @param null|ConfigFactoryContract $configFactory
     */
    public function __construct(ConfigFactoryContract $configFactory = null)
    {
        $this->configFactory = $configFactory ?? new ConfigFactory();

$configFactory ?? new \Venta\Config\ConfigFactory() is of type object<Venta\Contracts\Config\ConfigFactory>, but the property $configFactory was declared to be of type object<Venta\Config\ConfigFactory>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @inheritDoc
     */
    public function addFileParser(ConfigFileParser $parser)
    {
        $this->parsers[] = $parser;
    }

    /**
     * @inheritDoc
     */
    public function build(): Config
    {
        return $this->configFactory->create($this->items);
    }

    /**
     * Merges configuration data.
     *
     * @param array $config
     * @return void
     */
    public function merge(array $config)
    {
        $this->items = array_merge_recursive($this->items, $config);
    }

    /**
     * Merges configuration data form file.
     *
     * @param string $filename
     * @return void
     */
    public function mergeFile(string $filename)
    {
        // TODO: extension of file can be empty. Exception in that case, or just ignore it?
        $extension = pathinfo($filename, PATHINFO_EXTENSION);

        foreach ($this->parsers as $parser) {
            if (($parser instanceof ConfigFileParser) && in_array($extension, $parser->supportedExtensions())) {
                $this->merge($parser->fromFile($filename));
                break;
            }
        }
    }

    /**
     * Appends a value to a config array.
     *
     * @param string $path
     * @param mixed  $value
     * @return void
     */
    public function push(string $path, $value)

This method seems to be duplicated in your project.

    {
        $keys = explode('.', $path);
        $array = &$this->items;

        while (count($keys) > 0) {
            $activeKey = array_shift($keys);

            if (!isset($array[$activeKey]) || !is_array($array[$activeKey])) {
                $array[$activeKey] = [$array[$activeKey]];
            }

            $array = &$array[$activeKey];
        }

        array_push($array, $value);
    }

    /**
     * Sets value to the configuration data.
     *
     * @param string $path
     * @param        $value
     * @return void
     */
    public function set(string $path, $value)

This method seems to be duplicated in your project.

    {
        $keys = explode('.', $path);
        $array = &$this->items;

        while (count($keys) > 1) {
            $activeKey = array_shift($keys);

            if (!isset($array[$activeKey]) || !is_array($array[$activeKey])) {
                $array[$activeKey] = [];
            }

            $array = &$array[$activeKey];
        }

        $array[array_shift($keys)] = $value;
    }
}