CommandCollection::addCommand() - Code Metrics - Inspection of "Upgrade console." - venta/framework - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (b3e807)

by Alexey

created 2016-12-07 09:06 UTC

CommandCollection::addCommand() A

↳ Parent: CommandCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1

<?php declare(strict_types = 1);

namespace Venta\Console;

use ArrayIterator;
use InvalidArgumentException;
use Symfony\Component\Console\Command\Command;
use Venta\Contracts\Console\CommandCollection as CommandCollectionContract;

/**
 * Class CommandCollection
 *
 * @package Venta\Console
 */
class CommandCollection implements CommandCollectionContract
{
    /**
     * @var string[]
     */
    protected $commands = [];

    /**
     * @inheritDoc
     */
    public function addCommand(string $commandClass)
    {
        if (!is_subclass_of($commandClass, Command::class)) {
            throw new InvalidArgumentException(
                sprintf('Provided command "%s" is not subclass of "%s" class.', $commandClass, Command::class)
            );
        }
        $this->commands[] = $commandClass;
    }

    /**
     * @inheritDoc
     */
    public function getCommands(): array
    {
        return array_unique($this->commands);
    }

    /**
     * @inheritDoc
     */
    public function getIterator()
    {
        return new ArrayIterator($this->getCommands());
    }
}

1			<?php declare(strict_types = 1);
2
3			namespace Venta\Console;
4
5			use ArrayIterator;
6			use InvalidArgumentException;
7			use Symfony\Component\Console\Command\Command;
8			use Venta\Contracts\Console\CommandCollection as CommandCollectionContract;
9
10			/**
11			* Class CommandCollection
12			*
13			* @package Venta\Console
14			*/
15			class CommandCollection implements CommandCollectionContract
16			{
17			/**
18			* @var string[]
19			*/
20			protected $commands = [];
21
22			/**
23			* @inheritDoc
24			*/
25			public function addCommand(string $commandClass)
26			{
27			if (!is_subclass_of($commandClass, Command::class)) {
28			throw new InvalidArgumentException(
29			sprintf('Provided command "%s" is not subclass of "%s" class.', $commandClass, Command::class)
30			);
31			}
32			$this->commands[] = $commandClass;
33			}
34
35			/**
36			* @inheritDoc
37			*/
38			public function getCommands(): array
39			{
40			return array_unique($this->commands);
41			}
42
43			/**
44			* @inheritDoc
45			*/
46			public function getIterator()
47			{
48			return new ArrayIterator($this->getCommands());
49			}
50			}

venta / framework

Branch — master (b3e807)

CommandCollection::addCommand() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like